2819f23ac1
The update to removing the eventfs_file changed the way the events top
level directory was handled. Instead of returning a dentry, it now returns
the eventfs_inode. In this changed, the removing of the events top level
directory is not much different than removing any of the other
directories. Because of this, the removal just called eventfs_remove_dir()
instead of eventfs_remove_events_dir().
Although eventfs_remove_dir() does the clean up, it misses out on the
dget() of the ei->dentry done in eventfs_create_events_dir(). It makes
more sense to match eventfs_create_events_dir() with a specific function
eventfs_remove_events_dir() and this specific function can then perform
the dput() to the dentry that had the dget() when it was created.
Fixes: 5790b1fb3d ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310051743.y9EobbUr-lkp@intel.com/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
64 lines
1.7 KiB
C
64 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* tracefs.h - a pseudo file system for activating tracing
|
|
*
|
|
* Based on debugfs by: 2004 Greg Kroah-Hartman <greg@kroah.com>
|
|
*
|
|
* Copyright (C) 2014 Red Hat Inc, author: Steven Rostedt <srostedt@redhat.com>
|
|
*
|
|
* tracefs is the file system that is used by the tracing infrastructure.
|
|
*/
|
|
|
|
#ifndef _TRACEFS_H_
|
|
#define _TRACEFS_H_
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct file_operations;
|
|
|
|
#ifdef CONFIG_TRACING
|
|
|
|
struct eventfs_file;
|
|
|
|
typedef int (*eventfs_callback)(const char *name, umode_t *mode, void **data,
|
|
const struct file_operations **fops);
|
|
|
|
struct eventfs_entry {
|
|
const char *name;
|
|
eventfs_callback callback;
|
|
};
|
|
|
|
struct eventfs_inode;
|
|
|
|
struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry *parent,
|
|
const struct eventfs_entry *entries,
|
|
int size, void *data);
|
|
|
|
struct eventfs_inode *eventfs_create_dir(const char *name, struct eventfs_inode *parent,
|
|
const struct eventfs_entry *entries,
|
|
int size, void *data);
|
|
|
|
void eventfs_remove_events_dir(struct eventfs_inode *ei);
|
|
void eventfs_remove_dir(struct eventfs_inode *ei);
|
|
|
|
struct dentry *tracefs_create_file(const char *name, umode_t mode,
|
|
struct dentry *parent, void *data,
|
|
const struct file_operations *fops);
|
|
|
|
struct dentry *tracefs_create_dir(const char *name, struct dentry *parent);
|
|
|
|
void tracefs_remove(struct dentry *dentry);
|
|
|
|
struct dentry *tracefs_create_instance_dir(const char *name, struct dentry *parent,
|
|
int (*mkdir)(const char *name),
|
|
int (*rmdir)(const char *name));
|
|
|
|
bool tracefs_initialized(void);
|
|
|
|
#endif /* CONFIG_TRACING */
|
|
|
|
#endif
|