Yonghong Song c0c852dd18
bpf: Do not mark certain LSM hook arguments as trusted ...
Martin mentioned that the verifier cannot assume arguments from
LSM hook sk_alloc_security being trusted since after the hook
is called, the sk ref_count is set to 1. This will overwrite
the ref_count changed by the bpf program and may cause ref_count
underflow later on.
I then further checked some other hooks. For example,
for bpf_lsm_file_alloc() hook in fs/file_table.c,
f->f_cred = get_cred(cred);
error = security_file_alloc(f);
if (unlikely(error)) {
file_free_rcu(&f->f_rcuhead);
return ERR_PTR(error);
}
atomic_long_set(&f->f_count, 1);
The input parameter 'f' to security_file_alloc() cannot be trusted
as well.
Specifically, I investiaged bpf_map/bpf_prog/file/sk/task alloc/free
lsm hooks. Except bpf_map_alloc and task_alloc, arguments for all other
hooks should not be considered as trusted. This may not be a complete
list, but it covers common usage for sk and task.
Fixes: 3f00c52393yhs@fb.com >
Link: https://lore.kernel.org/r/20221203204954.2043348-1-yhs@fb.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org >
2022-12-04 12:59:58 -08:00
2022-10-27 13:23:43 +02:00
2022-11-04 12:59:25 +02:00
2022-11-24 16:01:04 +01:00
2022-10-04 19:18:08 +02:00
2022-10-16 11:08:19 -07:00
2022-09-04 22:49:35 +05:30
2022-11-22 20:41:53 -08:00
2022-09-20 08:33:04 -07:00
2022-09-04 22:12:15 +02:00
2022-09-05 18:08:42 +01:00
2022-09-16 06:38:50 -07:00
2022-10-03 11:08:33 +01:00
2022-09-28 16:09:49 +01:00
2022-11-29 13:04:52 -08:00
2022-10-06 13:31:13 +02:00
2022-10-08 08:56:37 -07:00
2022-10-10 09:27:46 -07:00
2022-10-07 16:48:26 -07:00
2022-10-11 10:53:25 -07:00
2022-10-03 21:52:33 -07:00
2022-09-29 15:20:14 +01:00
2022-10-12 11:00:22 -07:00
2022-11-29 11:40:24 +01:00
2022-10-07 16:13:55 -07:00
2022-10-26 17:38:46 -07:00
2022-10-13 09:58:42 -07:00
2022-10-07 16:48:26 -07:00
2022-10-10 13:28:06 -07:00
2022-09-17 01:40:11 +09:00
2022-10-05 11:05:17 -06:00
2022-09-08 11:34:04 +01:00
2022-09-21 11:18:28 +09:00
2022-09-29 16:38:05 -07:00
2022-09-12 00:19:48 -06:00
2022-09-26 12:19:12 -07:00
2022-10-12 11:00:22 -07:00
2022-09-20 08:24:38 -06:00
2022-09-26 19:17:28 -06:00
2022-10-27 07:15:44 -06:00
2022-11-16 15:58:11 -07:00
2022-10-25 23:19:19 -07:00
2022-12-04 12:59:58 -08:00
2022-09-05 15:33:07 +02:00
2022-10-25 23:19:19 -07:00
2022-12-04 12:52:40 -08:00
2022-11-30 15:33:48 -08:00
2022-11-30 17:13:25 -08:00
2022-12-04 12:52:40 -08:00
2022-10-10 17:53:04 -07:00
2022-09-26 19:46:29 -07:00
2022-09-26 10:13:13 -07:00
2022-09-26 10:13:13 -07:00
2022-11-02 08:18:27 -07:00
2022-10-17 18:52:43 -07:00
2022-10-14 13:44:44 -07:00
2022-09-15 09:32:06 -07:00
2022-09-30 14:50:11 -07:00
2022-10-10 10:21:22 -07:00
2022-11-24 12:27:13 -08:00
2022-10-10 17:53:04 -07:00
2022-10-03 14:03:19 -07:00
2022-09-26 10:13:14 -07:00
2022-09-07 21:53:49 +02:00
2022-10-17 09:51:29 -04:00
2022-11-14 10:47:07 +00:00
2022-10-16 10:45:17 -07:00
2022-10-12 18:51:49 -07:00
2022-10-10 19:45:17 -07:00
2022-09-05 13:02:34 +02:00
2022-09-26 19:46:07 -07:00
2022-09-07 10:38:28 +02:00
2022-09-21 10:22:54 +02:00
2022-09-07 17:04:49 +02:00
2022-11-10 23:14:14 +01:00
2022-10-11 18:51:11 -07:00
2022-11-17 19:26:02 -08:00
2022-09-21 10:30:42 -06:00
2022-09-29 04:40:15 +09:00
2022-10-04 13:31:45 -07:00
2022-11-22 18:50:44 -08:00
2022-10-17 13:49:45 +02:00
2022-11-15 09:00:27 -08:00
2022-10-06 05:57:36 -07:00
2022-11-04 14:46:45 -07:00
2022-09-07 21:53:50 +02:00
2022-11-25 00:52:28 -05:00
2022-11-23 10:31:13 -08:00
2022-10-19 20:54:43 -07:00
2022-09-26 12:27:55 +02:00
2022-09-27 14:48:26 -04:00
2022-10-03 14:03:30 -07:00
2022-09-04 15:31:59 +03:00
2022-09-20 11:53:32 +01:00
2022-10-03 14:03:20 -07:00
2022-09-16 18:29:45 +08:00
2022-09-13 14:04:34 +02:00
2022-09-28 16:17:40 +01:00
2022-10-03 14:02:45 -07:00
2022-09-11 20:25:53 -07:00
2022-10-12 11:16:58 -07:00
2022-11-14 20:49:33 +01:00
2022-10-07 15:24:15 +02:00
2022-10-12 12:56:28 +02:00
2022-11-03 20:46:32 -07:00
2022-09-20 08:59:18 -07:00
2022-09-20 08:59:18 -07:00
2022-11-11 18:18:05 -08:00
2022-09-02 20:34:31 -07:00
2022-10-12 11:00:22 -07:00
2022-10-03 14:03:21 -07:00
2022-10-12 16:30:56 -06:00
2022-11-17 12:33:33 -07:00
2022-09-26 15:52:31 +02:00
2022-10-21 10:49:32 +02:00
2022-10-10 13:28:06 -07:00
2022-09-08 12:59:00 -06:00
2022-09-26 13:31:20 +02:00
2022-10-03 14:21:44 -07:00
2022-09-28 14:21:53 +01:00
2022-09-19 15:08:38 +02:00
2022-09-15 10:28:18 +02:00
2022-10-03 14:21:43 -07:00
2022-09-28 08:56:25 +02:00
2022-10-03 14:02:59 -07:00
2022-09-11 21:55:06 -07:00
2022-09-21 17:32:48 -07:00
2022-10-03 14:03:33 -07:00
2022-10-28 13:37:23 -07:00
2022-10-03 14:03:19 -07:00
2022-10-03 14:03:21 -07:00
2022-10-03 14:03:25 -07:00
2022-09-26 20:30:39 -07:00
2022-10-03 14:02:43 -07:00
2022-11-17 10:50:07 -05:00
2022-10-07 10:48:49 -07:00
2022-11-22 18:50:43 -08:00
2022-09-16 22:27:19 +02:00
2022-10-06 17:31:02 -07:00
2022-10-03 17:51:52 -07:00
2022-11-08 15:57:22 -08:00
2022-10-04 12:06:58 -06:00
2022-11-09 19:28:49 -08:00
2022-09-12 15:23:11 +03:00
2022-10-10 17:53:04 -07:00
2022-10-03 14:03:29 -07:00
2022-09-26 19:46:12 -07:00
2022-09-11 20:25:50 -07:00
2022-10-12 18:51:49 -07:00
2022-10-12 18:51:49 -07:00
2022-10-03 14:03:35 -07:00
2022-09-26 19:46:18 -07:00
2022-10-03 14:03:19 -07:00
2022-10-03 14:03:28 -07:00
2022-09-19 14:35:08 +02:00
2022-10-10 17:53:04 -07:00
2022-10-25 10:14:50 -07:00
2022-09-02 20:34:31 -07:00
2022-09-02 20:34:31 -07:00
2022-11-07 08:42:19 +00:00
2022-09-01 17:39:49 -04:00
2022-10-24 13:44:11 -07:00
2022-11-28 19:42:17 -08:00
2022-10-19 13:00:04 -07:00
2022-10-03 14:03:15 -07:00
2022-10-11 17:42:55 -06:00
2022-09-27 09:22:09 +02:00
2022-09-28 14:11:28 +01:00
2022-11-29 10:45:53 +01:00
2022-09-30 16:23:48 -05:00
2022-10-03 17:34:32 -07:00
2022-09-26 19:46:27 -07:00
2022-10-25 14:57:42 -07:00
2022-09-26 19:46:29 -07:00
2022-09-11 20:26:02 -07:00
2022-09-11 20:25:57 -07:00
2022-09-26 19:46:09 -07:00
2022-09-26 19:46:09 -07:00
2022-10-03 14:03:04 -07:00
2022-10-10 17:53:04 -07:00
2022-09-11 20:26:00 -07:00
2022-10-04 09:46:22 -07:00
2022-10-11 11:08:18 -07:00
2022-09-05 10:16:53 +01:00
2022-09-06 11:19:34 +02:00
2022-10-03 14:21:43 -07:00
2022-10-17 16:32:05 +02:00
2022-09-26 19:46:08 -07:00
2022-11-08 10:36:54 +01:00
2022-11-07 17:54:57 -08:00
2022-10-04 20:52:38 +02:00
2022-10-04 20:52:38 +02:00
2022-09-15 02:44:07 -07:00
2022-09-11 10:52:05 +02:00
2022-10-11 17:42:58 -06:00
2022-09-19 14:35:07 +02:00
2022-10-04 15:55:55 +02:00
2022-11-08 16:42:15 +00:00
2022-09-24 15:03:25 +02:00
2022-09-09 11:08:33 +02:00
2022-09-09 11:08:33 +02:00
2022-11-11 10:58:39 +00:00
2022-09-19 06:17:05 -07:00
2022-10-11 17:42:58 -06:00
2022-10-18 10:27:02 -07:00
2022-10-04 15:59:36 +02:00
2022-09-28 10:46:21 -06:00
2022-09-23 14:25:05 +02:00
2022-11-16 17:13:04 -05:00
2022-10-10 17:53:04 -07:00
2022-10-31 18:10:21 -07:00
2022-09-15 16:14:02 +02:00
2022-09-12 00:10:34 -06:00
2022-10-14 12:28:43 -07:00
2022-11-17 21:43:34 -08:00
2022-10-09 14:05:15 -07:00
2022-09-09 10:44:35 +02:00
2022-09-22 16:30:14 +02:00
2022-09-25 09:28:57 +02:00
2022-10-28 21:56:18 -07:00
2022-10-03 14:03:33 -07:00
2022-11-11 18:18:05 -08:00
2022-12-01 01:07:32 +01:00
2022-10-15 21:42:05 +02:00
2022-11-04 14:57:21 +01:00
2022-10-25 11:44:20 -07:00
2022-09-02 20:34:30 -07:00
2022-09-15 16:14:02 +02:00
2022-09-15 16:14:02 +02:00
2022-09-15 16:14:02 +02:00
2022-09-15 16:14:02 +02:00
2022-09-15 16:14:02 +02:00
2022-10-03 14:03:18 -07:00
2022-09-11 19:47:04 -05:00
2022-10-08 08:56:37 -07:00
2022-09-07 16:37:26 -07:00
2022-10-10 09:10:28 -07:00
2022-09-07 12:42:25 +01:00
2022-10-03 14:03:36 -07:00
2022-10-03 14:03:36 -07:00
2022-09-26 19:46:05 -07:00
2022-09-26 19:46:05 -07:00
2022-09-29 15:20:29 +02:00
2022-10-28 10:47:42 +01:00
2022-09-09 10:44:35 +02:00
2022-10-04 11:21:06 +02:00
2022-09-02 14:44:54 +02:00
2022-09-28 20:28:13 -04:00
2022-11-16 21:52:05 -05:00
2022-09-22 16:12:34 +02:00
2022-09-22 16:12:34 +02:00
2022-09-19 14:35:08 +02:00
2022-10-03 14:03:18 -07:00
2022-11-16 09:43:35 +00:00
2022-09-16 10:56:08 +01:00
2022-09-07 21:53:48 +02:00
2022-09-29 10:17:37 -04:00
2022-10-28 13:37:22 -07:00
2022-10-23 12:01:01 -07:00
2022-10-07 09:32:40 -04:00
2022-09-21 17:32:49 -07:00
2022-09-21 14:15:10 -06:00
2022-11-10 12:03:36 -07:00
2022-10-07 09:32:40 -04:00
2022-09-26 19:46:18 -07:00
2022-09-26 19:46:18 -07:00
2022-09-28 10:00:16 +02:00
2022-10-07 15:00:25 +02:00
2022-10-03 14:03:08 -07:00
2022-11-02 11:51:03 +00:00
c0c852dd18