Steven Rostedt (Google) 0441c44154 tracing: Fix trace_event_raw_event_synth() if else statement ...

commit 9971c3f944 upstream.

The test to check if the field is a stack is to be done if it is not a
string. But the code had:

    } if (event->fields[i]->is_stack) {

and not

   } else if (event->fields[i]->is_stack) {

which would cause it to always be tested. Worse yet, this also included an
"else" statement that was only to be called if the field was not a string
and a stack, but this code allows it to be called if it was a string (and
not a stack).

Also fixed some whitespace issues.

Link: https://lore.kernel.org/all/202301302110.mEtNwkBD-lkp@intel.com/
Link: https://lore.kernel.org/linux-trace-kernel/20230131095237.63e3ca8d@gandalf.local.home

Cc: Tom Zanussi <zanussi@kernel.org>
Fixes: 00cf3d672a ("tracing: Allow synthetic events to pass around stacktraces")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-08-03 10:24:17 +02:00

..

rv

rv/monitor: Add __init/__exit annotations to module init/exit funcs

2022-09-26 18:10:51 -04:00

blktrace.c

trace/blktrace: fix memory leak with using debugfs_lookup()

2023-03-10 09:33:46 +01:00

bpf_trace.c

bpf: Add extra path pointer check to d_path helper

2023-06-14 11:15:22 +02:00

bpf_trace.h

…

error_report-traces.c

…

fgraph.c

Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux

2022-06-03 14:05:34 -07:00

fprobe.c

fprobe: Ensure running fprobe_exit_handler() finished before calling rethook_free()

2023-07-23 13:49:46 +02:00

ftrace_internal.h

…

ftrace.c

ftrace: Fix possible warning on checking all pages used in ftrace_process_locs()

2023-07-23 13:49:44 +02:00

Kconfig

tracing: Fix complicated dependency of CONFIG_TRACER_MAX_TRACE

2023-01-07 11:11:48 +01:00

kprobe_event_gen_test.c

tracing: Fix wrong return in kprobe_event_gen_test.c

2023-04-06 12:10:41 +02:00

Makefile

rv: Add Runtime Verification (RV) interface

2022-07-30 14:01:28 -04:00

pid_list.c

tracing: Cleanup double word in comment

2022-04-26 17:58:50 -04:00

pid_list.h

…

power-traces.c

…

preemptirq_delay_test.c

…

rethook.c

fprobe: Ensure running fprobe_exit_handler() finished before calling rethook_free()

2023-07-23 13:49:46 +02:00

ring_buffer_benchmark.c

…

ring_buffer.c

ring-buffer: Fix wrong stat of cpu_buffer->read

2023-08-03 10:24:07 +02:00

rpm-traces.c

…

synth_event_gen_test.c

tracing: Fix memory leak in test_gen_synth_cmd() and test_empty_synth_event()

2022-11-17 17:51:38 -05:00

trace_benchmark.c

tracing: Add numeric delta time to the trace event benchmark

2022-09-26 13:01:09 -04:00

trace_benchmark.h

tracing: Add numeric delta time to the trace event benchmark

2022-09-26 13:01:09 -04:00

trace_boot.c

tracing: Initialize integer variable to prevent garbage return value

2022-05-26 21:13:00 -04:00

trace_branch.c

…

trace_clock.c

…

trace_dynevent.c

tracing: Free buffers when a used dynamic event is removed

2022-11-23 19:07:12 -05:00

trace_dynevent.h

…

trace_entries.h

…

trace_eprobe.c

kernel/trace: Fix cleanup logic of enable_trace_eprobe

2023-07-23 13:49:24 +02:00

trace_event_perf.c

tracing/perf: Fix double put of trace event when init fails

2022-08-21 15:56:07 -04:00

trace_events_filter_test.h

…

trace_events_filter.c

tracing/filter: Call filter predicate functions directly via a switch statement

2022-09-26 13:01:10 -04:00

trace_events_hist.c

tracing: Allow synthetic events to pass around stacktraces

2023-08-03 10:23:55 +02:00

trace_events_inject.c

…

trace_events_synth.c

tracing: Fix trace_event_raw_event_synth() if else statement

2023-08-03 10:24:17 +02:00

trace_events_trigger.c

tracing: Fix to check event_mutex is held while accessing trigger list

2022-09-06 22:26:00 -04:00

trace_events_user.c

tracing/user_events: Fix struct arg size match check

2023-07-23 13:49:47 +02:00

trace_events.c

tracing: Fix warning in trace_buffered_event_disable()

2023-08-03 10:24:07 +02:00

trace_export.c

tracing: Fix TASK_COMM_LEN in trace event format file

2023-02-14 19:11:54 +01:00

trace_functions_graph.c

…

trace_functions.c

…

trace_hwlat.c

tracing/hwlat: Replace sched_setaffinity with set_cpus_allowed_ptr

2023-03-30 12:48:59 +02:00

trace_irqsoff.c

…

trace_kdb.c

…

trace_kprobe_selftest.c

…

trace_kprobe_selftest.h

…

trace_kprobe.c

tracing: Move duplicate code of trace_kprobe/eprobe.c into header

2022-10-12 13:50:00 -04:00

trace_mmiotrace.c

…

trace_nop.c

…

trace_osnoise.c

tracing/timerlat: Always wakeup the timerlat thread

2023-06-09 10:34:24 +02:00

trace_output.c

tracing: Make sure trace_printk() can output as soon as it can be used

2023-02-01 08:34:37 +01:00

trace_output.h

…

trace_preemptirq.c

tracing: hold caller_addr to hardirq_{enable,disable}_ip

2022-09-06 22:26:00 -04:00

trace_printk.c

…

trace_probe_kernel.h

tracing/probes: Fix to record 0-length data_loc in fetch_store_string*() if fails

2023-08-03 10:23:55 +02:00

trace_probe_tmpl.h

tracing/probes: Fix to record 0-length data_loc in fetch_store_string*() if fails

2023-08-03 10:23:55 +02:00

trace_probe.c

Revert "tracing: Add "(fault)" name injection to kernel probes"

2023-08-03 10:23:55 +02:00

trace_probe.h

tracing/probes: Add symstr type for dynamic events

2023-08-03 10:23:54 +02:00

trace_recursion_record.c

tracing: Use trace_create_file() to simplify creation of tracefs entries

2022-05-26 21:12:52 -04:00

trace_sched_switch.c

sched/tracing: Append prev_state to tp args instead

2022-05-12 00:37:11 +02:00

trace_sched_wakeup.c

sched/tracing: Append prev_state to tp args instead

2022-05-12 00:37:11 +02:00

trace_selftest_dynamic.c

…

trace_selftest.c

tracing: Reset the function filter after completing trampoline/graph selftest

2022-05-25 16:57:37 -04:00

trace_seq.c

…

trace_stack.c

…

trace_stat.c

…

trace_stat.h

…

trace_synth.h

tracing: Allow synthetic events to pass around stacktraces

2023-08-03 10:23:55 +02:00

trace_syscalls.c

tracing: Remove unused __bad_type_size() method

2022-11-17 20:21:06 -05:00

trace_uprobe.c

tracing/probes: Fix to record 0-length data_loc in fetch_store_string*() if fails

2023-08-03 10:23:55 +02:00

trace.c

tracing/probes: Add symstr type for dynamic events

2023-08-03 10:23:54 +02:00

trace.h

Revert "tracing: Add "(fault)" name injection to kernel probes"

2023-08-03 10:23:55 +02:00

tracing_map.c

tracing: Remove unused variable 'dups'

2022-10-03 12:20:31 -04:00

tracing_map.h

…