Linus Torvalds f3bbac3247 ext4: deal with legacy signed xattr name hash values ...

We potentially have old hashes of the xattr names generated on systems
with signed 'char' types.  Now that everybody uses '-funsigned-char',
those hashes will no longer match.

This only happens if you use xattrs names that have the high bit set,
which probably doesn't happen in practice, but the xfstest generic/454
shows it.

Instead of adding a new "signed xattr hash filesystem" bit and having to
deal with all the possible combinations, just calculate the hash both
ways if the first one fails, and always generate new hashes with the
proper unsigned char version.

Reported-by: kernel test robot <oliver.sang@intel.com>
Link: https://lore.kernel.org/oe-lkp/202212291509.704a11c9-oliver.sang@intel.com
Link: https://lore.kernel.org/all/CAHk-=whUNjwqZXa-MH9KMmc_CpQpoFKFjAB9ZKHuu=TbsouT4A@mail.gmail.com/
Exposed-by: 3bc753c06d ("kbuild: treat char as always unsigned")
Cc: Eric Biggers <ebiggers@kernel.org>
Cc: Andreas Dilger <adilger@dilger.ca>
Cc: Theodore Ts'o <tytso@mit.edu>,
Cc: Jason Donenfeld <Jason@zx2c4.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2023-01-21 10:14:47 -08:00

..

.kunitconfig

…

acl.c

fs: pass dentry to set acl method

2022-10-19 12:55:42 +02:00

acl.h

fs: pass dentry to set acl method

2022-10-19 12:55:42 +02:00

balloc.c

…

bitmap.c

…

block_validity.c

…

crypto.c

…

dir.c

…

ext4_extents.h

…

ext4_jbd2.c

ext4: split ext4_journal_start trace for debug

2022-12-01 10:46:54 -05:00

ext4_jbd2.h

ext4: split ext4_journal_start trace for debug

2022-12-01 10:46:54 -05:00

ext4.h

ext4: switch to using ext4_do_writepages() for ordered data writeout

2022-12-08 21:49:25 -05:00

extents_status.c

ext4: fix reserved cluster accounting in __es_remove_extent()

2022-12-09 00:58:04 -05:00

extents_status.h

…

extents.c

ext4: fix delayed allocation bug in ext4_clu_mapped for bigalloc + inline

2022-12-08 21:49:25 -05:00

fast_commit.c

jbd2: switch jbd2_submit_inode_data() to use fs-provided hook for data writeout

2022-12-08 21:49:25 -05:00

fast_commit.h

ext4: add missing validation of fast-commit record lengths

2022-12-08 21:49:24 -05:00

file.c

fs: rename current get acl method

2022-10-20 10:13:27 +02:00

fsmap.c

…

fsmap.h

…

fsync.c

…

hash.c

…

ialloc.c

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2022-12-12 19:56:37 -08:00

indirect.c

ext4: fix error code return to user-space in ext4_get_branch()

2022-12-08 21:49:24 -05:00

inline.c

fs/ext4: replace ternary operator with min()/max() and min_t()

2022-11-29 16:10:49 -05:00

inode-test.c

…

inode.c

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2022-12-12 19:56:37 -08:00

ioctl.c

ext4: initialize quota before expanding inode in setproject ioctl

2022-12-08 22:03:15 -05:00

Kconfig

…

Makefile

…

mballoc.c

ext4: make ext4_mb_initialize_context return void

2022-12-08 21:49:25 -05:00

mballoc.h

ext4: use buckets for cr 1 block scan instead of rbtree

2022-09-21 22:12:03 -04:00

migrate.c

ext4: fix warning in 'ext4_da_release_space'

2022-11-06 01:07:59 -04:00

mmp.c

treewide: use get_random_u32_{above,below}() instead of manual loop

2022-11-18 02:15:22 +01:00

move_extent.c

ext4: convert move_extent_per_page() to use folios

2022-11-30 15:59:02 -08:00

namei.c

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2022-12-12 19:56:37 -08:00

orphan.c

ext4: remove trailing newline from ext4_msg() message

2022-12-08 21:49:23 -05:00

page-io.c

ext4: drop pointless IO submission from ext4_bio_write_page()

2022-12-08 21:49:25 -05:00

readpage.c

Merge tag 'fsverity-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt

2022-12-12 20:06:35 -08:00

resize.c

ext4: fix corruption when online resizing a 1K bigalloc fs

2022-12-08 21:49:24 -05:00

super.c

treewide: Convert del_timer*() to timer_shutdown*()

2022-12-25 13:38:09 -08:00

symlink.c

…

sysfs.c

…

truncate.h

…

verity.c

fs: ext4: initialize fsdata in pagecache_write()

2022-12-08 21:49:25 -05:00

xattr_hurd.c

…

xattr_security.c

…

xattr_trusted.c

…

xattr_user.c

…

xattr.c

ext4: deal with legacy signed xattr name hash values

2023-01-21 10:14:47 -08:00

xattr.h

…