Matthew Wilcox (Oracle) 7e934cf5ac
xarray: Fix early termination of xas_for_each_marked ...
xas_for_each_marked() is using entry == NULL as a termination condition
of the iteration. When xas_for_each_marked() is used protected only by
RCU, this can however race with xas_store(xas, NULL) in the following
way:
TASK1 TASK2
page_cache_delete() find_get_pages_range_tag()
xas_for_each_marked()
xas_find_marked()
off = xas_find_chunk()
xas_store(&xas, NULL)
xas_init_marks(&xas);
...
rcu_assign_pointer(*slot, NULL);
entry = xa_entry(off);
And thus xas_for_each_marked() terminates prematurely possibly leading
to missed entries in the iteration (translating to missing writeback of
some pages or a similar problem).
If we find a NULL entry that has been marked, skip it (unless we're trying
to allocate an entry).
Reported-by: Jan Kara <jack@suse.cz >
CC: stable@vger.kernel.org
Fixes: ef8e5717dbwilly@infradead.org >
2020-03-12 17:42:08 -04:00
2020-01-02 15:34:27 +01:00
2019-11-27 22:28:37 +01:00
2019-11-27 08:15:00 -08:00
2019-11-14 16:03:35 +05:30
2019-12-05 11:43:31 -08:00
2019-11-22 19:56:20 +00:00
2019-12-03 09:29:50 -08:00
2019-11-12 11:43:29 -05:00
2019-12-11 13:22:54 +01:00
2019-11-27 10:17:28 -08:00
2019-11-18 10:05:38 +01:00
2020-01-09 20:08:15 +01:00
2020-01-24 20:54:29 +01:00
2019-12-10 07:18:21 -08:00
2019-11-13 11:33:53 +01:00
2019-12-12 17:59:43 +01:00
2019-12-05 11:43:31 -08:00
2019-11-09 16:46:56 +05:30
2019-12-27 23:03:43 +00:00
2019-12-07 16:56:00 -08:00
2019-11-16 14:45:31 +01:00
2019-12-04 13:32:45 +10:00
2019-12-25 20:47:19 -07:00
2019-11-14 12:31:00 +08:00
2019-11-23 09:56:02 -08:00
2019-12-28 09:44:56 -07:00
2019-12-04 19:44:14 -08:00
2019-12-04 19:44:12 -08:00
2019-11-21 09:06:47 -07:00
2019-12-12 09:26:55 -07:00
2019-11-13 12:50:38 -07:00
2020-01-15 21:43:09 -07:00
2019-11-15 23:44:48 +01:00
2019-11-24 17:04:11 -08:00
2019-12-17 08:58:02 -08:00
2019-12-16 10:59:29 -08:00
2019-11-14 13:15:11 -05:00
2019-11-15 23:45:24 +01:00
2019-12-04 19:44:12 -08:00
2020-01-04 20:23:39 -07:00
2019-11-12 08:18:04 -08:00
2019-11-12 08:18:04 -08:00
2019-11-11 13:59:35 +01:00
2019-12-01 14:00:59 -08:00
2019-11-26 10:26:26 +01:00
2019-12-12 17:59:43 +01:00
2019-11-26 09:43:34 -08:00
2019-11-29 11:48:39 +01:00
2019-11-17 09:02:49 +08:00
2019-11-15 13:49:04 -05:00
2019-11-21 14:28:32 +01:00
2019-12-09 12:19:16 +09:00
2019-11-25 11:53:26 -08:00
2019-12-12 14:49:57 +01:00
2019-11-21 18:14:35 +01:00
2019-11-28 11:16:43 -08:00
2019-11-20 20:31:38 +01:00
2019-12-11 16:03:20 +05:30
2019-11-11 16:07:13 +01:00
2019-12-03 11:20:37 +01:00
2019-11-10 12:40:14 +01:00
2019-12-08 12:42:19 +01:00
2019-12-05 12:27:16 -08:00
2019-11-12 08:18:04 -08:00
2019-12-02 14:46:22 -08:00
2019-12-09 10:36:44 -08:00
2019-12-02 14:46:22 -08:00
2019-12-11 12:22:38 -08:00
2019-11-20 09:40:10 +01:00
2019-11-27 11:06:20 -08:00
2019-12-04 19:44:13 -08:00
2020-01-26 09:59:08 -07:00
2019-12-01 12:59:06 -08:00
2019-11-23 19:56:45 -04:00
2019-12-01 12:59:08 -08:00
2019-11-21 20:10:44 -05:00
2019-12-11 08:39:07 +01:00
2019-11-08 08:46:49 -08:00
2020-01-08 12:52:33 -08:00
2019-11-12 12:25:49 +11:00
2019-12-12 18:58:24 +01:00
2019-11-11 16:10:54 +01:00
2019-12-03 12:20:25 -08:00
2019-11-11 08:40:18 +00:00
2019-11-12 17:11:25 +01:00
2019-11-07 15:44:14 +01:00
2019-11-11 09:02:56 +01:00
2019-11-16 10:20:02 +00:00
2019-11-16 10:18:52 +00:00
2019-12-22 10:41:48 -08:00
2019-12-17 20:59:59 -08:00
2019-12-04 19:44:14 -08:00
2019-11-21 07:33:24 +01:00
2019-12-30 12:01:56 -08:00
2019-11-12 08:18:04 -08:00
2019-12-09 10:36:44 -08:00
2019-12-25 17:08:33 -07:00
2019-11-26 13:35:25 -07:00
2019-11-19 09:52:12 -08:00
2019-11-14 11:36:53 +08:00
2019-12-01 12:59:08 -08:00
2019-12-01 12:59:07 -08:00
2020-01-04 13:55:08 -08:00
2019-11-15 18:34:00 -08:00
2019-11-07 15:45:00 +01:00
2019-12-06 10:28:09 -08:00
2020-01-13 18:19:02 -08:00
2019-11-23 19:56:44 -04:00
2020-01-13 18:19:02 -08:00
2019-12-20 21:47:04 -08:00
2019-11-14 11:36:53 +08:00
2019-12-01 12:59:05 -08:00
2019-11-07 15:11:48 +01:00
2020-01-15 01:36:06 -05:00
2019-11-14 19:06:47 -08:00
2020-01-23 11:14:21 +01:00
2019-12-04 19:44:12 -08:00
2019-11-27 02:48:27 +09:00
2019-11-22 02:21:08 +09:00
2019-11-27 10:53:50 -08:00
2019-12-26 15:17:26 -08:00
2019-11-21 07:49:29 -06:00
2019-12-01 12:59:04 -08:00
2019-11-13 19:09:47 +08:00
2019-11-20 16:30:10 +00:00
2019-12-03 13:58:22 -08:00
2019-11-25 14:28:04 -08:00
2019-11-16 20:02:47 -08:00
2019-11-26 15:04:47 -08:00
2019-12-09 10:36:44 -08:00
2019-12-20 21:48:06 -08:00
2019-11-23 16:13:39 -08:00
2019-11-15 23:49:22 +01:00
2019-11-15 23:49:22 +01:00
2019-12-07 13:21:01 -08:00
2019-11-13 11:41:50 +01:00
2019-11-11 10:27:15 +05:30
2019-11-29 12:04:50 +01:00
2019-11-13 11:41:50 +01:00
2019-12-30 20:19:27 -08:00
2019-12-06 10:47:28 +01:00
2019-12-04 19:44:11 -08:00
2019-12-06 10:28:09 -08:00
2019-11-11 11:06:27 +01:00
2019-12-04 19:44:13 -08:00
2019-12-13 21:40:49 -08:00
2019-11-26 16:02:40 -08:00
2019-11-25 09:15:32 +01:00
2019-12-05 11:43:31 -08:00
2019-12-05 11:43:31 -08:00
2019-11-14 13:07:48 +08:00
2019-11-13 12:50:40 -07:00
2019-12-25 10:41:20 +01:00
2019-11-30 14:35:43 -08:00
2019-11-14 13:15:12 -05:00
2019-11-20 22:29:40 -08:00
2019-12-04 17:11:25 -08:00
2020-01-15 23:26:13 +01:00
2019-12-01 06:29:17 -08:00
2019-12-03 07:04:30 -07:00
2019-11-14 13:15:11 -05:00
2019-11-13 12:15:34 -08:00
2019-12-01 06:29:18 -08:00
2019-12-01 12:59:07 -08:00
2020-01-06 13:33:14 -08:00
2020-01-02 16:15:33 -08:00
2019-12-04 19:44:11 -08:00
2019-11-13 00:33:21 +11:00
2019-12-04 19:44:14 -08:00
2019-11-26 15:42:43 -08:00
2019-11-15 14:38:29 +01:00
2019-12-06 21:05:14 -08:00
2020-01-15 13:39:59 -08:00
2019-12-17 11:46:43 +02:00
2019-11-22 19:41:08 -05:00
2019-11-14 13:15:12 -05:00
2019-11-22 19:41:08 -05:00
2019-12-01 14:00:59 -08:00
2019-11-07 20:03:08 -08:00
2019-11-14 18:12:18 -08:00
2019-12-01 12:59:05 -08:00
2019-12-04 19:44:11 -08:00
2019-11-14 18:12:18 -08:00
2019-11-14 12:20:02 +08:00
2020-03-12 17:42:08 -04:00
7e934cf5ac