Johan Hovold 98bd0b4ad5 PCI: vmd: Fix potential deadlock when enabling ASPM ...

commit 49de0dc879 upstream.

The vmd_pm_enable_quirk() helper is called from pci_walk_bus() during
probe to enable ASPM for controllers with VMD_FEAT_BIOS_PM_QUIRK set.

Since pci_walk_bus() already holds a pci_bus_sem read lock, use
pci_enable_link_state_locked() to enable link states in order to avoid a
potential deadlock (e.g. in case someone takes a write lock before
reacquiring the read lock).

Fixes: f492edb40b ("PCI: vmd: Add quirk to configure PCIe ASPM and LTR")
Link: https://lore.kernel.org/r/20231128081512.19387-3-johan+linaro@kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
[bhelgaas: add "potential" in subject since the deadlock has only been
reported by lockdep, include helper name in commit log]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <stable@vger.kernel.org>	# 6.3
Cc: Michael Bottini <michael.a.bottini@linux.intel.com>
Cc: David E. Box <david.e.box@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2023-12-20 17:01:54 +01:00

..

controller

PCI: vmd: Fix potential deadlock when enabling ASPM

2023-12-20 17:01:54 +01:00

endpoint

PCI: endpoint: Fix double free in __pci_epc_create()

2023-11-20 11:59:23 +01:00

hotplug

Revert "PCI: acpiphp: Reassign resources on bridge if necessary"

2023-12-20 17:01:53 +01:00

msi

PCI: Fix typos in docs and comments

2023-08-25 08:15:38 -05:00

pcie

PCI/ASPM: Add pci_enable_link_state_locked()

2023-12-20 17:01:53 +01:00

switch

PCI: switchtec: Add support for PCIe Gen5 devices

2023-08-09 14:16:44 -05:00

access.c

PCI: Simplify pcie_capability_clear_and_set_word() control flow

2023-08-25 08:16:10 -05:00

ats.c

…

bus.c

Merge tag 'devicetree-for-6.6' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux

2023-08-30 16:59:03 -07:00

doe.c

PCI/DOE: Fix destroy_work_on_stack() race

2023-07-27 15:20:47 -05:00

ecam.c

…

host-bridge.c

…

iov.c

PCI/IOV: Use pci_dev_id() to simplify the code

2023-08-07 16:15:39 -05:00

irq.c

…

Kconfig

PCI: Fix CONFIG_PCI_DYNAMIC_OF_NODES kconfig dependencies

2023-09-05 12:42:28 -05:00

Makefile

PCI: Create device tree node for bridge

2023-08-22 14:56:09 -05:00

mmap.c

…

of_property.c

PCI: of_property: Handle interrupt parsing failures

2023-09-29 17:33:46 -05:00

of.c

PCI: of: Destroy changeset when adding PCI device node fails

2023-09-29 17:33:51 -05:00

p2pdma.c

PCI: Fix typos in docs and comments

2023-08-25 08:15:38 -05:00

pci-acpi.c

PCI/sysfs: Protect driver's D3cold preference from user space

2023-11-28 17:19:57 +00:00

pci-bridge-emul.c

…

pci-bridge-emul.h

…

pci-driver.c

PCI/PM: Mark devices disconnected if upstream PCIe link is down on resume

2023-09-29 17:42:00 -05:00

pci-label.c

…

pci-mid.c

…

pci-pf-stub.c

…

pci-stub.c

…

pci-sysfs.c

PCI/sysfs: Protect driver's D3cold preference from user space

2023-11-28 17:19:57 +00:00

pci.c

PCI: Use FIELD_GET() in Sapphire RX 5600 XT Pulse quirk

2023-11-28 17:19:44 +00:00

pci.h

Merge tag 'pci-v6.6-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/pci/pci

2023-08-30 20:23:07 -07:00

probe.c

PCI: Do error check on own line to split long "if" conditions

2023-11-28 17:19:43 +00:00

proc.c

…

quirks.c

PCI: Lengthen reset delay for VideoPropulsion Torrent QN16e card

2023-11-28 17:20:02 +00:00

remove.c

PCI: Create device tree node for bridge

2023-08-22 14:56:09 -05:00

rom.c

…

search.c

…

setup-bus.c

PCI: Fix typos in docs and comments

2023-08-25 08:15:38 -05:00

setup-irq.c

…

setup-res.c

PCI: Fix printk field formatting

2023-08-25 08:15:08 -05:00

slot.c

…

syscall.c

PCI: Use consistent put_user() pointer types

2023-08-25 08:15:13 -05:00

vc.c

…

vgaarb.c

PCI/VGA: Fix typos

2023-08-24 13:27:47 -05:00

vpd.c

PCI/VPD: Add runtime power management to sysfs interface

2023-08-11 14:19:16 -05:00

xen-pcifront.c

x86: always initialize xen-swiotlb when xen-pcifront is enabling

2023-07-31 17:54:27 +02:00