Kees Cook 567cfc59e4 x86/uaccess: Fix missed zeroing of ia32 u64 get_user() range checking ...

[ Upstream commit 8c860ed825 ]

When reworking the range checking for get_user(), the get_user_8() case
on 32-bit wasn't zeroing the high register. (The jump to bad_get_user_8
was accidentally dropped.) Restore the correct error handling
destination (and rename the jump to using the expected ".L" prefix).

While here, switch to using a named argument ("size") for the call
template ("%c4" to "%c[size]") as already used in the other call
templates in this file.

Found after moving the usercopy selftests to KUnit:

      # usercopy_test_invalid: EXPECTATION FAILED at
      lib/usercopy_kunit.c:278
      Expected val_u64 == 0, but
          val_u64 == -60129542144 (0xfffffff200000000)

Closes: https://lore.kernel.org/all/CABVgOSn=tb=Lj9SxHuT4_9MTjjKVxsq-ikdXC4kGHO4CfKVmGQ@mail.gmail.com
Fixes: b19b74bc99 ("x86/mm: Rework address range check in get_user() and put_user()")
Reported-by: David Gow <davidgow@google.com>
Signed-off-by: Kees Cook <kees@kernel.org>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Tested-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/all/20240610210213.work.143-kees%40kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>

2024-06-21 14:38:34 +02:00

..

.gitignore

.gitignore: add SPDX License Identifier

2020-03-25 11:50:48 +01:00

atomic64_32.c

…

atomic64_386_32.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

atomic64_cx8_32.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

cache-smp.c

smp: Remove smp_call_function() and on_each_cpu() return values

2019-06-23 14:26:26 +02:00

checksum_32.S

x86/checksum_32: Remove .fixup usage

2021-12-11 09:09:49 +01:00

clear_page_64.S

x86: improve on the non-rep 'clear_user' function

2023-04-18 17:05:28 -07:00

cmdline.c

x86/lib: Fix compiler and kernel-doc warnings

2023-01-03 18:46:21 +01:00

cmpxchg8b_emu.S

percpu: Wire up cmpxchg128

2023-06-05 09:36:37 +02:00

cmpxchg16b_emu.S

percpu: Wire up cmpxchg128

2023-06-05 09:36:37 +02:00

copy_mc_64.S

x86/copy_mc_64: Remove .fixup usage

2021-12-11 09:09:46 +01:00

copy_mc.c

iov_iter, x86: Be consistent about the __user tag on copy_mc_to_user()

2023-11-20 11:58:52 +01:00

copy_page_64.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

copy_user_64.S

x86: bring back rep movsq for user access on CPUs without ERMS

2023-08-30 09:45:12 -07:00

copy_user_uncached_64.S

x86: rewrite '__copy_user_nocache' function

2023-04-20 18:53:49 -07:00

cpu.c

x86/lib/cpu: Address missing prototypes warning

2019-08-08 08:25:53 +02:00

csum-copy_64.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

csum-partial_64.c

x86/csum: clean up `csum_partial' further

2024-01-20 11:51:47 +01:00

csum-wrappers_64.c

net: unexport csum_and_copy_{from,to}_user

2022-04-29 14:37:59 -07:00

delay.c

x86/delay: Fix the wrong asm constraint in delay_loop()

2022-04-05 21:21:57 +02:00

error-inject.c

x86/error_inject: Align function properly

2022-10-17 16:40:59 +02:00

getuser.S

x86/uaccess: Fix missed zeroing of ia32 u64 get_user() range checking

2024-06-21 14:38:34 +02:00

hweight.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

inat.c

x86/insn: Add a __ignore_sync_check__ marker

2021-03-15 11:00:57 +01:00

insn-eval.c

x86/insn: Avoid namespace clash by separating instruction decoder MMIO type from MMIO trace type

2023-01-03 18:46:06 +01:00

insn.c

x86/insn: Use get_unaligned() instead of memcpy()

2021-10-06 11:56:37 +02:00

iomap_copy_64.S

x86/asm: Fix an assembler warning with current binutils

2023-01-03 17:55:11 +01:00

iomem.c

x86: kmsan: handle open-coded assembly in lib/iomem.c

2022-10-03 14:03:24 -07:00

kaslr.c

x86/kaslr: Fix build warning in KASLR code in boot stub

2022-04-11 09:41:12 +02:00

Makefile

x86/boot: Move mem_encrypt= parsing to the decompressor

2024-04-10 16:36:07 +02:00

memcpy_32.c

x86/mem: Move memmove to out of line assembler

2022-11-01 15:44:07 -07:00

memcpy_64.S

x86/asm: Fix build of UML with KASAN

2023-09-18 19:30:08 +02:00

memmove_32.S

x86/mem: Move memmove to out of line assembler

2022-11-01 15:44:07 -07:00

memmove_64.S

x86/asm: Fix build of UML with KASAN

2023-09-18 19:30:08 +02:00

memset_64.S

x86/asm: Fix build of UML with KASAN

2023-09-18 19:30:08 +02:00

misc.c

x86/lib: Fix overflow when counting digits

2024-01-25 15:35:12 -08:00

msr-reg-export.c

…

msr-reg.S

x86: Prepare asm files for straight-line-speculation

2021-12-08 12:25:37 +01:00

msr-smp.c

x86/msr: Fix wr/rdmsr_safe_regs_on_cpu() prototypes

2021-03-22 21:37:03 +01:00

msr.c

x86/lib/msr: Clean up kernel-doc notation

2023-06-06 15:19:50 +02:00

pc-conf-reg.c

x86: Add support for 0x22/0x23 port I/O configuration space

2021-08-10 23:31:43 +02:00

putuser.S

x86/lib: Revert to _ASM_EXTABLE_UA() for {get,put}_user() fixups

2024-02-16 19:10:54 +01:00

retpoline.S

x86/retpoline: Add NOENDBR annotation to the SRSO dummy return thunk

2024-04-10 16:36:01 +02:00

string_32.c

lib/string: Move helper functions out of string.c

2021-09-25 08:20:49 -07:00

strstr_32.c

…

usercopy_32.c

x86/usercopy: Remove .fixup usage

2021-12-11 09:09:50 +01:00

usercopy_64.c

x86/usercopy: Include arch_wb_cache_pmem() declaration

2023-05-18 11:56:18 -07:00

usercopy.c

x86/uaccess: instrument copy_from_user_nmi()

2022-11-08 15:57:24 -08:00

x86-opcode-map.txt

x86/insn: Add VEX versions of VPDPBUSD, VPDPBUSDS, VPDPWSSD and VPDPWSSDS

2024-06-12 11:12:09 +02:00