drholy/linux-bredos
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

devlink: don't require setting features before registration

Browse Source 
Requiring devlink_set_features() to be run before devlink is
registered is overzealous. devlink_set_features() itself is
a leftover from old workarounds which were trying to prevent
initiating reload before probe was complete.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jakub Kicinski
2023-01-05 22:33:59 -08:00
committed by David S. Miller
parent 9053637e0d
commit 6ef8f7da92
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/devlink/core.c
View File

@@ -125,8 +125,6 @@ next:
*/ */
void devlink_set_features(struct devlink *devlink, u64 features) void devlink_set_features(struct devlink *devlink, u64 features)
{ {
ASSERT_DEVLINK_NOT_REGISTERED(devlink);
WARN_ON(features & DEVLINK_F_RELOAD && WARN_ON(features & DEVLINK_F_RELOAD &&
!devlink_reload_supported(devlink->ops)); !devlink_reload_supported(devlink->ops));
devlink->features = features; devlink->features = features;