From 21ac9ae51ad69568ff7e87513c0a49a4a7f30dd8 Mon Sep 17 00:00:00 2001 From: pluja Date: Fri, 29 Sep 2023 19:23:15 +0200 Subject: [PATCH] remove unused build args, use env variables (#14) --- docker-compose.dev.yml | 6 +- docker-compose.yml | 6 +- frontend/Dockerfile | 15 ----- frontend/package.json | 1 + .../src/lib/components/EditorSegment.svelte | 10 ++-- .../components/ModalTranslationForm.svelte | 15 +++-- frontend/src/lib/utils.js | 7 ++- frontend/src/routes/+layout.js | 3 +- frontend/src/routes/editor/[id]/+page.js | 3 +- frontend/src/routes/editor/[id]/+page.svelte | 13 +++-- frontend/svelte.config.js | 3 + frontend/yarn.lock | 55 ++++++++++--------- 12 files changed, 63 insertions(+), 74 deletions(-) diff --git a/docker-compose.dev.yml b/docker-compose.dev.yml index bd10b55..75767a3 100644 --- a/docker-compose.dev.yml +++ b/docker-compose.dev.yml @@ -21,8 +21,4 @@ services: whishper-frontend: build: - context: ./frontend - args: - PUBLIC_API_HOST: ${WHISHPER_HOST} - PUBLIC_TRANSLATION_API_HOST: "" - PUBLIC_INTERNAL_API_HOST: "http://nginx:80" \ No newline at end of file + context: ./frontend \ No newline at end of file diff --git a/docker-compose.yml b/docker-compose.yml index 0b9e8e9..96800ac 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -90,9 +90,9 @@ services: - .env restart: unless-stopped environment: - PUBLIC_INTERNAL_API_HOST: "http://nginx:80" - PUBLIC_TRANSLATION_API_HOST: "" - PUBLIC_API_HOST: ${WHISHPER_HOST:-} + INTERNAL_API_HOST: "http://nginx:80" + VITE_TRANSLATION_API_HOST: "" + VITE_API_HOST: ${WHISHPER_HOST:-} depends_on: transcription-api: condition: service_healthy diff --git a/frontend/Dockerfile b/frontend/Dockerfile index c42b0a8..954ec5a 100644 --- a/frontend/Dockerfile +++ b/frontend/Dockerfile @@ -1,13 +1,5 @@ FROM node:alpine as build -ARG PUBLIC_API_HOST -ARG PUBLIC_TRANSLATION_API_HOST -ARG PUBLIC_INTERNAL_API_HOST - -ENV PUBLIC_API_HOST=$PUBLIC_API_HOST -ENV PUBLIC_TRANSLATION_API_HOST=$PUBLIC_TRANSLATION_API_HOST -ENV PUBLIC_INTERNAL_API_HOST=$PUBLIC_INTERNAL_API_HOST - WORKDIR /app COPY . . RUN yarn @@ -17,13 +9,6 @@ RUN ls -al FROM node:alpine as production -ARG PUBLIC_API_HOST -ARG PUBLIC_TRANSLATION_API_HOST -ARG PUBLIC_INTERNAL_API_HOST - -ENV PUBLIC_API_HOST=$PUBLIC_API_HOST -ENV PUBLIC_TRANSLATION_API_HOST=$PUBLIC_TRANSLATION_API_HOST -ENV PUBLIC_INTERNAL_API_HOST=$PUBLIC_INTERNAL_API_HOST ENV BODY_SIZE_LIMIT=0 WORKDIR /app diff --git a/frontend/package.json b/frontend/package.json index 1003ed4..c76c3b7 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -27,6 +27,7 @@ }, "type": "module", "dependencies": { + "dotenv": "^16.3.1", "svelte-french-toast": "^1.2.0" } } diff --git a/frontend/src/lib/components/EditorSegment.svelte b/frontend/src/lib/components/EditorSegment.svelte index 0a3808e..bb8961c 100644 --- a/frontend/src/lib/components/EditorSegment.svelte +++ b/frontend/src/lib/components/EditorSegment.svelte @@ -216,21 +216,21 @@
16} contenteditable="true" />
- + 16}> - + CPS: {getCps(segment)} - + Duration: {Math.round((segment.end - segment.start) * 100) / 100}s @@ -238,7 +238,7 @@
diff --git a/frontend/src/lib/components/ModalTranslationForm.svelte b/frontend/src/lib/components/ModalTranslationForm.svelte index 304a406..e997d6b 100644 --- a/frontend/src/lib/components/ModalTranslationForm.svelte +++ b/frontend/src/lib/components/ModalTranslationForm.svelte @@ -1,8 +1,7 @@ -