Files

Tianyi Cui 605587e79c docs(rfc): classify RFCs by kind via path-encoded subdirectories

Add a second axis to every RFC — its class (feature, bug-fix,
simplification, architecture, process, testing) — encoded in the path
as docs/rfc/{lifecycle}/{class}/file.md. The folder is the label, so
the closed set is enforced by structure rather than a parsed field.

Two new doc-sync gates back it:
- verify-rfc-classification: every RFC sits in a valid class folder and
  the README index lists it under the matching lifecycle→class heading.
- verify-doc-refs: every docs/*.md path cited in a packages|examples TS
  comment resolves — closes a drift class verify-md-links can't see, and
  catches the four comment refs this reorg moved.

The README gains a Classification section explaining the taxonomy and
per-class index sub-sections. A self-referential process RFC records why
the scheme is path-encoded and gated.

2026-06-20 22:29:45 +08:00

2.6 KiB

Raw Blame History

RFC: Drop ACP terminal `_meta` rendering

Status: rejected — Zed is the current target client, and the terminal _meta convention is intentional Zed UX with a plain ACP fallback for other clients.

Problem

The ACP bridge implements a Zed-specific terminal-card convention through _meta.terminal_info, _meta.terminal_output, and _meta.terminal_exit. The implemented rich ACP bash rendering RFC deliberately avoided ACP's client-side terminal/create because bash execution belongs in the harness, but still adopted the reference agents' display-only _meta convention. That gives a nicer Zed card at the cost of bridge state, capability negotiation, terminal ids, special update mapping, text fallback tests, and exit-pill parsing in dsh-tool-bash.

The fallback path already exists: render the tool call and completed output as normal ACP content blocks. Non-Zed clients rely on that path anyway, but the Zed terminal card is a current target-client feature rather than speculative decoration.

Proposal

Ignore clientCapabilities._meta.terminal_output and render bash results through the plain ACP content path. Keep execution agent-side through dsh-bash; only the display-specific terminal metadata is removed. A terminal card can return later if ACP standardizes agent-executed terminals or if the product decides Zed-specific display is worth the maintenance cost.

This proposal is narrower than collapsing tool-owned UI presentation: it keeps generic presentCall/presentResult if those survive, but removes the terminal sub-shape and _meta mapping.

Acceptance criteria

ACP no longer reads or stores _meta.terminal_output capability state.
TerminalRendering, terminal ids, terminal cwd resolution, and _meta.terminal_* update mapping disappear from @deepseek-ai/dsh-acp.
ToolTerminal disappears from @deepseek-ai/dsh-tools, or is unused and deleted with the presentation cleanup.
Bash result presentation no longer parses exit status for terminal pills.
The implemented rich ACP bash rendering RFC stays in implemented/ as shipped history and is cross-linked from this proposal if superseded.

What we give up

Zed users lose the dedicated terminal card: no cwd header, terminal display, or exit pill. They still see the command and output as plain content. That is a reasonable simplification while the ACP bridge is still unreleased and the _meta keys are a convention rather than a standard.

2.6 KiB Raw Blame History

RFC: Drop ACP terminal _meta rendering