The koffi redesign moved the dialog from a spawned child process (which inherits a foreground-activation right from the spawning app) onto a worker thread of the same process, so Windows shows the dialog without activating it — it opens behind the app with a taskbar flash. The app has no native HWND to hand the seam, so raise from the driver: on the 'showing' notice (the worker posts it right before Show, before the dialog window exists), attach this thread's input queue to the dialog thread's, call SetForegroundWindow on its top-level window, and detach — retried on the close cadence until the window appears, stopped on settle/abort/success, never blocking the pick. Injectable seam mirrors closeThreadWindows; driver tests pin the raise and its retry; the in-process note records the mechanism (both languages, pairing re-recorded).
200 lines
8.5 KiB
TypeScript
200 lines
8.5 KiB
TypeScript
/**
|
|
* Driver tests: the worker message protocol mapped onto the promise, the
|
|
* foreground raise after the `showing` notice (retried until the dialog
|
|
* window exists), the WM_CLOSE abort service (including the show-race
|
|
* retry and the terminate last resort) against fakes, plus the real spawn
|
|
* plumbing — POSIX hosts prove the default path rejects cleanly (koffi
|
|
* cannot load ole32 there), and win32 hosts briefly open and auto-abort a
|
|
* real dialog.
|
|
*/
|
|
|
|
import { EventEmitter } from 'node:events'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { pickWin32Directory, type Win32DialogInternals, type Win32DialogWorkerLike } from '../src/win32-dialog.ts'
|
|
import type { Win32DialogWorkerMessage } from '../src/win32-dialog-worker.ts'
|
|
|
|
class FakeWorker extends EventEmitter implements Win32DialogWorkerLike {
|
|
terminate = vi.fn(async () => 0)
|
|
post(message: Win32DialogWorkerMessage): void {
|
|
this.emit('message', message)
|
|
}
|
|
}
|
|
|
|
interface Harness {
|
|
worker: FakeWorker
|
|
internals: Win32DialogInternals
|
|
close: ReturnType<typeof vi.fn>
|
|
raise: ReturnType<typeof vi.fn>
|
|
}
|
|
|
|
function harness(overrides: Partial<Win32DialogInternals> = {}): Harness {
|
|
const worker = new FakeWorker()
|
|
const close = vi.fn(async () => undefined)
|
|
const raise = vi.fn(async () => true)
|
|
return {
|
|
worker,
|
|
close,
|
|
raise,
|
|
internals: {
|
|
spawnWorker: () => worker,
|
|
closeThreadWindows: close,
|
|
raiseDialogWindow: raise,
|
|
closeRetryMs: 1,
|
|
...overrides,
|
|
},
|
|
}
|
|
}
|
|
|
|
const live = (): AbortSignal => new AbortController().signal
|
|
|
|
describe('pickWin32Directory', () => {
|
|
it('resolves the selected path and the cancellation null', async () => {
|
|
const first = harness()
|
|
const picked = pickWin32Directory(live(), first.internals)
|
|
first.worker.post({ kind: 'showing', threadId: 7 })
|
|
first.worker.post({ kind: 'done', path: 'C:\\picked' })
|
|
await expect(picked).resolves.toBe('C:\\picked')
|
|
expect(first.close).not.toHaveBeenCalled()
|
|
|
|
const second = harness()
|
|
const cancelled = pickWin32Directory(live(), second.internals)
|
|
second.worker.post({ kind: 'done', path: null })
|
|
await expect(cancelled).resolves.toBeNull()
|
|
})
|
|
|
|
it('raises the dialog window to the foreground after the showing notice', async () => {
|
|
const { worker, internals, raise } = harness()
|
|
const picked = pickWin32Directory(live(), internals)
|
|
worker.post({ kind: 'showing', threadId: 7 })
|
|
worker.post({ kind: 'done', path: 'C:\\raised' })
|
|
await expect(picked).resolves.toBe('C:\\raised')
|
|
expect(raise).toHaveBeenCalledWith(7)
|
|
})
|
|
|
|
it('retries the raise until the dialog window exists, then stops', async () => {
|
|
const { worker, internals, raise } = harness()
|
|
// The window is created inside `Show`, after the `showing` notice, so
|
|
// the first attempts find nothing; once a window is reported, the raise
|
|
// must stop retrying.
|
|
raise.mockResolvedValueOnce(false).mockResolvedValueOnce(false).mockResolvedValue(true)
|
|
const picked = pickWin32Directory(live(), internals)
|
|
worker.post({ kind: 'showing', threadId: 12 })
|
|
await vi.waitFor(() => {
|
|
expect(raise.mock.calls.length).toBeGreaterThanOrEqual(2)
|
|
})
|
|
const callsAfterRaised = await new Promise<number>((resolve) => {
|
|
setTimeout(() =>{ resolve(raise.mock.calls.length); }, 20)
|
|
})
|
|
await new Promise(resolve => setTimeout(resolve, 20))
|
|
expect(raise.mock.calls.length).toBe(callsAfterRaised)
|
|
worker.post({ kind: 'done', path: 'C:\\raised' })
|
|
await expect(picked).resolves.toBe('C:\\raised')
|
|
})
|
|
|
|
it('rejects on a reported dialog failure, a worker crash, and a silent exit', async () => {
|
|
const reported = harness()
|
|
const failing = pickWin32Directory(live(), reported.internals)
|
|
reported.worker.post({ kind: 'error', message: 'CoCreateInstance failed' })
|
|
await expect(failing).rejects.toThrow('win32 folder dialog failed: CoCreateInstance failed')
|
|
|
|
const crashed = harness()
|
|
const crashing = pickWin32Directory(live(), crashed.internals)
|
|
crashed.worker.emit('error', new Error('worker blew up'))
|
|
await expect(crashing).rejects.toThrow('worker blew up')
|
|
|
|
const silent = harness()
|
|
const exiting = pickWin32Directory(live(), silent.internals)
|
|
silent.worker.emit('exit', 0)
|
|
await expect(exiting).rejects.toThrow('exited before reporting a result')
|
|
})
|
|
|
|
it('settles once: a late exit after the result is inert', async () => {
|
|
const { worker, internals } = harness()
|
|
const picked = pickWin32Directory(live(), internals)
|
|
worker.post({ kind: 'done', path: 'C:\\once' })
|
|
worker.emit('exit', 0)
|
|
await expect(picked).resolves.toBe('C:\\once')
|
|
})
|
|
|
|
it('throws immediately on an already-aborted signal without spawning', async () => {
|
|
const spawnWorker = vi.fn()
|
|
const controller = new AbortController()
|
|
controller.abort()
|
|
await expect(pickWin32Directory(controller.signal, { spawnWorker, closeThreadWindows: async () => undefined }))
|
|
.rejects.toThrow('native directory picker aborted')
|
|
expect(spawnWorker).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('services an abort by closing the dialog thread windows until the worker reports', async () => {
|
|
const { worker, internals, close } = harness()
|
|
const controller = new AbortController()
|
|
// Attach the expectation BEFORE driving the race: on a fast host the
|
|
// close budget can exhaust (and reject) between waitFor ticks, and a
|
|
// rejection with no listener yet would count as unhandled.
|
|
const picked = expect(pickWin32Directory(controller.signal, internals)).rejects.toThrow('native directory picker aborted')
|
|
worker.post({ kind: 'showing', threadId: 99 })
|
|
controller.abort()
|
|
await vi.waitFor(() => {
|
|
expect(close).toHaveBeenCalledWith(99)
|
|
})
|
|
worker.post({ kind: 'done', path: null })
|
|
await picked
|
|
})
|
|
|
|
it('starts the close service on the showing notice when the abort came first', async () => {
|
|
const closeFailures = vi.fn(async () => { throw new Error('window not there yet') })
|
|
const { worker, internals, raise } = harness({ closeThreadWindows: closeFailures })
|
|
const controller = new AbortController()
|
|
// Attached before the race for the same unhandled-rejection reason above.
|
|
const picked = expect(pickWin32Directory(controller.signal, internals)).rejects.toThrow('native directory picker aborted')
|
|
controller.abort()
|
|
expect(closeFailures).not.toHaveBeenCalled()
|
|
worker.post({ kind: 'showing', threadId: 12 })
|
|
await vi.waitFor(() => {
|
|
expect(closeFailures.mock.calls.length).toBeGreaterThan(1)
|
|
})
|
|
expect(raise).not.toHaveBeenCalled()
|
|
worker.post({ kind: 'done', path: null })
|
|
await picked
|
|
})
|
|
|
|
it('terminates a worker that never reports showing after an abort', async () => {
|
|
// The budget runs without a thread id (nothing to WM_CLOSE yet), so a
|
|
// worker hung before `showing` cannot dangle the pick.
|
|
const { worker, internals, close } = harness()
|
|
const controller = new AbortController()
|
|
const picked = expect(pickWin32Directory(controller.signal, internals)).rejects.toThrow('dialog unresponsive; worker terminated')
|
|
controller.abort()
|
|
await picked
|
|
expect(worker.terminate).toHaveBeenCalledOnce()
|
|
expect(close).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('terminates an unresponsive worker after the close budget', async () => {
|
|
const { worker, internals, close } = harness()
|
|
const controller = new AbortController()
|
|
const picked = pickWin32Directory(controller.signal, internals)
|
|
worker.post({ kind: 'showing', threadId: 5 })
|
|
controller.abort()
|
|
await expect(picked).rejects.toThrow('dialog unresponsive; worker terminated')
|
|
expect(worker.terminate).toHaveBeenCalledOnce()
|
|
expect(close.mock.calls.length).toBeGreaterThan(10)
|
|
})
|
|
|
|
// POSIX hosts exercise the REAL default plumbing end to end: the tsx-bootstrapped
|
|
// worker spawns, loads koffi, fails to load ole32.dll, and reports the error.
|
|
it.skipIf(process.platform === 'win32')('rejects through the real worker where the Win32 surface is unavailable', async () => {
|
|
await expect(pickWin32Directory(live())).rejects.toThrow('win32 folder dialog failed')
|
|
}, 30_000)
|
|
|
|
// win32 hosts run the true COM smoke instead: a real dialog opens briefly
|
|
// and the abort service closes it (the same lever a disconnecting client pulls).
|
|
it.skipIf(process.platform !== 'win32')('opens and abort-closes a real dialog', async () => {
|
|
const controller = new AbortController()
|
|
setTimeout(() => {
|
|
controller.abort()
|
|
}, 400)
|
|
await expect(pickWin32Directory(controller.signal)).rejects.toThrow('native directory picker aborted')
|
|
}, 30_000)
|
|
})
|