- llm-deepseek: the uncatalogued resolveModel fallback declares text-only modalities — the wire route is text-only regardless of catalog membership, so "unknown" must not let the host persist-then-fail images. - session.selectModel also consults the pending-inbox mirror: a queued image prompt enters the log only when claimed, after a switch would land. - attachment store: ensureDurableDirectory syncs every ancestor entry up to a caller-vouched boundary regardless of what mkdir reports — a raced "already existed" is not "already durable". - One image walker (imageBlockIn/imageInEvent) now serves both attachment authorization and the selection gate; referencedImage therefore also authorizes references inside wrapped message content. - InputHub: the scope disposer resolves the conversation service optionally (teardown/HMR must reach quiescence), and a send failing after its scope died releases the in-flight drafts instead of restoring them onto a disposed shell. - http-bridge destroys declared-oversize requests with connection: close instead of draining a body the client can trickle indefinitely. - LlmService validates AND detaches modality arrays identically on the advisory and exact routes; READMEs record the fourth INVALID_MODEL_INFO rejection reason. - CLI provider docs (JSDoc, README pair, Agent Note pair) describe the reuse behavior; llm-route.spec now parses the SHIPPED cordis.yml through the production extraction, pinning the row coupling. - image-display lane pins gallery/rail shape in inline snapshots and the object-URL scheme this environment must take; stale host.schema comment dropped.
115 lines
5.5 KiB
TypeScript
115 lines
5.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
// ConversationService scope addressing over the runtime's real scope tag:
|
|
// TestSessions mints tagged scopes through the production createScope, so the
|
|
// service's scopeOf/binding path runs against production resolution (no local
|
|
// tag probe).
|
|
import { Context } from 'cordis'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { SlotTestRuntime } from '@deepseek-ai/dsh-client-test-runtime'
|
|
import { ConversationService } from '@deepseek-ai/dsh-client-ui-conversation/client'
|
|
import { InputHub } from '../src/client/input/hub.ts'
|
|
|
|
async function bench() {
|
|
const runtime = await SlotTestRuntime.create()
|
|
const prompt = vi.fn(() => Promise.resolve({ ok: true as const, value: { accepted: true as const } }))
|
|
const cancel = vi.fn(() => Promise.resolve({ ok: true as const, value: { accepted: true as const } }))
|
|
const loadOlder = vi.fn(() => Promise.resolve())
|
|
await runtime.sessions.add({
|
|
id: 's1',
|
|
session: { prompt, cancel, loadOlder },
|
|
})
|
|
// config.input is required (the apply shares its hub with the inject
|
|
// factories); the bench passes its own instance explicitly.
|
|
const hub = new InputHub(runtime.ctx)
|
|
const fiber = runtime.ctx.plugin(ConversationService, { input: hub })
|
|
await fiber.await()
|
|
const root = runtime.ctx.get('conversation') as ConversationService
|
|
const scoped = runtime.sessions.scope('s1')!.get('conversation') as ConversationService
|
|
return { runtime, hub, root, scoped, prompt, cancel, loadOlder }
|
|
}
|
|
|
|
describe('ConversationService', () => {
|
|
it('routes operations through the public Session binding', async () => {
|
|
const b = await bench()
|
|
await b.scoped.send('hello', 'steer')
|
|
await b.scoped.cancel()
|
|
await b.scoped.loadOlder()
|
|
expect(b.prompt).toHaveBeenCalledWith([{ type: 'text', text: 'hello' }], 'steer')
|
|
expect(b.cancel).toHaveBeenCalledOnce()
|
|
expect(b.loadOlder).toHaveBeenCalledOnce()
|
|
await b.runtime.dispose()
|
|
})
|
|
|
|
it('folds Session business failures into callback rejections', async () => {
|
|
const b = await bench()
|
|
b.prompt.mockResolvedValueOnce({ ok: false, error: { code: 'agent-busy', message: 'busy', details: {} } } as never)
|
|
await expect(b.scoped.send('x', 'queue')).rejects.toThrow('conversation.send failed: agent-busy: busy')
|
|
b.cancel.mockResolvedValueOnce({ ok: false, error: { code: 'internal', message: 'nope', details: {} } } as never)
|
|
await expect(b.scoped.cancel()).rejects.toThrow('conversation.cancel failed: internal: nope')
|
|
await b.runtime.dispose()
|
|
})
|
|
|
|
it('releases draft images when the session scope is disposed', async () => {
|
|
const b = await bench()
|
|
const created = vi.spyOn(URL, 'createObjectURL').mockReturnValue('blob:draft-1')
|
|
const revoked = vi.spyOn(URL, 'revokeObjectURL').mockReturnValue(undefined)
|
|
try {
|
|
const [attachment] = b.root.createDraftImages([new File([new Uint8Array(4)], 'a.png', { type: 'image/png' })])
|
|
if (attachment === undefined) throw new Error('draft attachment missing')
|
|
// Land the id in the session shell exactly as the composer does.
|
|
b.hub.shell(b.runtime.sessions.behavior('s1').sessionId).addImages([attachment.id])
|
|
await b.runtime.sessions.remove('s1')
|
|
// Scope teardown released the service-held File and its object URL.
|
|
expect(b.root.draftImages([attachment.id])).toEqual([])
|
|
expect(revoked).toHaveBeenCalledWith('blob:draft-1')
|
|
} finally {
|
|
created.mockRestore()
|
|
revoked.mockRestore()
|
|
}
|
|
await b.runtime.dispose()
|
|
})
|
|
|
|
it('releases in-flight send images when the scope dies before the failure lands', async () => {
|
|
const b = await bench()
|
|
const created = vi.spyOn(URL, 'createObjectURL').mockReturnValue('blob:inflight-1')
|
|
const revoked = vi.spyOn(URL, 'revokeObjectURL').mockReturnValue(undefined)
|
|
try {
|
|
const [attachment] = b.root.createDraftImages([new File([new Uint8Array(4)], 'b.png', { type: 'image/png' })])
|
|
if (attachment === undefined) throw new Error('draft attachment missing')
|
|
const shell = b.hub.shell(b.runtime.sessions.behavior('s1').sessionId)
|
|
shell.addImages([attachment.id])
|
|
let reject!: (error: Error) => void
|
|
b.prompt.mockReturnValueOnce(new Promise((_resolve, rej) => { reject = rej }) as never)
|
|
shell.setDraft('x')
|
|
shell.submit('queue')
|
|
// commitSend already removed the ids from the shell; kill the scope
|
|
// while the RPC is still pending, then land the failure.
|
|
await b.runtime.sessions.remove('s1')
|
|
reject(new Error('transport died'))
|
|
await vi.waitFor(() => {
|
|
expect(revoked).toHaveBeenCalledWith('blob:inflight-1')
|
|
})
|
|
expect(b.root.draftImages([attachment.id])).toEqual([])
|
|
} finally {
|
|
created.mockRestore()
|
|
revoked.mockRestore()
|
|
}
|
|
await b.runtime.dispose()
|
|
})
|
|
|
|
it('fails loudly from the root scope, on an unbound session, or without SessionsService', async () => {
|
|
const b = await bench()
|
|
await expect(b.root.send('x', 'queue')).rejects.toThrow(/requires a session scope/)
|
|
await b.runtime.sessions.remove('s1')
|
|
await expect(b.scoped.send('x', 'queue')).rejects.toThrow(/resolved no binding/)
|
|
await b.runtime.dispose()
|
|
// No SessionsService at all: a bare context (the runtime always provides one).
|
|
const bare = new Context()
|
|
await bare.plugin(ConversationService, {
|
|
input: new InputHub(bare),
|
|
}).await()
|
|
const orphan = bare.get('conversation') as ConversationService
|
|
await expect(orphan.send('x', 'queue')).rejects.toThrow(/sessions service unavailable/)
|
|
})
|
|
})
|