refactor: identify and freeze messages at creation

packages/telemetry/session-telemetry/src/coordinator.ts

@@ -251,7 +251,7 @@ function shutdownRecord(session: Session): TelemetryRecord {
 function severityOf(event: SessionEvent): TelemetrySeverity {
   switch (event.type) {
     case 'tool/result':
-      return event.data.isError ? 'error' : 'info'
+      return event.data.message.content[0].isError === true ? 'error' : 'info'
     case 'turn/end':
       return event.data.reason.kind === 'error' ? 'error' : 'info'
     default:

packages/telemetry/session-telemetry/src/index.ts

@@ -45,7 +45,7 @@ declare module 'cordis' {
 /**
  * Severity of a telemetry record, pre-mapped at capture so a receiver can
  * alert with zero configuration: `error` for events whose own outcome flag
- * says so (`tool/result.isError`, `turn/end` error reasons) and for
+ * says so (the tool-result block's `isError`, `turn/end` error reasons) and for
  * `agent-error` operational records. Captured events otherwise default to
  * `info`; `warn` remains available to `telemetry/record` policies and
  * backends.

packages/telemetry/session-telemetry/tests/redact.spec.ts

@@ -1,3 +1,4 @@
+import { createUserMessage } from '@deepseek-ai/dsh-llm'
 /**
  * The `telemetry/record` waterfall contract: pass-through when no listener is
  * mounted, listener stacking and replacement, ops-record coverage, the
@@ -39,7 +40,9 @@ describe('telemetry/record waterfall', () => {
   it('passes records through unchanged when no listener is mounted', async () => {
     const { ctx, backend } = await setup()
     const session = ctx.sessions.create(SessionId('w'))
-    session.append('user/message', { content: [{ type: 'text', text: `key ${FIXTURE_SECRET}` }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: `key ${FIXTURE_SECRET}` }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     const body = backend.records[0]!.body as { content: { text: string }[] }
     expect(body.content[0]!.text).toBe(`key ${FIXTURE_SECRET}`)
   })
@@ -51,7 +54,9 @@ describe('telemetry/record waterfall', () => {
       return { ...record, body: { scrubbed: true } }
     })
     const session = ctx.sessions.create(SessionId('rule'))
-    session.append('user/message', { content: [{ type: 'text', text: FIXTURE_SECRET }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: FIXTURE_SECRET }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     expect(backend.records[0]!.body).toEqual({ scrubbed: true })
     // The dispose-time shutdown ops record passes through the same waterfall.
     await fiber.dispose()
@@ -64,7 +69,9 @@ describe('telemetry/record waterfall', () => {
     const { ctx } = await setup()
     ctx.on('telemetry/record', (_record, next) => ({ ...next(), body: null }))
     const session = ctx.sessions.create(SessionId('log'))
-    session.append('user/message', { content: [{ type: 'text', text: FIXTURE_SECRET }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: FIXTURE_SECRET }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     const logged = session.events[0]!.data as { content: { text: string }[] }
     expect(logged.content[0]!.text).toBe(FIXTURE_SECRET)
   })
@@ -84,7 +91,9 @@ describe('telemetry/record waterfall', () => {
       return { ...record, attributes: { ...record.attributes, inner: 1 } }
     })
     const session = ctx.sessions.create(SessionId('stack'))
-    session.append('user/message', { content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     expect(order).toEqual(['outer-before', 'inner', 'outer-after'])
     expect(backend.records[0]!.attributes).toMatchObject({ outer: 1, inner: 1 })
   })
@@ -98,7 +107,9 @@ describe('telemetry/record waterfall', () => {
       return next()
     })
     const session = ctx.sessions.create(SessionId('veto'))
-    session.append('user/message', { content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     expect(backend.records[0]!.body).toBe('replaced')
     expect(inner.called).toBe(false)
   })
@@ -109,7 +120,9 @@ describe('telemetry/record waterfall', () => {
       throw new Error('rule exploded')
     })
     const session = ctx.sessions.create(SessionId('closed'))
-    session.append('user/message', { content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+    session.append('user/message', createUserMessage({
+      content: [{ type: 'text', text: 'hi' }], source: { kind: 'user' },
+    }), { surfaceOp: 'append' })
     expect(backend.records).toHaveLength(0)
     expect(session.events).toHaveLength(1)
   })

packages/telemetry/session-telemetry/tests/telemetry.spec.ts

@@ -1,3 +1,4 @@
+import { createToolResultMessage, createUserMessage } from '@deepseek-ai/dsh-llm'
 /**
  * Coordinator semantics against a bare fake backend — the RFC's named unit
  * tier for the seam: adoption (fresh, seeded, re-adoption via the handoff
@@ -70,7 +71,9 @@ function liveSession(ctx: Context, id = `s-${Math.random().toString(36).slice(2)
 
 function appendTurn(session: Session): void {
   session.append('turn/start', { turn: 1, trigger: { kind: 'message', source: { kind: 'user' } } })
-  session.append('user/message', { content: [{ type: 'text', text: 'hello' }], source: { kind: 'user' } }, { surfaceOp: 'append' })
+  session.append('user/message', createUserMessage({
+    content: [{ type: 'text', text: 'hello' }], source: { kind: 'user' },
+  }), { surfaceOp: 'append' })
 }
 
 describe('TelemetryCoordinator capture', () => {
@@ -106,8 +109,22 @@ describe('TelemetryCoordinator capture', () => {
     const { ctx, backend } = await setup()
     const session = liveSession(ctx)
     session.append('turn/start', { turn: 1, trigger: { kind: 'message', source: { kind: 'user' } } })
-    session.append('tool/result', { turn: 1, step: 1, callId: 'c1' as never, content: [], isError: true }, { surfaceOp: 'append' })
-    session.append('tool/result', { turn: 1, step: 1, callId: 'c2' as never, content: [], isError: false }, { surfaceOp: 'append' })
+    session.append('tool/result', {
+      turn: 1, step: 1,
+      message: createToolResultMessage({
+        callId: 'c1' as never,
+        content: [],
+        isError: true,
+      }),
+    }, { surfaceOp: 'append' })
+    session.append('tool/result', {
+      turn: 1, step: 1,
+      message: createToolResultMessage({
+        callId: 'c2' as never,
+        content: [],
+        isError: false,
+      }),
+    }, { surfaceOp: 'append' })
     session.append('telemetry-test/opaque', { payload: { nested: [] } })
     session.append('turn/end', { turn: 1, reason: { kind: 'error', step: 1, message: 'boom' } })
     const severities = backend.ledger().map(r => [r.attributes['event.type'], r.severity])