refactor: identify and freeze messages at creation

packages/core/session/tests/repair.spec.ts

@@ -1,5 +1,5 @@
 import { describe, expect, it } from 'vitest'
-import { CallId } from '@deepseek-ai/dsh-llm'
+import { CallId , createMessage, createToolResultMessage } from '@deepseek-ai/dsh-llm'
 import { interruptedTurnClosers, TOOL_NOT_STARTED, TOOL_OUTCOME_UNKNOWN } from '../src/index.ts'
 import type { SessionEvent, SurfaceEvent } from '../src/index.ts'
 
@@ -51,10 +51,20 @@ describe('interruptedTurnClosers', () => {
     const events: SessionEvent[] = [
       userTurnStart(2, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 2, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 2, step: 1, content: [
-        { type: 'text', text: 'calling a tool' },
-        { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 2, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'text', text: 'calling a tool' },
+            { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
     ]
     const closers = interruptedTurnClosers(events)
     // tool/result (for the orphaned call) → step/end → turn/end, contiguous seqs.
@@ -62,9 +72,15 @@ describe('interruptedTurnClosers', () => {
     expect(closers.map(e => e.seq)).toEqual([3, 4, 5])
     const result = closers[0]!
     expect(result.type === 'tool/result' && result.data).toMatchObject({
-      turn: 2, step: 1, callId: CallId('call-1'), isError: true, error: { code: TOOL_NOT_STARTED },
+      turn: 2,
+      step: 1,
+      message: {
+        source: { callId: CallId('call-1') },
+        content: [{ isError: true }],
+      },
+      error: { code: TOOL_NOT_STARTED },
     })
-    expect(result.type === 'tool/result' && result.data.content).toEqual([{
+    expect(result.type === 'tool/result' && result.data.message.content[0].content).toEqual([{
       type: 'text', text: 'The tool call was interrupted before the Harness recorded it as started. Retry it if it is still needed.',
     }])
   })
@@ -73,10 +89,27 @@ describe('interruptedTurnClosers', () => {
     const events: SessionEvent[] = [
       userTurnStart(2, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 2, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 2, step: 1, content: [
-        { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
-      { type: 'tool/result', seq: 3, time: 3, data: { turn: 2, step: 1, callId: CallId('call-1'), content: [{ type: 'text', text: 'ok' }], isError: false } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 2, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
+      { type: 'tool/result', seq: 3, time: 3, data: {
+        turn: 2, step: 1,
+        message: createToolResultMessage({
+          callId: CallId('call-1'),
+          content: [{ type: 'text', text: 'ok' }],
+          isError: false,
+        }),
+      } },
     ]
     // The call is answered, so only the open step + turn need closing.
     const closers = interruptedTurnClosers(events)
@@ -87,9 +120,19 @@ describe('interruptedTurnClosers', () => {
     const events: SessionEvent[] = [
       userTurnStart(2, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 2, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 2, step: 1, content: [
-        { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 2, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
       { type: 'step/end', seq: 3, time: 3, data: { turn: 2, step: 1 } },
     ]
 
@@ -104,48 +147,102 @@ describe('interruptedTurnClosers', () => {
     const events: SessionEvent[] = [
       userTurnStart(1, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 1, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 1, step: 1, content: [
-        { type: 'tool-call', id: CallId('old-call'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
-      { type: 'tool/result', seq: 3, time: 3, data: { turn: 1, step: 1, callId: CallId('old-call'), content: [], isError: false } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 1, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('old-call'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
+      { type: 'tool/result', seq: 3, time: 3, data: {
+        turn: 1, step: 1,
+        message: createToolResultMessage({
+          callId: CallId('old-call'),
+          content: [],
+          isError: false,
+        }),
+      } },
       { type: 'step/end', seq: 4, time: 4, data: { turn: 1, step: 1 } },
       { type: 'turn/end', seq: 5, time: 5, data: { turn: 1, reason: { kind: 'completed' } } },
       userTurnStart(2, 6),
       { type: 'step/start', seq: 7, time: 7, data: { turn: 2, step: 1 } },
-      { type: 'assistant/message', seq: 8, time: 8, data: { turn: 2, step: 1, content: [
-        { type: 'tool-call', id: CallId('new-call'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
+      { type: 'assistant/message', seq: 8, time: 8, data: {
+        turn: 2, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('new-call'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
     ]
     const closers = interruptedTurnClosers(events)
     expect(closers.map(e => e.type)).toEqual(['tool/result', 'step/end', 'turn/end'])
     const result = closers[0]!
-    expect(result.type === 'tool/result' && result.data.callId).toBe('new-call')
+    expect(result.type === 'tool/result' && result.data.message.source.callId).toBe('new-call')
   })
 
   it('synthesizes a result for each of multiple unanswered calls, in log order', () => {
     const events: SessionEvent[] = [
       userTurnStart(1, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 1, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 1, step: 1, content: [
-        { type: 'tool-call', id: CallId('call-a'), name: 'bash', arguments: '{}' },
-        { type: 'tool-call', id: CallId('call-b'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 1, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('call-a'), name: 'bash', arguments: '{}' },
+            { type: 'tool-call', id: CallId('call-b'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
       // call-a got answered before the crash; call-b did not.
-      { type: 'tool/result', seq: 3, time: 3, data: { turn: 1, step: 1, callId: CallId('call-a'), content: [], isError: false } },
+      { type: 'tool/result', seq: 3, time: 3, data: {
+        turn: 1, step: 1,
+        message: createToolResultMessage({
+          callId: CallId('call-a'),
+          content: [],
+          isError: false,
+        }),
+      } },
     ]
     const closers = interruptedTurnClosers(events)
     expect(closers.map(e => e.type)).toEqual(['tool/result', 'step/end', 'turn/end'])
     const result = closers[0]!
-    expect(result.type === 'tool/result' && result.data.callId).toBe('call-b')
+    expect(result.type === 'tool/result' && result.data.message.source.callId).toBe('call-b')
   })
 
   it('synthesized tool/result carries surfaceOp and sourceEventSeqs when tool/call was logged', () => {
     const events: SessionEvent[] = [
       userTurnStart(1, 0),
       { type: 'step/start', seq: 1, time: 1, data: { turn: 1, step: 1 } },
-      { type: 'assistant/message', seq: 2, time: 2, data: { turn: 1, step: 1, content: [
-        { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
-      ], provenance: { provider: 'mock', model: 'mock' } } },
+      { type: 'assistant/message', seq: 2, time: 2, data: {
+        turn: 1, step: 1,
+        message: createMessage({
+          role: 'assistant',
+          content: [
+            { type: 'tool-call', id: CallId('call-1'), name: 'bash', arguments: '{}' },
+          ],
+          source: {
+            kind: 'model',
+            ...{ provider: 'mock', model: 'mock' },
+          },
+        }),
+      } },
       { type: 'tool/call', seq: 3, time: 3, data: { turn: 1, step: 1, callId: CallId('call-1'), name: 'bash', arguments: '{}' } },
     ]
     const closers = interruptedTurnClosers(events)
@@ -156,11 +253,11 @@ describe('interruptedTurnClosers', () => {
     expect(result.type === 'tool/result' && result.data.error).toEqual({
       name: 'ToolOutcomeUnknownError', code: TOOL_OUTCOME_UNKNOWN,
     })
-    if (result.type !== 'tool/result' || result.data.content[0]?.type !== 'text') {
+    if (result.type !== 'tool/result' || result.data.message.content[0].content[0]?.type !== 'text') {
       throw new Error('expected a text tool result')
     }
-    expect(result.data.content[0].text).toContain('retry only if the operation is read-only or idempotent')
-    expect(result.data.content[0].text).toContain('first verify external state or ask the user')
+    expect(result.data.message.content[0].content[0].text).toContain('retry only if the operation is read-only or idempotent')
+    expect(result.data.message.content[0].content[0].text).toContain('first verify external state or ask the user')
   })
 
   it('handles tool/call without a matching assistant/message entry gracefully', () => {