fix(review): label host-preparation failures and gate vendored lockfile links

ds-review-bot round 1: boot() now throws `host preparation failed` when
prepare() rejects before any config-tree entry mounts (the plugin-tree label
overstated), and the new hygiene gate verify-vendored-links pins the
linkWorkspacePackages fix — every vendored package name in pnpm-lock.yaml
must resolve to a workspace link with no registry copy alongside.
This commit is contained in:
Tianyi Cui
2026-08-01 20:41:43 +08:00
parent 0a297c39d3
commit f941ba1b5f
5 changed files with 89 additions and 7 deletions

View File

@@ -335,7 +335,7 @@ describe('boot', () => {
})
await expect(task).rejects.toMatchObject({
message: `${NAME}: plugin tree failed to load: ${failure}`,
message: `${NAME}: host preparation failed: ${failure}`,
cause: failure,
})
expect(disposed).toBe(true)
@@ -418,9 +418,9 @@ describe('boot', () => {
const deepest = new Error('stackless deep failure')
delete (deepest as { stack?: string }).stack
await expect(boot(NAME, join(dir, 'cordis.yml'), undefined, () => {
throw new Error('host preparation failed', { cause: deepest })
throw new Error('wrapped setup failure', { cause: deepest })
})).rejects.toThrow(
`${NAME}: plugin tree failed to load: host preparation failed\nstackless deep failure`,
`${NAME}: host preparation failed: wrapped setup failure\nstackless deep failure`,
)
})