fix: advance resolving issue status from PRs

.github/issue-management/policy.mjs

@@ -12,6 +12,7 @@ const AUDIT_MARKER = '<!-- dsh-issue-policy -->'
 const OWNER_LINE = /^Owner: @([A-Za-z0-9](?:[A-Za-z0-9-]{0,37}[A-Za-z0-9])?)$/
 const TYPES = new Set(['Idea', 'Feature', 'Bug', 'Research', 'Task'])
 const PRIORITIES = ['p0', 'p1', 'p2', 'p3']
+const ACTIVE_STATUS_ORDER = ['Inbox', 'Backlog', 'Ready', 'In progress', 'In review']
 
 /**
  * Return Markdown outside balanced details elements.
@@ -129,6 +130,22 @@ export function requiresPullRequestPolicy({
   return !isDraft && !automated && (reviewRequestCount > 0 || reviewCount > 0)
 }
 
+/**
+ * Derive a forward-only Issue status from the current PR phase.
+ * @param {string|null} currentStatus Current Project status.
+ * @param {{isDraft: boolean, reviewRequestCount: number, reviewCount: number}} pull PR phase.
+ * @returns {string|null} Status to write, or null when no forward transition exists.
+ */
+export function nextResolvingIssueStatus(currentStatus, pull) {
+  const target =
+    !pull.isDraft && (pull.reviewRequestCount > 0 || pull.reviewCount > 0)
+      ? 'In review'
+      : 'In progress'
+  const currentIndex = ACTIVE_STATUS_ORDER.indexOf(currentStatus)
+  const targetIndex = ACTIVE_STATUS_ORDER.indexOf(target)
+  return currentIndex >= 0 && currentIndex < targetIndex ? target : null
+}
+
 function stripIgnoredMarkdown(body) {
   const lines = body.replace(/<!--[\s\S]*?-->/g, '').split(/\r?\n/)
   const kept = []
@@ -491,11 +508,13 @@ async function pullRequestSnapshot(number) {
   }
 }
 
-async function moveResolvingIssues(pull, from, to) {
+async function advanceResolvingIssues(pull) {
   for (const number of pull.references.resolving) {
     const current = await issueSnapshot(number)
-    if (!current || current.status !== from) continue
-    await setStatus(number, to)
+    if (!current) continue
+    const target = nextResolvingIssueStatus(current.status, pull)
+    if (!target) continue
+    await setStatus(number, target)
     await auditIssue(number)
   }
 }
@@ -530,12 +549,7 @@ async function runLifecycle(eventName, event) {
 
   if (eventName === 'pull_request' || eventName === 'pull_request_review') {
     const pull = await pullRequestSnapshot(event.pull_request.number)
-    const errors = validatePullRequest(pull)
-    if (errors.length > 0) return
-    await moveResolvingIssues(pull, 'Ready', 'In progress')
-    if (pull.reviewRequestCount > 0 || pull.reviewCount > 0) {
-      await moveResolvingIssues(pull, 'In progress', 'In review')
-    }
+    await advanceResolvingIssues(pull)
   }
 }
 

.github/issue-management/policy.test.mjs

@@ -3,6 +3,7 @@ import test from 'node:test'
 
 import {
   countVisibleUnits,
+  nextResolvingIssueStatus,
   parseReferences,
   retainIssueReferences,
   requiresPullRequestPolicy,
@@ -191,6 +192,49 @@ test('requires policy only after a human PR enters review', () => {
   )
 })
 
+test('advances resolving Issues to the live PR phase', () => {
+  const draft = { isDraft: true, reviewRequestCount: 1, reviewCount: 4 }
+  const open = { isDraft: false, reviewRequestCount: 0, reviewCount: 0 }
+  const requestedReview = { isDraft: false, reviewRequestCount: 1, reviewCount: 0 }
+  const submittedReview = { isDraft: false, reviewRequestCount: 0, reviewCount: 1 }
+
+  for (const status of ['Inbox', 'Backlog', 'Ready']) {
+    assert.equal(nextResolvingIssueStatus(status, draft), 'In progress')
+    assert.equal(nextResolvingIssueStatus(status, open), 'In progress')
+    assert.equal(nextResolvingIssueStatus(status, requestedReview), 'In review')
+    assert.equal(nextResolvingIssueStatus(status, submittedReview), 'In review')
+  }
+  assert.equal(nextResolvingIssueStatus('In progress', requestedReview), 'In review')
+  assert.equal(nextResolvingIssueStatus('In progress', submittedReview), 'In review')
+})
+
+test('never regresses or reopens a resolving Issue', () => {
+  const implementation = { isDraft: false, reviewRequestCount: 0, reviewCount: 0 }
+  const review = { isDraft: false, reviewRequestCount: 0, reviewCount: 1 }
+
+  assert.equal(nextResolvingIssueStatus('In progress', implementation), null)
+  assert.equal(nextResolvingIssueStatus('In review', implementation), null)
+  assert.equal(nextResolvingIssueStatus('In review', review), null)
+  assert.equal(nextResolvingIssueStatus('Done', review), null)
+  assert.equal(nextResolvingIssueStatus('No action', review), null)
+  assert.equal(nextResolvingIssueStatus(null, review), null)
+})
+
+test('keeps lifecycle projection independent of PR metadata enforcement', () => {
+  const pull = {
+    isDraft: false,
+    authorType: 'User',
+    reviewRequestCount: 1,
+    reviewCount: 0,
+    labels: [],
+    references: { all: [2], resolving: [2], related: [] },
+    issues: new Map([[2, { priority: null }]]),
+  }
+
+  assert.ok(validatePullRequest(pull).length > 0)
+  assert.equal(nextResolvingIssueStatus('Inbox', pull), 'In review')
+})
+
 test('exempts Draft, Bot, and App PRs', () => {
   const invalid = {
     isDraft: false,