Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(feedback): include session id in acknowledgement

Browse Source
This commit is contained in:
Turtle
2026-08-07 16:01:41 +08:00
parent a44009ec35
commit ef35c7f3b2
6 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/feedback/command-feedback/tests/command-feedback.spec.ts
View File

@@ -93,7 +93,7 @@ describe('/feedback human command', () => {
const test = await harness()
await expect(run(test, ' the diff view is unreadable')).resolves.toEqual({
kind: 'success',
text: 'Feedback recorded.',
text: `Feedback recorded for session ${test.session.id}`,
})
expect(feedbackTexts(test.session)).toEqual(['the diff view is unreadable'])
const commandRun = test.session.events.find(event => event.type === 'command/run')
@@ -141,8 +141,8 @@ describe('/feedback human command', () => {
test.ctx.commands.execute(test.agent, '/feedback second', signal),
])
expect(settled.map(item => item?.result)).toEqual([
{ kind: 'success', text: 'Feedback recorded.' },
{ kind: 'success', text: 'Feedback recorded.' },
{ kind: 'success', text: `Feedback recorded for session ${test.session.id}` },
{ kind: 'success', text: `Feedback recorded for session ${test.session.id}` },
])
expect(feedbackTexts(test.session)).toEqual(['first', 'second'])
})

5
packages/feedback/command-feedback/tests/loader-composition.spec.ts
View File

@@ -87,7 +87,10 @@ describe('/feedback real Loader composition through cordis.yml', () => {
expect(context.commands.list(owner).map(command => command.name)).toContain('feedback')
const accepted = await context.commands.execute(owner, '/feedback the diff view is unreadable', signal)
expect(accepted?.result).toEqual({ kind: 'success', text: 'Feedback recorded.' })
expect(accepted?.result).toEqual({
kind: 'success',
text: 'Feedback recorded for session feedback-loader-agent',
})
const rejected = await context.commands.execute(owner, '/feedback', signal)
expect(rejected?.result).toEqual({
kind: 'error',