feat(permission): add new-session default setting

packages/client/ui-settings-general/README.i18n.yaml

@@ -1,6 +1,6 @@
 # Bilingual-pair consistency record (docs/i18n/README.md): the git blob hash of each
 # side as of the last confirmed-consistent state. Both languages carry equal authority;
 # after editing either side, bring the other along and re-record with:
-#   pnpm run verify-translation-pairing --write
-README.md: c392d745021c0fc6a752cf71dd0506a435106c50
-README.zh.md: 83ab81e01eae435a74b50fa363a4de203c483002
+#   pnpm run verify-translation-pairing --write packages/client/ui-settings-general/README.md
+README.md: 9e12f02fc1e767fb807be4fdd3f506c189662bc7
+README.zh.md: 225e27f5705f33bc6199615b0fe96e04eaa6a04c

packages/client/ui-settings-general/README.md

@@ -2,7 +2,7 @@
 
 English | [中文](README.zh.md)
 
-Settings ownerless-copy plugin: registers everything on the Settings surface that belongs to no single feature — the shell's trigger/header/close chrome content, the General section (Permission/Tool Call skeleton rows + the `settings.general.item` slot declaration), and the `settings` dictionaries. Feature-owned rows (Language, Appearance) and sections (Models) stay with their feature packages.
+Settings ownerless-copy plugin: registers everything on the Settings surface that belongs to no single feature — the shell's trigger/header/close chrome content, the General section (`settings.general.item` slot plus the Tool Call skeleton), and the `settings` dictionaries. Feature-owned rows (Permission, Language, Appearance) and sections (Models) stay with their feature packages.
 
 ## Model Experience
 
@@ -14,4 +14,4 @@ None; this package neither assembles nor sends a provider request.
 
 ## Known Limitations and Deferred Work
 
-- **Permission and Tool Call are display skeletons** — the backing host services and RPC methods do not exist yet; the controls are disabled and write nothing. When they gain real backing, each moves to its owning feature plugin per the self-registration doctrine.
+- **Tool Call is a display skeleton** — its backing host setting does not exist yet, so the cubes write nothing. When it gains real backing, the row moves to its owning feature plugin per the self-registration doctrine.

packages/client/ui-settings-general/README.zh.md

@@ -2,7 +2,7 @@
 
 [English](README.md) | 中文
 
-设置界面文案插件：在设置界面注册所有不属于单一功能的内容，包括外壳的触发器、标题栏与关闭控件内容，「通用」分区（「权限」／「工具调用」骨架行和 `settings.general.item` slot 声明），以及 `settings` 字典。归具体功能所有的行（「语言」、「外观」）和分区（「模型」）仍由各自的功能包提供。
+设置界面无归属文案插件：在设置界面注册所有不属于单一功能的内容，包括外壳的触发器、标题栏与关闭控件内容，「通用」分区（`settings.general.item` slot 加上「工具调用」骨架行），以及 `settings` 字典。归具体功能所有的行（「权限」、「语言」、「外观」）和分区（「模型」）仍由各自的功能包提供。
 
 ## 模型体验
 
@@ -14,4 +14,4 @@
 
 ## 已知限制与暂缓事项
 
-- **「权限」与「工具调用」只是展示骨架**：对应的宿主服务和 RPC 方法尚不存在；这些控件已禁用，不会写入任何内容。一旦获得实际支撑，按照自注册原则，每一项都会移至拥有它的功能插件。
+- **「工具调用」只是展示骨架**：其宿主设置尚不存在，因此控件不会写入任何内容。一旦获得实际支撑，按照自注册原则，该行会移至拥有它的功能插件。

packages/client/ui-settings-general/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@deepseek-ai/dsh-client-ui-settings-general",
-  "description": "Settings ownerless-copy plugin: the General section (skeleton rows + item slot), the shell trigger/header chrome content, and the settings dictionaries",
+  "description": "Settings ownerless-copy plugin: the General section and Tool Call skeleton, shell trigger/header chrome content, and settings dictionaries",
   "version": "0.0.1",
   "private": true,
   "type": "module",

packages/client/ui-settings-general/src/client/GeneralSection.module.css

@@ -13,15 +13,6 @@
   border-bottom: none;
 }
 
-/* Title + trailing control row (figma 'Setting-Cell': gap 8, pad 16/0). */
-.row {
-  display: flex;
-  align-items: center;
-  gap: 8px;
-  padding: 16px 0;
-  border-bottom: 1px solid var(--dsw-alias-border-l2);
-}
-
 /* Title + full-width body group (figma 'Frame 2117131229': column, gap 8). */
 .group {
   display: flex;
@@ -31,16 +22,6 @@
   border-bottom: 1px solid var(--dsw-alias-border-l2);
 }
 
-/* Leading text column (figma 'Frame 2036083120': gap 4, pad-right 48). */
-.rowText {
-  flex: 1;
-  min-width: 0;
-  display: flex;
-  flex-direction: column;
-  gap: 4px;
-  padding-right: 48px;
-}
-
 .title {
   font-size: 14px;
   font-weight: 400;
@@ -55,35 +36,6 @@
   color: var(--dsw-alias-label-tertiary);
 }
 
-/* Selector pill (figma 'Selector': h36 r18, fill #F5F6F7, pad 0/14, gap 12). */
-.selector {
-  display: inline-flex;
-  align-items: center;
-  gap: 12px;
-  height: 36px;
-  padding: 0 14px;
-  border: none;
-  border-radius: 18px;
-  background: var(--dsw-alias-bg-module-platform);
-  font: inherit;
-  font-size: 14px;
-  line-height: 22px;
-  color: var(--dsw-alias-label-primary);
-  cursor: pointer;
-}
-
-.selector:hover:not(:disabled) {
-  background: var(--dsw-alias-interactive-bg-hover);
-}
-
-.selector:disabled {
-  cursor: default;
-}
-
-.chevron {
-  flex: none;
-}
-
 /* Tool Call mode cubes share an 8px gap and wrap to one per row when the
    panel is too narrow. */
 .cubeRow {

packages/client/ui-settings-general/src/client/GeneralSection.tsx

@@ -1,55 +1,51 @@
 /**
- * The General section (figma 501:29983 'Options'): Permission and Tool Call
- * skeleton rows, then the feature-contributed preference rows from the
- * `settings.general.item` slot (locale → Language, ui-theme → Appearance).
- * The section column stacks rows; each row draws its own internals and
- * separator.
+ * The General section (figma 501:29983 'Options'): one column rendering the
+ * `settings.general.item` contributions. Features own their rows; this
+ * package contributes only the ownerless Tool Call skeleton.
  */
-import { IconChevronDownOutline14 } from '@deepseek-ai/dsh-client-ui-primitives'
 import type { PropsLocale, PropsRenderSlots, PropsRuntime } from '@deepseek-ai/dsh-client-ui-slots'
 import css from './GeneralSection.module.css'
 
-/** Full component props: section owner share + item render share + the standard locale seat. */
+/** Full component props: section owner share plus item render share. */
 export type GeneralSectionComponentProps =
-  PropsRuntime<'settings.section'> & PropsRenderSlots<'settings.general.item'> & PropsLocale<'settings'>
+  PropsRuntime<'settings.section'> & PropsRenderSlots<'settings.general.item'>
 
 /**
  * Render the General section content column.
  * @param props - composed slot props (contract/slots.ts).
  * @returns the section element tree.
  */
-export function GeneralSection({ t, renderSlot }: GeneralSectionComponentProps) {
+export function GeneralSection({ renderSlot }: GeneralSectionComponentProps) {
   return (
     <div className={css.section}>
-      {/* Permission (skeleton): disabled selector pill. */}
-      <div className={css.row}>
-        <div className={css.rowText}>
-          <div className={css.title}>{t('permission.title')}</div>
-          <div className={css.desc}>{t('permission.desc')}</div>
-        </div>
-        <button type="button" className={css.selector} disabled>
-          {t('permission.value')}
-          <IconChevronDownOutline14 className={css.chevron} />
-        </button>
-      </div>
-
-      {/* Tool Call (skeleton): schema cube pinned selected, code cube unselected. */}
-      <div className={css.group}>
-        <div className={css.title}>{t('toolcall.title')}</div>
-        <div className={css.cubeRow}>
-          <div className={`${css.modeCube} ${css.selected}`}>
-            <div className={css.title}>{t('toolcall.schema.title')}</div>
-            <div className={css.desc}>{t('toolcall.schema.desc')}</div>
-          </div>
-          <div className={css.modeCube}>
-            <div className={css.title}>{t('toolcall.code.title')}</div>
-            <div className={css.desc}>{t('toolcall.code.desc')}</div>
-          </div>
-        </div>
-      </div>
-
-      {/* Feature-owned preference rows (Language, Appearance, …). */}
       {renderSlot('settings.general.item', {})}
     </div>
   )
 }
+
+/** Props of the ownerless Tool Call item contribution. */
+export type ToolCallSkeletonProps =
+  PropsRuntime<'settings.general.item'> & PropsLocale<'settings'>
+
+/**
+ * Render the static Tool Call mode choice until its host setting exists.
+ * @param props - item runtime and translated copy.
+ * @returns the skeleton row.
+ */
+export function ToolCallSkeleton({ t }: ToolCallSkeletonProps) {
+  return (
+    <div className={css.group}>
+      <div className={css.title}>{t('toolcall.title')}</div>
+      <div className={css.cubeRow}>
+        <div className={`${css.modeCube} ${css.selected}`}>
+          <div className={css.title}>{t('toolcall.schema.title')}</div>
+          <div className={css.desc}>{t('toolcall.schema.desc')}</div>
+        </div>
+        <div className={css.modeCube}>
+          <div className={css.title}>{t('toolcall.code.title')}</div>
+          <div className={css.desc}>{t('toolcall.code.desc')}</div>
+        </div>
+      </div>
+    </div>
+  )
+}

packages/client/ui-settings-general/src/client/index.ts

@@ -1,9 +1,9 @@
 /**
  * Settings ownerless-copy plugin, browser half: registers everything on the
  * Settings surface that belongs to no single feature — the trigger/header
- * chrome content, the General section (skeleton rows + the
- * `settings.general.item` slot declaration), and the `settings`
- * dictionaries. Feature-owned rows and sections stay with their features.
+ * chrome content, the General section (`settings.general.item` slot plus the
+ * ownerless Tool Call skeleton), and the `settings` dictionaries.
+ * Feature-owned rows and sections stay with their features.
  * Export discipline: packages/client/AGENTS.md.
  */
 import type { ClientContext } from '@deepseek-ai/dsh-client-runtime/client'
@@ -13,13 +13,15 @@ import type {} from '@deepseek-ai/dsh-client-ui-settings/client'
 // Type-only: pulls ctx.locale and the 'settings.general.item' SlotMap merge.
 import type {} from '@deepseek-ai/dsh-client-locale/client'
 import { CloseLabel, HeaderContent, TriggerContent } from './chrome.tsx'
-import { GeneralSection } from './GeneralSection.tsx'
+import { GeneralSection, ToolCallSkeleton } from './GeneralSection.tsx'
 import { en, zh, type SettingsKey } from './locales.ts'
 
 export type {
   CloseLabelProps, HeaderContentProps, TriggerContentProps,
 } from './chrome.tsx'
-export type { GeneralSectionComponentProps } from './GeneralSection.tsx'
+export type {
+  GeneralSectionComponentProps, ToolCallSkeletonProps,
+} from './GeneralSection.tsx'
 export type { SettingsKey } from './locales.ts'
 
 declare module '@deepseek-ai/dsh-client-ui-slots' {
@@ -67,11 +69,19 @@ export function apply(ctx: ClientContext): void {
         locale: NS,
         children: { 'settings.general.item': { kind: 'list', scope: 'root' } },
       }, GeneralSection))
+    const toolCall = deferRegistration(ctx.slots, 'settings.general.item', ToolCallSkeleton, () =>
+      ctx.slots.register({
+        name: 'settings.general.item',
+        id: 'tool-call',
+        order: -10,
+        locale: NS,
+      }, ToolCallSkeleton))
     return () => {
       trigger.dispose()
       header.dispose()
       close.dispose()
       general.dispose()
+      toolCall.dispose()
     }
   }, 'ui-settings-general: chrome and section registrations')
 }

packages/client/ui-settings-general/src/client/locales.ts

@@ -1,12 +1,10 @@
 /**
  * `settings` namespace dictionaries: shell chrome plus the shell-owned
- * General section (nav label, skeleton rows). Skeleton-row technical copy
- * (Read only / Schema mode / Code mode and their descriptions) is shared
- * verbatim across locales per the Figma design. Feature-owned rows
- * (Language, Appearance) ship their copy in their own packages.
+ * General section (nav label and ownerless Tool Call skeleton). Technical
+ * mode copy is shared verbatim across locales per the Figma design.
+ * Feature-owned rows ship their copy in their own packages.
  */
 const SHARED = {
-  'permission.value': 'Read only',
   'toolcall.schema.title': 'Schema mode',
   'toolcall.schema.desc': 'Traditional function calling — invoke tools one at a time',
   'toolcall.code.title': 'Code mode',
@@ -20,8 +18,6 @@ export const zh = {
   'title': '设置',
   'close': '关闭',
   'general.nav': '通用设置',
-  'permission.title': '权限',
-  'permission.desc': '选择默认权限模式',
   'toolcall.title': '工具调用',
 } satisfies Record<string, string>
 
@@ -35,7 +31,5 @@ export const en = {
   'title': 'Settings',
   'close': 'Close',
   'general.nav': 'General',
-  'permission.title': 'Permission',
-  'permission.desc': 'Choose default permission mode',
   'toolcall.title': 'Tool Call',
 } satisfies Record<SettingsKey, string>

packages/client/ui-settings-general/tests/apply.spec.ts

@@ -1,12 +1,12 @@
 /** Ownerless-copy registrations: the four seats, the dictionaries, thunked labels, and HMR recovery. */
 import { Context } from 'cordis'
-import { describe, expect, it } from 'vitest'
+import { describe, expect, it, vi } from 'vitest'
 import { resolveSlotLabel } from '@deepseek-ai/dsh-client-ui-slots'
 import { SlotsService } from '@deepseek-ai/dsh-client-runtime/client'
 import { LocaleService } from '@deepseek-ai/dsh-client-locale/client'
 import { apply, inject } from '@deepseek-ai/dsh-client-ui-settings-general/client'
 import { CloseLabel, HeaderContent, TriggerContent } from '../src/client/chrome.tsx'
-import { GeneralSection } from '../src/client/GeneralSection.tsx'
+import { GeneralSection, ToolCallSkeleton } from '../src/client/GeneralSection.tsx'
 
 /** The four seats this plugin fills (slot name → expected component). */
 const SEATS = [
@@ -61,10 +61,16 @@ describe('ui-settings-general apply', () => {
     // The nav label is a locale-following thunk; owners resolve at read time.
     expect(resolveSlotLabel(entry.options.label)).toBe('通用设置')
     expect(before.slots.spec('settings.general.item')).toEqual({ kind: 'list', scope: 'root' })
+    const toolEntry = before.slots.entries('settings.general.item')[0]!
+    expect(toolEntry).toMatchObject({
+      component: ToolCallSkeleton,
+      options: { id: 'tool-call', order: -10 },
+    })
     // Copy rides the standard locale seat: every seat declares the namespace.
     for (const [name] of SEATS) {
       expect(before.slots.entries(name)[0]!.locale).toBe('settings')
     }
+    expect(toolEntry.locale).toBe('settings')
 
     const after = await bench()
     await after.ctx.plugin({ inject: [...inject], apply }).await()
@@ -76,6 +82,9 @@ describe('ui-settings-general apply', () => {
       // The self-inflicted ledger notifications hit the duplicate guard.
       expect(after.slots.entries(name)).toHaveLength(1)
     }
+    await vi.waitFor(() => {
+      expect(after.slots.entries('settings.general.item')[0]!.component).toBe(ToolCallSkeleton)
+    })
   })
 
   it('registers the zh/en settings dictionaries and frees the seats on teardown', async () => {
@@ -124,6 +133,7 @@ describe('ui-settings-general apply', () => {
     for (const [name, component] of SEATS) {
       expect(b.slots.entries(name)[0]!.component).toBe(component)
     }
+    expect(b.slots.entries('settings.general.item')[0]!.component).toBe(ToolCallSkeleton)
     expect(b.slots.spec('settings.general.item')).toEqual({ kind: 'list', scope: 'root' })
     // The recovered registrations still ride the locale path.
     b.locale.setLocale('en')

packages/client/ui-settings-general/tests/components.spec.tsx

@@ -1,8 +1,10 @@
 // @vitest-environment jsdom
 import { afterEach, describe, expect, it, vi } from 'vitest'
 import { cleanup, render, screen } from '@testing-library/react'
-import type { GeneralSectionComponentProps } from '../src/client/GeneralSection.tsx'
-import { GeneralSection } from '../src/client/GeneralSection.tsx'
+import type {
+  GeneralSectionComponentProps, ToolCallSkeletonProps,
+} from '../src/client/GeneralSection.tsx'
+import { GeneralSection, ToolCallSkeleton } from '../src/client/GeneralSection.tsx'
 import { CloseLabel, HeaderContent, TriggerContent } from '../src/client/chrome.tsx'
 import { en } from '../src/client/locales.ts'
 
@@ -10,7 +12,7 @@ afterEach(cleanup)
 
 // The seat's key domain is settings ∪ common; the stub answers from the
 // package dictionary and falls back to the key like the real chain.
-const t: GeneralSectionComponentProps['t'] = key => (en as Record<string, string>)[key] ?? key
+const t: ToolCallSkeletonProps['t'] = key => (en as Record<string, string>)[key] ?? key
 
 // Global standard kit stubs: none of these components consume the hooks.
 const unusedHook = (() => { throw new Error('unused by settings-general components') }) as never
@@ -42,21 +44,21 @@ describe('GeneralSection', () => {
     const renderSlot = vi.fn(
       ((key: string) => <div data-testid={`slot-${key}`} />) as GeneralSectionComponentProps['renderSlot'],
     )
-    const props: GeneralSectionComponentProps = { ...kit, t, renderSlot }
+    const props: GeneralSectionComponentProps = { ...kit, renderSlot }
     const view = render(<GeneralSection {...props} />)
     return { view, renderSlot }
   }
 
-  it('renders the Permission skeleton row with the disabled selector', () => {
-    mount()
-    expect(screen.getByText('Permission')).toBeTruthy()
-    expect(screen.getByText('Choose default permission mode')).toBeTruthy()
-    const selector = screen.getByRole<HTMLButtonElement>('button', { name: /Read only/ })
-    expect(selector.disabled).toBe(true)
+  it('renders the item slot as the section body', () => {
+    const { renderSlot } = mount()
+    expect(renderSlot).toHaveBeenCalledWith('settings.general.item', {})
+    expect(screen.getByTestId('slot-settings.general.item')).toBeTruthy()
   })
+})
 
-  it('renders the Tool Call skeleton cubes with schema pinned selected', () => {
-    mount()
+describe('ToolCallSkeleton', () => {
+  it('renders the mode cubes with schema pinned selected', () => {
+    render(<ToolCallSkeleton {...kit} t={t} />)
     expect(screen.getByText('Tool Call')).toBeTruthy()
     const schema = screen.getByText('Schema mode')
     const code = screen.getByText('Code mode')
@@ -65,10 +67,4 @@ describe('GeneralSection', () => {
     expect(screen.getByText('Traditional function calling — invoke tools one at a time')).toBeTruthy()
     expect(screen.getByText('Chain multiple tools with code — multi-step orchestration')).toBeTruthy()
   })
-
-  it('renders the feature-contributed item slot after the skeleton rows', () => {
-    const { renderSlot } = mount()
-    expect(renderSlot).toHaveBeenCalledWith('settings.general.item', {})
-    expect(screen.getByTestId('slot-settings.general.item')).toBeTruthy()
-  })
 })