fix(telemetry): withhold package.json when cordis.yml is absent

buildTelemetryPayload read the two reported files independently, so a
dsh-sdk command mistakenly run in an arbitrary non-SDK directory (no
cordis.yml, e.g. any unrelated repo) still uploaded that directory's
package.json — dependency names and metadata of a project that never
opted into the SDK toolchain. Gate the manifest on cordis.yml presence:
without the config the directory is not an SDK project and its manifest
is not ours to report. Consent semantics are unchanged.
This commit is contained in:
imccyu
2026-07-18 21:53:47 +08:00
parent 013db6e8f0
commit e674f4c20e
3 changed files with 22 additions and 5 deletions

View File

@@ -47,8 +47,18 @@ describe('buildTelemetryPayload', () => {
expect('packageJsonContent' in payload).toBe(false)
})
it('withholds package.json when cordis.yml is absent (not an SDK project)', async () => {
const dir = await projectDir({ 'package.json': '{ "name": "unrelated-repo" }' })
const payload = await buildTelemetryPayload({ command: 'build', durationMs: 3, success: false, projectDir: dir })
expect('cordisYmlContent' in payload).toBe(false)
expect('packageJsonContent' in payload).toBe(false)
})
it('uses a supplied redactor', async () => {
const dir = await projectDir({ 'package.json': '{ "password": "hunter2" }' })
const dir = await projectDir({
'cordis.yml': '- id: llm\n name: \'@deepseek-ai/dsh-llm-deepseek\'\n',
'package.json': '{ "password": "hunter2" }',
})
const redactor = new SecretRedactor({ placeholder: '<<hidden>>' })
const payload = await buildTelemetryPayload({
command: 'config', durationMs: 5, success: true, projectDir: dir, redactor,