Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(subagent): type the schema-resolved reportDelivery shape

Browse Source 
Config() applies the schemastery default at runtime, but its return type
keeps the input's optional field, so assert the resolved shape at the
seam — keeping the dead fallback branch gone.
This commit is contained in:
Tianyi Cui
2026-08-02 12:39:35 +08:00
parent 902b46b86b
commit df01ed926a
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/client/ui-subagent/tests/conversation-ui.spec.tsx
View File

@@ -69,7 +69,7 @@ function props(
// The zh dictionary is the source of truth for this spec's assertions: // The zh dictionary is the source of truth for this spec's assertions:
// the stub interpolates `{name}` params like the locale service does. // the stub interpolates `{name}` params like the locale service does.
const t = ((key: SubagentKey, params?: Record<string, unknown>): string => { const t = ((key: SubagentKey, params?: Record<string, unknown>): string => {
let text = zh[key] let text: string = zh[key]
for (const [name, value] of Object.entries(params ?? {})) { for (const [name, value] of Object.entries(params ?? {})) {
text = text.replaceAll(`{${name}}`, String(value)) text = text.replaceAll(`{${name}}`, String(value))
} }

5
packages/subagent/tool-subagent-report/src/index.ts
View File

@@ -88,7 +88,10 @@ export function installReportTool(
* @param config - deployment scheduling policy. * @param config - deployment scheduling policy.
*/ */
export function apply(ctx: Context, config: Config = {}): void { export function apply(ctx: Context, config: Config = {}): void {
const { reportDelivery } = Config(config) // Config() applies the schema default ('quiet') at runtime; the schemastery
// return type keeps the input's optional shape, so assert the resolved
// shape here — no runtime fallback exists or is wanted.
const { reportDelivery } = Config(config) as { reportDelivery: SubagentReportDelivery }
ctx.subagents.registerContinuableSetup(childCtx => ctx.subagents.registerContinuableSetup(childCtx =>
installReportTool(childCtx, ctx, reportDelivery)) installReportTool(childCtx, ctx, reportDelivery))
} }