Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(apiproxy): share the workspace-not-found response

Browse Source 
The rename/insertSessionBefore lookups tripped the cross-file clone gate;
one helper owns the error row now.
This commit is contained in:
imccyu
2026-07-26 01:58:53 +08:00
parent 9fc8a616a9
commit d147673dfd
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
packages/host/apiproxy/src/api-proxy.ts
View File

@@ -299,6 +299,15 @@ class SessionCwdConflict extends Error {
/** Host failed before the registry could adopt a name-created directory. */ /** Host failed before the registry could adopt a name-created directory. */
class WorkspaceDirectoryCreationError extends Error {} class WorkspaceDirectoryCreationError extends Error {}
/** Shared workspace-not-found error response of the workspace.* mutation rows. */
function workspaceNotFound<T>(request: RpcRequest<unknown>, workspaceId: string): RpcResponse<T> {
return err(request, {
code: 'workspace-not-found',
message: `workspace "${workspaceId}" not found`,
details: { workspaceId },
})
}
/** Wire projection of one workspace entity (the workspace.* value row). */ /** Wire projection of one workspace entity (the workspace.* value row). */
function workspaceView(workspace: Workspace): WorkspaceView { function workspaceView(workspace: Workspace): WorkspaceView {
return { return {
@@ -684,13 +693,7 @@ export function createApiProxy(ctx: Context, defaults: ApiProxyDefaults): ApiPro
async rename(request) { async rename(request) {
const { payload } = request const { payload } = request
const workspace = ctx.workspace.get(brandWorkspaceId(payload.workspaceId)) const workspace = ctx.workspace.get(brandWorkspaceId(payload.workspaceId))
if (workspace === undefined) { if (workspace === undefined) return workspaceNotFound(request, payload.workspaceId)
return err(request, {
code: 'workspace-not-found',
message: `workspace "${payload.workspaceId}" not found`,
details: { workspaceId: payload.workspaceId },
})
}
const title = payload.title.trim() const title = payload.title.trim()
// Uniqueness AND the same-title no-op both ride the create chain so // Uniqueness AND the same-title no-op both ride the create chain so
// they observe the state left by earlier queued renames — checked // they observe the state left by earlier queued renames — checked
@@ -722,13 +725,7 @@ export function createApiProxy(ctx: Context, defaults: ApiProxyDefaults): ApiPro
async insertSessionBefore(request) { async insertSessionBefore(request) {
const { payload } = request const { payload } = request
const workspace = ctx.workspace.get(brandWorkspaceId(payload.workspaceId)) const workspace = ctx.workspace.get(brandWorkspaceId(payload.workspaceId))
if (workspace === undefined) { if (workspace === undefined) return workspaceNotFound(request, payload.workspaceId)
return err(request, {
code: 'workspace-not-found',
message: `workspace "${payload.workspaceId}" not found`,
details: { workspaceId: payload.workspaceId },
})
}
try { try {
await workspace.insertSessionBefore(payload.sessionId, payload.beforeSessionId) await workspace.insertSessionBefore(payload.sessionId, payload.beforeSessionId)
} catch (error: unknown) { } catch (error: unknown) {