From bfc5a9097d1489fdac38b1c3107b4a9cc9916bbb Mon Sep 17 00:00:00 2001 From: Tianyi Cui <53024+tianyicui@users.noreply.github.com> Date: Sun, 21 Jun 2026 13:08:11 +0800 Subject: [PATCH] fix review findings: soften the last stdout-purity overclaim in the acp-agent module doc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The acp-agent README/RFC overclaim was already softened; this module doc comment still said the footgun is "structurally unreachable from the leaf". A leaf cordis.yml CAN still add a sibling @cordisjs/plugin-logger-console — the app does not prevent it. Reword to the accurate claim: the app gives the default front door no logger entry to misconfigure, and the "never add a stdout logger to an ACP leaf" rule still stands. --- packages/ui/acp-agent/src/index.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/ui/acp-agent/src/index.ts b/packages/ui/acp-agent/src/index.ts index 0ff3609fbb..625467cac2 100644 --- a/packages/ui/acp-agent/src/index.ts +++ b/packages/ui/acp-agent/src/index.ts @@ -9,8 +9,10 @@ * a stray console logger would corrupt the protocol frames (the [stdout-purity * footgun]). This package contains NO console-logger entry, NO `hmr` (the editor * owns the subprocess), and pre-creates NO agents (ACP `session/new` creates - * them on demand) — so the footgun is structurally unreachable from the leaf: - * there is no logger entry to get wrong. + * them on demand) — so the default front door has no logger entry to get wrong. + * (A leaf `cordis.yml` could still add a sibling `@cordisjs/plugin-logger-console`, + * which this app does not prevent — so the rule "never add a stdout logger to an + * ACP leaf" still stands; the app just gives the leaf nothing to misconfigure.) * * The leaf supplies only the swappable backends: the LLM adapter (`llm-deepseek` * for the real model, `llm-replay` for keyless snapshot replay) and the bash