Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(gui): drop the impossible slots-undefined guard in the ui-question plugin

Browse Source 
ClientContext types ctx.slots as always present (inject-declared service);
the unnecessary-condition lint rule rejects the dead guard and its
fail-loud test premise. Load-order failure still surfaces loud through
the undeclared-slot registration path, covered by the remaining case.
This commit is contained in:
imccyu
2026-07-23 19:45:02 +08:00
parent 34f0536cfe
commit afd7eb0dcf
2 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/client/ui-question/src/client/index.ts
View File

@@ -29,7 +29,6 @@ function selectQuestion({ interactions }: ComposerChainProps): QuestionWait | nu
*/ */
export function apply(ctx: ClientContext): void { export function apply(ctx: ClientContext): void {
const slots = ctx.slots const slots = ctx.slots
if (slots === undefined) throw new Error('ui-question: slots service unavailable')
ctx.effect( ctx.effect(
() => slots.register({ name: 'conversation.composer', select: selectQuestion }, QuestionComposer), () => slots.register({ name: 'conversation.composer', select: selectQuestion }, QuestionComposer),
'ui-question: composer chain registration', 'ui-question: composer chain registration',

4
packages/client/ui-question/tests/browser-plugin.spec.ts
View File

@@ -31,10 +31,6 @@ describe('apply', () => {
expect(inject).toEqual(['slots']) expect(inject).toEqual(['slots'])
}) })
it('fails loud when the slots service is missing', () => {
expect(() => { apply(new Context()) }).toThrow(/slots service unavailable/)
})
it('fails loud when no live entry has declared the composer slot', async () => { it('fails loud when no live entry has declared the composer slot', async () => {
const ctx = new Context() const ctx = new Context()
await ctx.plugin(SlotsService).await() await ctx.plugin(SlotsService).await()