From ab94a2f7d6463ba640af5866c4b28908d5dde3b0 Mon Sep 17 00:00:00 2001
From: Turtle <turtle1999@deepseek.com>
Date: Thu, 6 Aug 2026 17:39:43 +0800
Subject: [PATCH] refactor(telemetry): centralize the default mode

---
 docs/config-catalog.md                               |  2 +-
 .../telemetry/session-telemetry-otel/src/index.ts    | 12 ++++--------
 .../session-telemetry-otel/tests/otel.spec.ts        |  4 +++-
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/docs/config-catalog.md b/docs/config-catalog.md
index c386ee4e6b..46766c2640 100644
--- a/docs/config-catalog.md
+++ b/docs/config-catalog.md
@@ -1193,7 +1193,7 @@ export enum TelemetryMode {
 
 Depends on: `BatchLogRecordProcessorOptions` (`@opentelemetry/sdk-logs`) · `OTLPExporterNodeConfigBase` (`@opentelemetry/otlp-exporter-base`)
 
-Source: [`packages/telemetry/session-telemetry-otel/src/index.ts:83`](../packages/telemetry/session-telemetry-otel/src/index.ts)
+Source: [`packages/telemetry/session-telemetry-otel/src/index.ts:79`](../packages/telemetry/session-telemetry-otel/src/index.ts)
 
 ## `@deepseek-ai/dsh-session-title`
 
diff --git a/packages/telemetry/session-telemetry-otel/src/index.ts b/packages/telemetry/session-telemetry-otel/src/index.ts
index f380d97549..36429448c6 100644
--- a/packages/telemetry/session-telemetry-otel/src/index.ts
+++ b/packages/telemetry/session-telemetry-otel/src/index.ts
@@ -46,12 +46,8 @@ export enum TelemetryMode {
   DISABLED = 'DISABLED',
 }
 
-/** Supported session-sharing policies for runtime configuration validation. */
-export const TELEMETRY_MODES = [
-  TelemetryMode.FULL,
-  TelemetryMode.FEEDBACK_ONLY,
-  TelemetryMode.DISABLED,
-] as const
+/** Default session-sharing policy for schema and direct construction. */
+export const DEFAULT_TELEMETRY_MODE = TelemetryMode.FULL
 
 const DISABLED_FEEDBACK_WARNING = 'session telemetry is DISABLED; nothing will be shared and this feedback remains local'
 const NON_CANONICAL_FEEDBACK_WARNING = 'session telemetry ignored a feedback event absent from the canonical session log'
@@ -59,7 +55,7 @@ const DROP_RECORD: TelemetryBackend['emit'] = () => {}
 
 /** Resolve the default and reject unknown runtime values before transport setup. */
 function resolveMode(mode: TelemetryMode | undefined): TelemetryMode {
-  const resolved = mode ?? TelemetryMode.FULL
+  const resolved = mode ?? DEFAULT_TELEMETRY_MODE
   switch (resolved) {
     case TelemetryMode.FULL:
     case TelemetryMode.FEEDBACK_ONLY:
@@ -109,7 +105,7 @@ export interface Config {
  * axiom (and silently drop every field not re-declared).
  */
 export const Config: z<Config> = z.object({
-  mode: z.union(TELEMETRY_MODES).default(TelemetryMode.FULL),
+  mode: z.union(Object.values(TelemetryMode)).default(DEFAULT_TELEMETRY_MODE),
   exporter: z.any(),
   processor: z.any(),
 })
diff --git a/packages/telemetry/session-telemetry-otel/tests/otel.spec.ts b/packages/telemetry/session-telemetry-otel/tests/otel.spec.ts
index f7b3a007c9..f95af8db16 100644
--- a/packages/telemetry/session-telemetry-otel/tests/otel.spec.ts
+++ b/packages/telemetry/session-telemetry-otel/tests/otel.spec.ts
@@ -13,7 +13,7 @@ import { Context } from 'cordis'
 import Loader from '@cordisjs/plugin-loader'
 import { recordFeedback } from '@deepseek-ai/dsh-command-feedback'
 import SessionStore, { SessionId } from '@deepseek-ai/dsh-session'
-import TelemetryOtel, { Config, TelemetryMode } from '../src/index.ts'
+import TelemetryOtel, { Config, DEFAULT_TELEMETRY_MODE, TelemetryMode } from '../src/index.ts'
 
 interface Capture {
   headers: import('node:http').IncomingHttpHeaders
@@ -330,6 +330,8 @@ describe('TelemetryOtel config fails loud', () => {
     expectTypeOf<Config['mode']>().toEqualTypeOf<TelemetryMode | undefined>()
     expectTypeOf<'FULL'>().not.toExtend<TelemetryMode>()
     expectTypeOf<TelemetryMode.FULL>().toExtend<TelemetryMode>()
+    expect(DEFAULT_TELEMETRY_MODE).toBe(TelemetryMode.FULL)
+    expect(Config({}).mode).toBe(DEFAULT_TELEMETRY_MODE)
   })
 
   it.each([