Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(telemetry): report unless telemetry entry is explicitly disabled

Browse Source 
Per ccyu's decision (option A), remove the consent asymmetry in ConsentResolver:
telemetry is OFF only when cordis.yml has a telemetry entry with disabled: true.
A cordis.yml with no telemetry entry now reports (allowWhenEntryAbsent defaults
to true) rather than denying. No cordis.yml, an enabled entry, and DO_NOT_TRACK/CI
are unchanged. Both no-config and absent-entry defaults stay configurable.

Updates the module/README docs and the unit tests (file-present-but-no-entry and
non-object/non-sequence roots now report). Per-file 100% coverage holds.
This commit is contained in:
imccyu
2026-07-17 14:03:39 +08:00
parent fe668a6dfe
commit a66b98d270
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
packages/sdk/telemetry/src/consent-resolver.ts
View File

@@ -1,12 +1,12 @@
/**
* Consent resolution for dsh-sdk telemetry.
*
* Consent is carried by the telemetry plugin's enabled/disabled state in the
* project `cordis.yml`: an enabled entry means opt-in, a `disabled: true` entry
* means opt-out. The resolver PARSES `cordis.yml` — it never boots a Cordis
* application — because several launcher commands (`build`, `create`) never
* boot Cordis at all. `DO_NOT_TRACK` and CI environment signals force a denial
* regardless of file state.
* Telemetry is OFF only when `cordis.yml` contains a telemetry entry that is
* explicitly `disabled`; every other file state reports (no `cordis.yml`, an
* enabled entry, or no telemetry entry at all). The resolver PARSES `cordis.yml`
* — it never boots a Cordis application — because several launcher commands
* (`build`, `create`) never boot Cordis at all. `DO_NOT_TRACK` and CI
* environment signals force a denial regardless of file state.
*
* @module @deepseek-ai/dsh-telemetry/consent-resolver
*/
@@ -56,7 +56,7 @@ export interface ConsentResolverOptions {
honorEnvOptOut?: boolean
/** Consent when `cordis.yml` does not exist yet (first `create`). Defaults to `true` (telemetry is default-on). */
allowWhenNoConfig?: boolean
/** Consent when `cordis.yml` exists but has no telemetry entry. Defaults to `false`. */
/** Consent when `cordis.yml` exists but has no telemetry entry. Defaults to `true` (report unless a present entry is disabled). */
allowWhenEntryAbsent?: boolean
}
@@ -94,7 +94,7 @@ export class ConsentResolver {
this.#env = options.env ?? process.env
this.#honorEnvOptOut = options.honorEnvOptOut ?? true
this.#allowWhenNoConfig = options.allowWhenNoConfig ?? true
this.#allowWhenEntryAbsent = options.allowWhenEntryAbsent ?? false
this.#allowWhenEntryAbsent = options.allowWhenEntryAbsent ?? true
}
/**