feat(web): add workspace-aware session flow

2026-07-25 16:04:48 +08:00
parent 755e2a8c51
commit 9eb9c70a8a
170 changed files with 7573 additions and 3006 deletions
--- a/packages/host/apiproxy/tests/api-proxy-cold.spec.ts
+++ b/packages/host/apiproxy/tests/api-proxy-cold.spec.ts
@@ -55,7 +55,7 @@ describe('sessions.list cold merge', () => {
        return undefined
      },
    })
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })

    const response = await api.sessions.list(request({}))
    expect(response.result.ok).toBe(true)
@@ -79,7 +79,7 @@ describe('degenerate composition (no persistence, no factory)', () => {
    await ctx.plugin(SessionStore)
    await ctx.plugin(AgentRegistry)
    await ctx.plugin(UserInteractionService)
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })

    const listed = await api.sessions.list(request({}))
    expect(listed.result.ok).toBe(true)
--- a/packages/host/apiproxy/tests/api-proxy-view.spec.ts
+++ b/packages/host/apiproxy/tests/api-proxy-view.spec.ts
@@ -76,7 +76,7 @@ async function collect(iterable: AsyncIterable<RpcRequest<MuxFrame>>, count: num
 describe('mux live view computation', () => {
  it('attaches the three standard card views, omits view without a presenter, soft-falls on throw', async () => {
    const { ctx } = await harness()
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })
    const abort = new AbortController()
    const stream = api.events.mux({ rpcId: RpcId('t-mux'), payload: {} }, abort.signal)
    const collected = collect(stream, 9, abort)
@@ -122,7 +122,7 @@ describe('mux live view computation', () => {

  it('serves history entries with call/result views, backscan pairing, and soft-falls', async () => {
    const { ctx } = await harness()
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })
    const session = ctx.sessions.create()
    // history resolves the agent first; a live structural stub is enough (only
    // .session is read on this path).
@@ -156,7 +156,7 @@ describe('mux live view computation', () => {

  it('drops a disposed session from the live open-call table (result after dispose gets no view)', async () => {
    const { ctx } = await harness()
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })
    const abort = new AbortController()
    const stream = api.events.mux({ rpcId: RpcId('t-mux3'), payload: {} }, abort.signal)

@@ -177,7 +177,7 @@ describe('mux live view computation', () => {

  it('pairs a result after turn/end via the in-memory backscan fallback', async () => {
    const { ctx } = await harness()
-    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp' })
+    const api = createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' })
    const abort = new AbortController()
    const stream = api.events.mux({ rpcId: RpcId('t-mux2'), payload: {} }, abort.signal)
    const collected = collect(stream, 4, abort)
--- a/packages/host/apiproxy/tests/api-proxy-workspace.spec.ts
+++ b/packages/host/apiproxy/tests/api-proxy-workspace.spec.ts
@@ -0,0 +1,246 @@
+import { existsSync, mkdirSync, mkdtempSync, realpathSync } from 'node:fs'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+import { describe, expect, it, vi } from 'vitest'
+import { Context } from 'cordis'
+import AgentRegistry, { AgentMessageId } from '@deepseek-ai/dsh-agent'
+import type { Agent, AgentFactory } from '@deepseek-ai/dsh-agent'
+import SessionStore, { SessionId } from '@deepseek-ai/dsh-session'
+import type { Session } from '@deepseek-ai/dsh-session'
+import Storage from '@deepseek-ai/dsh-storage'
+import { DomainFacility } from '@deepseek-ai/dsh-storage-domain'
+import UserInteractionService from '@deepseek-ai/dsh-user-interaction'
+import WorkspaceRegistry from '@deepseek-ai/dsh-workspace'
+import type { HostFrame, WorkspaceId } from '@deepseek-ai/dsh-host-apiproxy/api'
+import type { RpcRequest, RpcResponse } from '@deepseek-ai/dsh-host-apiproxy/api/rpc'
+import { RpcId } from '@deepseek-ai/dsh-host-apiproxy/api/rpc'
+import { createApiProxy } from '@deepseek-ai/dsh-host-apiproxy'
+import { MemoryStorageBackend } from '../../../storage/storage-domain/tests/helpers/memory-backend.ts'
+
+let nextRpc = 1
+
+function request<P>(payload: P): RpcRequest<P> {
+  return { rpcId: RpcId(`workspace-${String(nextRpc++)}`), payload }
+}
+
+function expectOk<T>(response: RpcResponse<T>): T {
+  expect(response.result.ok).toBe(true)
+  if (!response.result.ok) throw new Error('unreachable')
+  return response.result.value
+}
+
+async function nextHostFrame(
+  stream: AsyncIterator<RpcRequest<HostFrame>>,
+): Promise<RpcRequest<HostFrame>> {
+  const next = await stream.next()
+  if (next.done === true) throw new Error('Host stream ended before the expected increment')
+  return next.value
+}
+
+function stubAgent(session: Session): Agent {
+  return {
+    id: session.id,
+    options: {},
+    session,
+    status: 'idle',
+    ctx: new Context(),
+    followup: () => AgentMessageId('stub'),
+    queue: () => AgentMessageId('stub'),
+    steer: () => AgentMessageId('stub'),
+    inject: () => AgentMessageId('stub'),
+    send: () => AgentMessageId('stub'),
+    cancel() {},
+    whenIdle: () => Promise.resolve(),
+  }
+}
+
+/** Compose the API over real Session, Agent, Storage, Domain, and Workspace services. */
+async function harness(
+  workspaceRoot = realpathSync(mkdtempSync(join(tmpdir(), 'dsh-apiproxy-workspace-'))),
+) {
+  const ctx = new Context()
+  await ctx.plugin(SessionStore)
+  await ctx.plugin(AgentRegistry)
+  await ctx.plugin(UserInteractionService)
+  await ctx.plugin(Storage)
+  ctx.storage.backend.register('memory', new MemoryStorageBackend())
+  const storageDomain = new DomainFacility(ctx, { backend: 'memory', routes: {} })
+  ctx.storage.mount('domain', storageDomain)
+  ctx.provide('storageDomain', storageDomain)
+  ctx.provide('sessionPersistence', { list: () => Promise.resolve([]) } as never)
+  await ctx.plugin(WorkspaceRegistry)
+
+  const factory: AgentFactory = {
+    async createAgent(_ownerCtx, options) {
+      const session = ctx.sessions.create(
+        options.sessionId,
+        options.meta === undefined ? {} : { meta: options.meta },
+      )
+      const agent = stubAgent(session)
+      const unregister = ctx.agents.register(agent)
+      return {
+        agent,
+        dispose: () => {
+          unregister()
+          return Promise.resolve()
+        },
+      }
+    },
+    async resume() {
+      throw new Error('test harness has no persisted sessions')
+    },
+  }
+  ctx.agents.setFactory(factory)
+  const api = createApiProxy(ctx, {
+    provider: 'test',
+    model: 'test-model',
+    cwd: workspaceRoot,
+    workspaceRoot,
+  })
+  return { api, ctx, storageDomain, workspaceRoot }
+}
+
+describe('workspace.create', () => {
+  it('serializes concurrent names and rejects the duplicate', async () => {
+    const { api, workspaceRoot } = await harness()
+    const responses = await Promise.all([
+      api.workspace.create(request({ name: 'alpha' })),
+      api.workspace.create(request({ name: 'alpha' })),
+    ])
+    const created = responses.find(response => response.result.ok)
+    const duplicate = responses.find(response => !response.result.ok)
+
+    expect(created).toBeDefined()
+    expect(expectOk(created!)).toMatchObject({
+      created: true,
+      workspace: { path: join(workspaceRoot, 'alpha'), title: 'alpha' },
+    })
+    expect(duplicate?.result).toMatchObject({
+      ok: false,
+      error: { code: 'workspace-name-conflict', details: { name: 'alpha' } },
+    })
+    expect(existsSync(join(workspaceRoot, 'alpha'))).toBe(true)
+  })
+
+  it('adopts only existing directories and rejects unsafe names', async () => {
+    const { api, workspaceRoot } = await harness()
+    const existing = join(workspaceRoot, 'existing')
+    mkdirSync(existing)
+    const first = expectOk(await api.workspace.create(request({ path: existing })))
+    const repeated = expectOk(await api.workspace.create(request({ path: existing })))
+    expect(first).toMatchObject({ created: true, workspace: { path: existing, title: 'existing' } })
+    expect(repeated).toMatchObject({ created: false, workspace: { workspaceId: first.workspace.workspaceId } })
+
+    const missing = join(workspaceRoot, 'missing')
+    const missingResult = await api.workspace.create(request({ path: missing }))
+    expect(missingResult.result).toMatchObject({ ok: false, error: { code: 'workspace-invalid-path' } })
+    expect(existsSync(missing)).toBe(false)
+
+    for (const name of ['', '.', '..', 'a/b', 'a\\b']) {
+      const invalid = await api.workspace.create(request({ name }))
+      expect(invalid.result).toMatchObject({ ok: false, error: { code: 'workspace-invalid-path' } })
+    }
+  })
+})
+
+describe('session creation and Workspace membership', () => {
+  it('attaches a preallocated idempotent session while cwd-only sessions stay ungrouped', async () => {
+    const { api, ctx } = await harness()
+    const workspace = expectOk(await api.workspace.create(request({ name: 'project' }))).workspace
+    const sessionId = SessionId('session-workspace-preallocated')
+
+    expectOk(await api.sessions.create(request({ workspaceId: workspace.workspaceId, sessionId })))
+    expectOk(await api.sessions.create(request({ workspaceId: workspace.workspaceId, sessionId })))
+    expect(expectOk(await api.workspace.list(request({}))).items[0]?.sessionIds).toEqual([sessionId])
+    expect(ctx.agents.list().filter(agent => agent.id === sessionId)).toHaveLength(1)
+
+    const ungrouped = SessionId('session-cwd-only')
+    expectOk(await api.sessions.create(request({ cwd: workspace.path, sessionId: ungrouped })))
+    expect(expectOk(await api.workspace.list(request({}))).items[0]?.sessionIds).toEqual([sessionId])
+    expect(expectOk(await api.sessions.list(request({}))).items.map(item => item.sessionId)).toContain(ungrouped)
+
+    const conflict = await api.sessions.create(request({ cwd: join(workspace.path, 'other'), sessionId }))
+    expect(conflict.result).toMatchObject({
+      ok: false,
+      error: { code: 'session-conflict', details: { sessionId, existingCwd: workspace.path } },
+    })
+    const missing = await api.sessions.create(request({
+      workspaceId: 'missing-workspace' as WorkspaceId,
+      sessionId: SessionId('session-missing-workspace'),
+    }))
+    expect(missing.result).toMatchObject({ ok: false, error: { code: 'workspace-not-found' } })
+  })
+
+  it('retains a published session when attachment fails and repairs it on retry', async () => {
+    const { api, ctx } = await harness()
+    const created = expectOk(await api.workspace.create(request({ name: 'project' }))).workspace
+    const workspace = ctx.workspace.list()[0]
+    if (workspace === undefined) throw new Error('workspace missing from registry')
+    vi.spyOn(workspace, 'attachSession').mockRejectedValueOnce(new Error('simulated write failure'))
+    const sessionId = SessionId('session-attach-retry')
+
+    const failed = await api.sessions.create(request({ workspaceId: created.workspaceId, sessionId }))
+    expect(failed.result).toMatchObject({
+      ok: false,
+      error: { code: 'workspace-attach-failed', details: { sessionId, workspaceId: created.workspaceId } },
+    })
+    expect(ctx.agents.get(sessionId)).toBeDefined()
+
+    expectOk(await api.sessions.create(request({ workspaceId: created.workspaceId, sessionId })))
+    expect(expectOk(await api.workspace.list(request({}))).items[0]?.sessionIds).toEqual([sessionId])
+  })
+})
+
+describe('Host Workspace increments', () => {
+  it('streams committed Workspace and Session increments after empty baselines', async () => {
+    const { api } = await harness()
+    expect(expectOk(await api.workspace.list(request({}))).items).toEqual([])
+    expect(expectOk(await api.sessions.list(request({}))).items).toEqual([])
+
+    const abort = new AbortController()
+    const stream: AsyncIterator<RpcRequest<HostFrame>> =
+      api.events.host(request({}), abort.signal)[Symbol.asyncIterator]()
+    const workspaceIncrement = nextHostFrame(stream)
+    const workspace = expectOk(await api.workspace.create(request({ name: 'project' }))).workspace
+    expect(await workspaceIncrement).toMatchObject({
+      payload: { type: 'host/workspace-changed', workspace: { workspaceId: workspace.workspaceId } },
+    })
+
+    const sessionId = SessionId('session-streamed-workspace')
+    const pending = nextHostFrame(stream)
+    expectOk(await api.sessions.create(request({ workspaceId: workspace.workspaceId, sessionId })))
+    const increments: HostFrame[] = []
+    increments.push((await pending).payload)
+    while (increments.length < 2) {
+      const next = await stream.next()
+      if (next.done === true) throw new Error('Host stream ended before both increments')
+      increments.push(next.value.payload)
+    }
+    expect(increments.find(increment => increment.type === 'host/session-added')).toMatchObject({
+      type: 'host/session-added', sessionId, cwd: workspace.path,
+    })
+    const workspaceChanged = increments.find(
+      (increment): increment is Extract<HostFrame, { type: 'host/workspace-changed' }> =>
+        increment.type === 'host/workspace-changed',
+    )
+    expect(workspaceChanged?.workspace.sessionIds).toEqual([sessionId])
+    abort.abort()
+  })
+
+  it('does not publish a Workspace whose registry-order commit fails', async () => {
+    const { api, storageDomain } = await harness()
+    const domain = storageDomain.get('workspace')
+    if (domain === undefined) throw new Error('workspace domain is not open')
+    vi.spyOn(domain.global, 'set').mockRejectedValueOnce(new Error('simulated registry order failure'))
+    const abort = new AbortController()
+    const stream: AsyncIterator<RpcRequest<HostFrame>> =
+      api.events.host(request({}), abort.signal)[Symbol.asyncIterator]()
+    const next = stream.next()
+
+    const failed = await api.workspace.create(request({ name: 'ghost' }))
+    expect(failed.result.ok).toBe(false)
+    expect(expectOk(await api.workspace.list(request({}))).items).toEqual([])
+    abort.abort()
+    expect(await next).toMatchObject({ done: true })
+  })
+})
--- a/packages/host/apiproxy/tests/client-handler.spec.ts
+++ b/packages/host/apiproxy/tests/client-handler.spec.ts
@@ -34,6 +34,10 @@ function scriptedApi(overrides: {
      ...overrides.sessions,
    },
    host: { describe: r => ok(r, { version: '0-test', cwd: '/t', attachedSessions: 0 }), ...overrides.host },
+    workspace: {
+      list: r => ok(r, { items: [] }),
+      create: r => ok(r, { workspace: { workspaceId: 'w1' as never, path: '/t', title: 't', sessionIds: [], createdAt: '0', updatedAt: '0' }, created: true }),
+    },
    events: { mux: () => empty<MuxFrame>(), host: () => empty<HostFrame>(), ...overrides.events },
    respond: overrides.respond ?? (() => Promise.resolve({ accepted: false as const, reason: 'not-pending' as const })),
  }
@@ -190,6 +194,23 @@ describe('unary round trip', () => {
  })
 })

+describe('workspace domain round trip', () => {
+  it('routes both workspace methods through their handler rows and value schemas', async () => {
+    const c = client(scriptedApi())
+    const list = await c.workspace.list({})
+    expect(list.result).toEqual({ ok: true, value: { items: [] } })
+    const created = await c.workspace.create({ path: '/t' })
+    expect(created.result.ok).toBe(true)
+    if (created.result.ok) expect(created.result.value.created).toBe(true)
+  })
+
+  it('rejects a create payload violating the exactly-one refine at the handler', async () => {
+    const response = await client(scriptedApi()).workspace.create({})
+    expect(response.result.ok).toBe(false)
+    if (!response.result.ok) expect(response.result.error.code).toBe('bad-request')
+  })
+})
+
 describe('SSE stream path', () => {
  it('yields frames in order and skips the comment preamble', async () => {
    const frames: MuxFrame[] = [
--- a/packages/host/apiproxy/tests/fetch-carrier.spec.ts
+++ b/packages/host/apiproxy/tests/fetch-carrier.spec.ts
@@ -42,6 +42,17 @@ function fakeApi(overrides: Partial<{ muxFrames: MuxFrame[]; hostFrames: HostFra
        return { rpcId: request.rpcId, result: { ok: true, value: { version: 'v', cwd: '/w', attachedSessions: 0 } } }
      },
    },
+    workspace: {
+      async list(request) {
+        return { rpcId: request.rpcId, result: { ok: true, value: { items: [] } } }
+      },
+      async create(request) {
+        return {
+          rpcId: request.rpcId,
+          result: { ok: true, value: { workspace: { workspaceId: 'w1' as never, path: '/w', title: 'w', sessionIds: [], createdAt: 't', updatedAt: 't' }, created: true } },
+        }
+      },
+    },
    events: {
      mux: (_request, signal) => stream(muxFrames, signal),
      host: (_request, signal) => stream(hostFrames, signal),
--- a/packages/host/apiproxy/tests/rpc-schemas.spec.ts
+++ b/packages/host/apiproxy/tests/rpc-schemas.spec.ts
@@ -12,6 +12,10 @@ import {
  sessionPromptValueSchema, sessionSummarySchema,
 } from '../src/api/sessions.schema.ts'
 import { hostDescribeRequestSchema, hostDescribeValueSchema } from '../src/api/host.schema.ts'
+import {
+  workspaceCreateRequestSchema, workspaceCreateValueSchema, workspaceIdSchema, workspaceListRequestSchema,
+  workspaceListValueSchema, workspaceViewSchema,
+} from '../src/api/workspace.schema.ts'
 import { hostFrameSchema, muxFrameSchema, askUserQuestionItemSchema } from '../src/api/events.schema.ts'
 import { approvalRequestIdSchema, approvalResponsePayloadSchema } from '../src/api/approvals.schema.ts'
 import { askUserQuestionAnswerSchema, questionResponsePayloadSchema } from '../src/api/questions.schema.ts'
@@ -31,6 +35,11 @@ describe('rpcErrorSchema', () => {
    expect(rpcErrorSchema.parse({ code: 'bad-request', message: 'm', details: { issues: [] } }).code).toBe('bad-request')
    expect(rpcErrorSchema.parse({ code: 'cancelled', message: 'm', details: {} }).code).toBe('cancelled')
    expect(rpcErrorSchema.parse({ code: 'session-not-found', message: 'm', details: { sessionId: 's' } }).code).toBe('session-not-found')
+    expect(rpcErrorSchema.parse({ code: 'session-conflict', message: 'm', details: { sessionId: 's', requestedCwd: '/a', existingCwd: '/b' } }).code).toBe('session-conflict')
+    expect(rpcErrorSchema.parse({ code: 'workspace-attach-failed', message: 'm', details: { sessionId: 's', workspaceId: 'w' } }).code).toBe('workspace-attach-failed')
+    expect(rpcErrorSchema.parse({ code: 'workspace-not-found', message: 'm', details: { workspaceId: 'w' } }).code).toBe('workspace-not-found')
+    expect(rpcErrorSchema.parse({ code: 'workspace-invalid-path', message: 'm', details: { path: '/x' } }).code).toBe('workspace-invalid-path')
+    expect(rpcErrorSchema.parse({ code: 'workspace-name-conflict', message: 'm', details: { name: 'x' } }).code).toBe('workspace-name-conflict')
    expect(rpcErrorSchema.parse({ code: 'agent-busy', message: 'm', details: { reason: 'r' } }).code).toBe('agent-busy')
    expect(rpcErrorSchema.parse({ code: 'internal', message: 'm', details: {} }).code).toBe('internal')
  })
@@ -96,6 +105,9 @@ describe('sessions domain schemas', () => {
    expect(sessionListRequestSchema.parse({ cursor: 'c' }).cursor).toBe('c')
    expect(sessionListValueSchema.parse({ items: [] }).items).toEqual([])
    expect(sessionCreateRequestSchema.parse({ cwd: '/w' }).cwd).toBe('/w')
+    // The refine's both-sides branch: workspaceId alone passes, workspaceId+cwd rejects.
+    expect(sessionCreateRequestSchema.parse({ workspaceId: 'w1', sessionId: 's1' }).sessionId).toBe('s1')
+    expect(() => sessionCreateRequestSchema.parse({ workspaceId: 'w1', cwd: '/w' })).toThrow(/not both/)
    expect(sessionCreateValueSchema.parse({ sessionId: 's1' }).sessionId).toBe('s1')
    expect(sessionHistoryRequestSchema.parse({ sessionId: 's1', beforeSeq: 3, maxMessages: 5 }).beforeSeq).toBe(3)
    expect(() => sessionHistoryRequestSchema.parse({ sessionId: 's1', maxMessages: 0 })).toThrow()
@@ -119,6 +131,31 @@ describe('host domain schemas', () => {
  })
 })

+describe('workspace domain schemas', () => {
+  const view = {
+    workspaceId: 'w1', path: '/p', title: 'p', sessionIds: ['s1'],
+    createdAt: '2026-07-25T00:00:00.000Z', updatedAt: '2026-07-25T00:00:00.000Z',
+  }
+
+  it('validates ids, the view row, and list request/value', () => {
+    expect(workspaceIdSchema.parse('w1')).toBe('w1')
+    expect(() => workspaceIdSchema.parse('')).toThrow()
+    expect(workspaceViewSchema.parse(view).sessionIds).toEqual(['s1'])
+    expect(() => workspaceViewSchema.parse({ ...view, sessionIds: 's1' })).toThrow()
+    expect(workspaceListRequestSchema.parse({})).toEqual({})
+    expect(workspaceListValueSchema.parse({ items: [view] }).items).toHaveLength(1)
+  })
+
+  it('create requires exactly one of path/name (both refine arms)', () => {
+    expect(workspaceCreateRequestSchema.parse({ path: '/p' }).path).toBe('/p')
+    expect(workspaceCreateRequestSchema.parse({ name: 'n' }).name).toBe('n')
+    expect(() => workspaceCreateRequestSchema.parse({})).toThrow(/exactly one/)
+    expect(() => workspaceCreateRequestSchema.parse({ path: '/p', name: 'n' })).toThrow(/exactly one/)
+    expect(workspaceCreateValueSchema.parse({ workspace: view, created: false }).created).toBe(false)
+  })
+
+})
+
 describe('events frame schemas', () => {
  it('accepts every mux frame branch', () => {
    const frames = [