Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): preserve watcher race lint annotations

Browse Source
This commit is contained in:
Tianyi Cui
2026-08-09 14:21:52 +08:00
parent d6a115ec4d
commit 8efaf10f4f
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
packages/skill/skill-local/src/index.ts
View File

@@ -397,6 +397,7 @@ class SkillWatchManager {
const current = await resolveRootWatchMode(state.root.path, this.config.followSymlinks) const current = await resolveRootWatchMode(state.root.path, this.config.followSymlinks)
// A child unlink can publish an empty catalog before root unlinkDir arrives. // A child unlink can publish an empty catalog before root unlinkDir arrives.
// Discovery therefore revalidates the retained handle independently. // Discovery therefore revalidates the retained handle independently.
// oxlint-disable-next-line typescript/no-unnecessary-condition -- watcher callbacks can mark unhealthy while the probe awaits
if (!state.unhealthy && sameWatchMode(watcher.mode, current)) return if (!state.unhealthy && sameWatchMode(watcher.mode, current)) return
} }
await this.replaceWatcher(state) await this.replaceWatcher(state)
@@ -413,6 +414,7 @@ class SkillWatchManager {
/* v8 ignore next -- The loop returns no handle only when teardown wins between awaited probes. */ /* v8 ignore next -- The loop returns no handle only when teardown wins between awaited probes. */
if (watcher === undefined) return if (watcher === undefined) return
/* v8 ignore start -- Post-open teardown is timing-dependent; the disposal race has an explicit integration test. */ /* v8 ignore start -- Post-open teardown is timing-dependent; the disposal race has an explicit integration test. */
// oxlint-disable-next-line typescript/no-unnecessary-condition -- teardown can race awaited watcher startup
if (this.closing || state.owners.size === 0) { if (this.closing || state.owners.size === 0) {
await this.closeWatcher(watcher) await this.closeWatcher(watcher)
return return
@@ -421,6 +423,7 @@ class SkillWatchManager {
state.watcher = watcher state.watcher = watcher
state.unhealthy = false state.unhealthy = false
} catch (error) { } catch (error) {
// oxlint-disable-next-line typescript/no-unnecessary-condition -- teardown can race awaited watcher startup
if (!this.closing) { if (!this.closing) {
state.unhealthy = true state.unhealthy = true
this.ctx.logger.warn(`skill-local: failed to watch ${state.root.path}: ${errorMessage(error)}`) this.ctx.logger.warn(`skill-local: failed to watch ${state.root.path}: ${errorMessage(error)}`)