Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(client): inject slot declaration lifetimes

Browse Source
This commit is contained in:
imccyu
2026-08-05 23:38:29 +08:00
parent bb53e25ed0
commit 86965b053c
100 changed files with 1065 additions and 837 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/client/ui-slash/src/client/index.ts
View File

@@ -55,14 +55,10 @@ export const inject = ['sessions', 'locale']
export function apply(ctx: ClientContext): void {
ctx.plugin(SlashService)
ctx.effect(() => ctx.locale.register(MENU_NS, { zh, en }), 'ui-slash: menu dictionaries')
// Conditional mount: 'conversation.input.overlay' is declared by the
// conversation composer entry, and the conversation service is mounted
// after that declaration lands on the ledger — its presence is the
// registration-safe signal (same seam as toolview registrants).
ctx.inject(['slots', 'conversation', 'slash', 'sessions'], (scope: ClientContext) => {
ctx.inject(['slots', 'slash', 'sessions'], (scope: ClientContext) => {
const slash = scope.slash
const sessions = scope.sessions
scope.effect(() => scope.slots.register({
scope.slots.inject('conversation.input.overlay', () => scope.slots.register({
name: 'conversation.input.overlay',
id: 'slash-menu',
order: 0,
@@ -79,6 +75,6 @@ export function apply(ctx: ClientContext): void {
onDismiss: () => { controller.dismiss() },
}
},
}, MenuView), 'ui-slash: MenuView overlay registration')
}, MenuView))
})
}

18
packages/client/ui-slash/tests/apply.spec.ts
View File

@@ -1,12 +1,11 @@
/**
* apply wiring on a real cordis Context + SlotsService: SlashService mounts
* as ctx.slash once its sessions dependency is up; the MenuView overlay
* registration waits on the conversation seam (ctx.inject scope), lands once
* the declarer is up, resolves the per-session controller from the slot's
* registration follows the slot declaration, resolves the per-session controller from the slot's
* sessionId, and unregisters on fiber teardown.
*/
import { Context } from 'cordis'
import { describe, expect, it, vi } from 'vitest'
import { describe, expect, it } from 'vitest'
import { LocaleService } from '@deepseek-ai/dsh-client-locale/client'
import { usePinnedBrowserLanguages } from '@deepseek-ai/dsh-client-test-runtime'
import { createScope, scopeOf, SlotsService } from '@deepseek-ai/dsh-client-runtime/client'
@@ -25,8 +24,8 @@ async function bench() {
await ctx.plugin(SlotsService).await()
const slots = ctx.get('slots') as SlotsService
// Stand-in for the ui-conversation composer entry: declare the overlay
// slot, then provide the conversation service (declaration precedes the
// service exactly as the real apply orders them).
// slot without providing ConversationService, which is not its lifecycle
// signal.
slots.register(
{ name: 'root', children: { 'conversation.input.overlay': { kind: 'list', scope: 'session' } } } as never,
() => null,
@@ -67,11 +66,7 @@ describe('apply', () => {
it('registers MenuView into the overlay and resolves the per-session controller by slot sessionId', async () => {
const { ctx, slots } = await bench()
await ctx.plugin({ inject: [...inject], apply }).await()
expect(slots.entries('conversation.input.overlay')).toHaveLength(0)
ctx.provide('conversation', {})
// The inject scope activates asynchronously on the service arrival.
await vi.waitFor(() => { expect(slots.entries('conversation.input.overlay')).toHaveLength(1) })
expect(slots.entries('conversation.input.overlay')).toHaveLength(1)
const entries = slots.entries('conversation.input.overlay')
expect(entries[0]!.options.id).toBe('slash-menu')
// Copy rides the standard locale seat, not the business face.
@@ -100,8 +95,7 @@ describe('apply', () => {
const { ctx, slots } = await bench()
const fiber = ctx.plugin({ inject: [...inject], apply })
await fiber.await()
ctx.provide('conversation', {})
await vi.waitFor(() => { expect(slots.entries('conversation.input.overlay')).toHaveLength(1) })
expect(slots.entries('conversation.input.overlay')).toHaveLength(1)
await fiber.dispose()
expect(slots.entries('conversation.input.overlay')).toHaveLength(0)