Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(tool-bash): state ownership tests as current fact (review)

Browse Source 
Two ownership tests narrated the change's history — "the old design fenced by
Agent object identity", "closing the old XXX(tool-bash-owner-hmr) gap". Reword
to state the current contract (ownership fences by session.header.id; the token
lives on the executor task, so a tool-bash reload preserves it) without
referencing the prior design. Per the repo doc-current-state convention.
This commit is contained in:
Tianyi Cui
2026-06-20 13:52:02 +08:00
parent 90a19f072d
commit 8597cc2c58
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/tool-bash/tests/tools.spec.ts
View File

@@ -490,10 +490,10 @@ describe('background task ownership (cross-session isolation)', () => {
expect(text(killByA)).toBe(`killed background task ${id}`) expect(text(killByA)).toBe(`killed background task ${id}`)
}) })
it('a DIFFERENT Agent object with the SAME session token may access the task (identity no longer matters)', async () => { it('a DIFFERENT Agent object with the SAME session token may access the task (ownership is by token, not object identity)', async () => {
// The old design fenced by Agent object identity; the token design fences by // Ownership fences by session.header.id, NOT Agent object identity. Two
// session.header.id. Two distinct Agent objects sharing one session token // distinct Agent objects sharing one session token (e.g. an agent re-created
// (e.g. an agent re-created on the same session) are now the SAME owner. // on the same session) are the SAME owner.
const ctx = await setup() const ctx = await setup()
const a1 = fakeAgent('sess-shared') const a1 = fakeAgent('sess-shared')
const a2 = fakeAgent('sess-shared') // distinct object, same token const a2 = fakeAgent('sess-shared') // distinct object, same token
@@ -546,10 +546,9 @@ describe('background task ownership (cross-session isolation)', () => {
it('ownership SURVIVES an independent tool-bash HMR reload (token lives on the executor)', async () => { it('ownership SURVIVES an independent tool-bash HMR reload (token lives on the executor)', async () => {
// The owner token lives on the TASK inside the executor (dsh-bash fiber), NOT // The owner token lives on the TASK inside the executor (dsh-bash fiber), NOT
// in a tool-bash plugin-local map. So reloading ONLY tool-bash (executor + // in a tool-bash plugin-local map. So reloading ONLY tool-bash (executor +
// task survive) preserves ownership — closing the old XXX(tool-bash-owner-hmr) // task survive) preserves ownership. This is the regression guard: a
// gap where the fresh map orphaned pre-reload tasks. This is the regression // plugin-local map would make B accessible after reload, and this test would
// guard: an accidental return to a plugin-local map would make B accessible // catch it.
// after reload, and this test would catch it.
const ctx = new Context() const ctx = new Context()
await ctx.plugin(SystemPrompt) await ctx.plugin(SystemPrompt)
await ctx.plugin(ToolRegistry) await ctx.plugin(ToolRegistry)