Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(agent-loop): tighten wake-latch comments

Browse Source
This commit is contained in:
_Kerman
2026-08-07 16:25:23 +08:00
committed by Tianyi Cui
parent df30c62e2b
commit 853f929704
1 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
packages/core/agent-loop/src/agent.ts
View File

@@ -112,8 +112,7 @@ export class ReactLoopAgent implements Agent {
send(message: UserMessage, target: InboxTarget, wakeup: boolean): void { send(message: UserMessage, target: InboxTarget, wakeup: boolean): void {
// Waking input cannot join an aborted activity, so it starts the next turn. // Waking input cannot join an aborted activity, so it starts the next turn.
// The classification is captured BEFORE the insertion: a reentrant cancel // Captured before the insertion so a reentrant cancel from a splice observer cannot reclassify it.
// from a synchronous splice observer must not reclassify this wake.
const wakingAfterAbort = wakeup && this.phase.kind !== 'idle' && this.phase.abort.signal.aborted const wakingAfterAbort = wakeup && this.phase.kind !== 'idle' && this.phase.abort.signal.aborted
const resolvedTarget = wakingAfterAbort ? 'next-turn' : target const resolvedTarget = wakingAfterAbort ? 'next-turn' : target
this.inbox.splice(resolvedTarget, Infinity, 0, [message]) this.inbox.splice(resolvedTarget, Infinity, 0, [message])
@@ -165,20 +164,16 @@ export class ReactLoopAgent implements Agent {
/** /**
* Start one driver, or latch its wake behind maintenance or an aborted * Start one driver, or latch its wake behind maintenance or an aborted
* activity. A wake sent while idle always opens its turn boundary, even * activity. A wake sent while idle always opens its turn boundary, even
* when its message is cleared before the driver claims; only a latched * when its message was cleared; only a latched replay is suppressed when
* replay is suppressed when the queue no longer holds the wake. * the queue no longer holds the wake.
* @param wakeAfterAbort - the send-time classification from {@link send}: * @param wakeAfterAbort - the {@link send} classification, captured before
* the wake landed after the abort fired. Captured before the inbox * the inbox insertion so a reentrant cancel cannot reclassify it.
* insertion so a reentrant cancel cannot reclassify it.
*/ */
private wakeDriver(wakeAfterAbort = false): void { private wakeDriver(wakeAfterAbort = false): void {
if (this.phase.kind !== 'idle') { if (this.phase.kind !== 'idle') {
// The current activity cannot deliver this wake: a maintenance task // Maintenance and aborted drivers cannot deliver the wake: latch it for
// never reads the queue, and an aborted activity converges without // replay at convergence. Live drivers claim queued work themselves;
// restarting — both latch for the exiting activity to replay. A live // disposal never latches, so teardown waits on no model turn.
// driver claims queued work itself, so it needs no latch. A disposal
// cancel never latches: replaying would make `whenIdle()` wait on a
// full model turn over a session being torn down.
const reason = this.phase.abort.signal.reason as AgentCancelCause | undefined const reason = this.phase.abort.signal.reason as AgentCancelCause | undefined
if (reason?.kind !== 'disposed' && (this.phase.kind === 'maintenance' || wakeAfterAbort)) { if (reason?.kind !== 'disposed' && (this.phase.kind === 'maintenance' || wakeAfterAbort)) {
this.phase.wakeRequested = true this.phase.wakeRequested = true
@@ -328,8 +323,7 @@ export class ReactLoopAgent implements Agent {
} }
if (!this.inbox.hasPending) return false if (!this.inbox.hasPending) return false
phase.abort = new AbortController() phase.abort = new AbortController()
// The driver keeps running with a fresh controller: any latch set on the // A fresh controller makes a latch set on the old one stale: the live driver claims the queue itself.
// old one is stale, and the live driver claims the queue itself.
phase.wakeRequested = false phase.wakeRequested = false
phase.step = 0 phase.step = 0
return true return true