Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(ui-agent-preset): let the roster read take the store it drives

Browse Source 
Threading a status reader and a patch callback made both call sites long
enough to read as the same code again; handing over the store is one line at
each and says the same thing.
This commit is contained in:
Yichen Jiang
2026-08-07 16:44:46 +08:00
parent 9957f4a4f8
commit 84c01cde9f
2 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/client/ui-agent-preset/src/client/section-store.ts
View File

@@ -137,9 +137,7 @@ export class AgentPresetSectionController {
* @returns once the snapshot reflects the host.
*/
async load(): Promise<void> {
const roster = await beginRosterRead(
this.api, () => this.store.getSnapshot().status, (patch) => { this.set(patch) },
)
const roster = await beginRosterRead(this.api, this.store)
if (roster === undefined) return
const { presets, authorable } = roster
if (presets.length === 0) {

19
packages/client/ui-agent-preset/src/client/settings-store.ts
View File

@@ -115,20 +115,19 @@ export async function readRoster(api: Pick<IApiClient, 'agentPresets'>): Promise
* further — either another read owns it, or this one already wrote the
* failure. What differs between surfaces starts after this.
* @param api - the agent-preset wire face.
* @param status - reads the store's current status.
* @param set - patches the store's status and error.
* @param store - the surface's own snapshot store.
* @returns the roster, or undefined when the caller should return.
*/
export async function beginRosterRead(
export async function beginRosterRead<S extends { status: string; error: string | null }>(
api: Pick<IApiClient, 'agentPresets'>,
status: () => string,
set: (patch: { status?: 'loading' | 'error'; error?: string | null }) => void,
store: SnapshotStore<S>,
): Promise<RosterValue | undefined> {
if (status() === 'loading') return undefined
set({ status: 'loading', error: null })
const before = store.getSnapshot()
if (before.status === 'loading') return undefined
store.set({ ...before, status: 'loading', error: null })
const roster = await readRoster(api)
if (roster.ok) return roster.value
set({ status: 'error', error: roster.error })
store.set({ ...store.getSnapshot(), status: 'error', error: roster.error })
return undefined
}
@@ -196,9 +195,7 @@ export class AgentPresetSettingsController {
* @returns once the snapshot reflects the host.
*/
async load(): Promise<void> {
const roster = await beginRosterRead(
this.api, () => this.store.getSnapshot().status, (patch) => { this.set(patch) },
)
const roster = await beginRosterRead(this.api, this.store)
if (roster === undefined) return
const { presets } = roster
const [first] = presets