Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(hooks): require invocation signals

Browse Source
This commit is contained in:
Tianyi Cui
2026-07-21 00:08:44 +08:00
parent 72f0019c4e
commit 81cdebc531
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/hooks/hooks-claude/src/index.ts
View File

@@ -132,7 +132,7 @@ export function apply(ctx: Context, config: Config): void {
point: string, point: string,
matchQuery: string, matchQuery: string,
payload: unknown, payload: unknown,
opts: { agent?: Agent; turn?: number; signal?: AbortSignal }, opts: { agent?: Agent; turn?: number; readonly signal: AbortSignal },
): Promise<MergedHookOutcome> { ): Promise<MergedHookOutcome> {
const groups: MatcherGroup[] = parsed[point] ?? [] const groups: MatcherGroup[] = parsed[point] ?? []
const outputs: HookOutput[] = [] const outputs: HookOutput[] = []
@@ -159,7 +159,7 @@ export function apply(ctx: Context, config: Config): void {
defaultTimeoutMs, defaultTimeoutMs,
...hookEnv ? { env: hookEnv } : {}, ...hookEnv ? { env: hookEnv } : {},
...workdir !== undefined ? { cwd: workdir } : {}, ...workdir !== undefined ? { cwd: workdir } : {},
...opts.signal ? { signal: opts.signal } : {}, signal: opts.signal,
trailingNewline: true, trailingNewline: true,
// Discard a `hookSpecificOutput` block whose `hookEventName` names a // Discard a `hookSpecificOutput` block whose `hookEventName` names a
// different event than the one firing (the schemas key it by event). // different event than the one firing (the schemas key it by event).

9
packages/hooks/hooks-codex/src/index.ts
View File

@@ -106,7 +106,12 @@ export function apply(ctx: Context, config: Config): void {
point: string, point: string,
matchQuery: string, matchQuery: string,
payload: unknown, payload: unknown,
opts: { agent?: Agent; turn?: number; signal?: AbortSignal; plainStdoutAsContext?: boolean }, opts: {
agent?: Agent
turn?: number
readonly signal: AbortSignal
plainStdoutAsContext?: boolean
},
): Promise<MergedHookOutcome> { ): Promise<MergedHookOutcome> {
const groups: MatcherGroup[] = parsed[point] ?? [] const groups: MatcherGroup[] = parsed[point] ?? []
const outputs: HookOutput[] = [] const outputs: HookOutput[] = []
@@ -129,7 +134,7 @@ export function apply(ctx: Context, config: Config): void {
payload, payload,
defaultTimeoutMs, defaultTimeoutMs,
...workdir !== undefined ? { cwd: workdir } : {}, ...workdir !== undefined ? { cwd: workdir } : {},
...opts.signal ? { signal: opts.signal } : {}, signal: opts.signal,
trailingNewline: false, // Codex writes stdin without a trailing newline. trailingNewline: false, // Codex writes stdin without a trailing newline.
// Discard a `hookSpecificOutput` block naming a different event. // Discard a `hookSpecificOutput` block naming a different event.
expectedEventName: point, expectedEventName: point,