refactor(loader): resolve config after injected services

packages/bundle/headless/tests/startup.spec.ts

@@ -1,8 +1,7 @@
 /**
- * The one-shot app's startup row over a REAL Loader tree: the task
- * positional becomes the value the runner row reads, a missing task is a usage
- * error, and the web service this app absorbs is provided too, so the web rows
- * it rides over resolve on their own fallbacks.
+ * The one-shot app's startup row over a real Loader tree: the task positional
+ * becomes the injected runner config, while help and usage errors leave the
+ * runner pending.
  */
 
 import { mkdtempSync, writeFileSync } from 'node:fs'
@@ -13,7 +12,6 @@ import { Context } from 'cordis'
 import Loader from '@cordisjs/plugin-loader'
 import Include from '@cordisjs/plugin-include'
 import { internals, provideCmdline } from '@deepseek-ai/dsh-cmdline'
-import { WEB_STARTUP_SERVICE } from '@deepseek-ai/dsh-web-app/startup'
 import { afterEach, describe, expect, it } from 'vitest'
 import { apply, HEADLESS_STARTUP_SERVICE, type HeadlessStartupValues } from '../src/startup.ts'
 
@@ -21,6 +19,7 @@ import { apply, HEADLESS_STARTUP_SERVICE, type HeadlessStartupValues } from '../
 interface Observed {
   exits: number[]
   out: string
+  runnerConfig?: unknown
 }
 
 const disposers: (() => Promise<void>)[] = []
@@ -32,22 +31,20 @@ afterEach(async () => {
 })
 
 /**
- * Mount the real startup row over stand-ins for the runner row and one web
- * row this app absorbs, the way a profile mounts phase one.
+ * Mount the real startup row over a runner stand-in.
  * @param args - the invocation's inner arguments.
- * @param options - fixture knobs for the shapes a composition can take.
- * @returns the resolved service values (absent when the app requested exit) and what the boot observed.
+ * @param options - fixture knobs for invalid compositions.
+ * @returns the resolved startup value and observed runner/process effects.
  */
 async function bootStartup(
   args: string[],
   options: { withoutRunner?: boolean } = {},
-): Promise<{ task: HeadlessStartupValues | undefined; web: unknown; observed: Observed }> {
+): Promise<{ task: HeadlessStartupValues | undefined; observed: Observed }> {
   const dir = mkdtempSync(join(tmpdir(), 'dsh-headless-startup-'))
   const observed: Observed = { exits: [], out: '' }
-  writeFileSync(join(dir, 'row.mjs'), 'export function apply() {}\n')
-  // The Loader imports a row through Node's own resolver, which cannot resolve
-  // this workspace's sources; the row delegates to the real plugin the test
-  // imported through the source-plane path mapping.
+  writeFileSync(join(dir, 'row.mjs'), 'export function apply(_ctx, config) { globalThis.__headlessStartupObserved.runnerConfig = config }\n')
+  // Loader imports through Node's resolver, so this fixture delegates to the
+  // source-plane plugin already imported by the test.
   writeFileSync(join(dir, 'startup.mjs'), `
 export const name = 'headless-startup'
 export const inject = ['cmdlineArgs']
@@ -55,16 +52,11 @@ export const apply = ctx => globalThis.__headlessStartupApply(ctx)
 `)
   const rowUrl = pathToFileURL(join(dir, 'row.mjs')).href
   writeFileSync(join(dir, 'cordis.yml'), [
-    // A composition that lost the runner still injects the service, so the
-    // startup row reaches its own row check rather than the generic one.
     options.withoutRunner === true ? '- id: displaced-runner' : '- id: headless-runner',
     `  name: ${rowUrl}`,
     `  inject: [${HEADLESS_STARTUP_SERVICE}]`,
-    '  disabled: true',
-    '- id: webserver',
-    `  name: ${rowUrl}`,
-    `  inject: [${WEB_STARTUP_SERVICE}]`,
-    '  disabled: true',
+    '  config:',
+    '    task: !!js ctx.headlessStartup.task',
     '- id: headless-startup',
     `  name: ${pathToFileURL(join(dir, 'startup.mjs')).href}`,
     '  inject: [cmdlineArgs]',
@@ -73,7 +65,12 @@ export const apply = ctx => globalThis.__headlessStartupApply(ctx)
   const observing = { write: (chunk: string) => { observed.out += chunk; return true } }
   internals.stdout = observing
   internals.stderr = observing
-  ;(globalThis as unknown as { __headlessStartupApply: typeof apply }).__headlessStartupApply = apply
+  const globals = globalThis as unknown as {
+    __headlessStartupApply: typeof apply
+    __headlessStartupObserved: Observed
+  }
+  globals.__headlessStartupApply = apply
+  globals.__headlessStartupObserved = observed
 
   const ctx = new Context()
   await ctx.plugin(Loader)
@@ -84,38 +81,35 @@ export const apply = ctx => globalThis.__headlessStartupApply(ctx)
   disposers.push(async () => { await ctx.fiber.dispose() })
   return {
     task: ctx.get(HEADLESS_STARTUP_SERVICE) as HeadlessStartupValues | undefined,
-    web: ctx.get(WEB_STARTUP_SERVICE),
     observed,
   }
 }
 
 describe('headless startup', () => {
-  it('joins the task positional into the value the runner reads', async () => {
+  it('joins the task positional into the runner config', async () => {
     const { task, observed } = await bootStartup(['run', 'the', 'tests'])
     expect(task).toEqual({ task: 'run the tests' })
+    expect(observed.runnerConfig).toEqual({ task: 'run the tests' })
     expect(observed.exits).toEqual([])
   })
 
-  it('provides the web service it absorbed, so those rows resolve on their own fallbacks', async () => {
-    const { web } = await bootStartup(['task'])
-    expect(web).toEqual({ task: 'task' })
-  })
-
-  it('rejects an invocation with no task instead of failing inside the runner schema', async () => {
+  it('rejects an invocation with no task and leaves the runner pending', async () => {
     const { task, observed } = await bootStartup([])
     expect(observed.out).toContain('a task is required')
     expect(task).toBeUndefined()
+    expect(observed.runnerConfig).toBeUndefined()
     expect(observed.exits).toEqual([1])
   })
 
-  it('prints its own help and resolves nothing', async () => {
+  it('prints its own help and leaves the runner pending', async () => {
     const { task, observed } = await bootStartup(['--help'])
     expect(observed.out).toContain('dsh --profile headless')
     expect(task).toBeUndefined()
+    expect(observed.runnerConfig).toBeUndefined()
     expect(observed.exits).toEqual([0])
   })
 
-  it('fails the boot when the composition has no runner row to give the task to', async () => {
+  it('fails when the composition has no runner row', async () => {
     await expect(bootStartup(['task'], { withoutRunner: true }))
       .rejects.toThrow('the composition has no waiting "headless-runner" row')
   })