fix(web): correct the preset-layer contracts review found stale

None of these change behavior; each said something that was not true.

`SessionCwdConflict`'s doc block had been left stranded above the
`AgentPresetConflict` inserted under it, so one class carried a comment
about the other and the second carried none.

The roster comment named a `.system` directory that does not exist; the
shipped root is `config/agent-presets/`, and `system` is the trust its
entries carry.

The real-composition test attributed the disabled `api-gateway` row to
"side effects outside this process" alongside the port and the exporter.
It is disabled for a different reason — the api-proxy cannot mount in
this layer at all — and hiding that behind the same phrase would leave a
later layer unable to tell whether the line can come out.

One test claimed to refuse an adoption while asserting only that the
header records the preset; it now says what it checks.

`PERSONA_SECTION`/`PERSONA_ORDER` existed twice, once in the registry
that declares the slot and once restated in the row that replaces it —
a drift that would land a preset's persona beside the deployment's
instead of shadowing it. The registry exports them now.

The preset conflict message read "already runs agent preset undefined"
for a session that records none, which is the shape a deployment with no
roster produces; it names that case instead, with the regression that
reaches it through the gateway.

Finally, `PresetTree.write()` drops the `loader/config-update` the
inherited method emits — recorded on the override, since a future
edit-while-running flow needs its own persistence path.
This commit is contained in:
Yichen Jiang
2026-08-06 13:43:32 +08:00
parent c58cc23d45
commit 5ed79887fb
19 changed files with 119 additions and 37 deletions

View File

@@ -2,5 +2,5 @@
# side as of the last confirmed-consistent state. Both languages carry equal authority;
# after editing either side, bring the other along and re-record with:
# pnpm run verify-translation-pairing --write packages/preset/README.md
README.md: fcce3013174b5c3b7e545eb48e73cc1d8f4126dc
README.zh.md: 281885daae9aab8dc989c232e751f9a255075b96
README.md: d2ed10014af506809b5fd117e08b09b45a31a16c
README.zh.md: db7bf18e6ba841cc705eafae7c09d4c5d26581b1

View File

@@ -2,5 +2,5 @@
# side as of the last confirmed-consistent state. Both languages carry equal authority;
# after editing either side, bring the other along and re-record with:
# pnpm run verify-translation-pairing --write packages/preset/agent-presets/README.md
README.md: 8c95719bead97845519b7a334603005df201a34d
README.zh.md: c5e2fd3c7896437ddb4a2acdf101cd2e0e0eedaf
README.md: 1592fba1163448aaedbd482c56962fa07ebc897e
README.zh.md: ef4512ab93783674890bc9a848e590792a820e8c

View File

@@ -61,6 +61,11 @@ class PresetTree extends Include {
* shipped composition to `[]` the first time a session ends. Persisting a
* preset is also meaningless: nothing here is user state, and the same file
* backs every session that names it.
*
* Dropping the write drops the `loader/config-update` the inherited method
* emits with it. Nothing observes one for a preset subtree today, and a
* future "edit your preset while it runs" flow needs a deliberate
* persistence path rather than this method's return.
*/
override write(): void {
}

View File

@@ -2,5 +2,5 @@
# side as of the last confirmed-consistent state. Both languages carry equal authority;
# after editing either side, bring the other along and re-record with:
# pnpm run verify-translation-pairing --write packages/preset/persona/README.md
README.md: 3a9f9f2e2debf9d4274949e14913137ef752baae
README.zh.md: 2c3bac3bb4a1fbeeb9c30defb225c2b64cb3e577
README.md: 789776b32d907f7d217accccbca5508f88de0ed1
README.zh.md: 4e28d75bbd4fd22b77a0fa3b18c5f19df08588d8

View File

@@ -21,9 +21,7 @@
"files": [
"lib/index.js",
"lib/invariant.js",
"lib/types/**/*.d.ts",
"lib/types/**/*.d.ts.map",
"src"
"lib/types/**/*.d.ts"
],
"license": "BSD-3-Clause",
"peerDependencies": {

View File

@@ -17,11 +17,12 @@ import type { Context } from 'cordis'
import z from 'schemastery'
import type {} from '@deepseek-ai/dsh-system-prompt'
/** The section name this plugin registers; the prompt registry's persona slot. */
export const PERSONA_SECTION = 'deployment:persona'
// Imported rather than restated: the registry declares the slot this row
// replaces, and two hardcoded copies would drift into a preset whose persona
// silently lands beside the deployment's instead of shadowing it.
import { PERSONA_ORDER, PERSONA_SECTION } from '@deepseek-ai/dsh-system-prompt'
/** Prompt order of the persona slot, matching the registry's own default. */
export const PERSONA_ORDER = 0
export { PERSONA_ORDER, PERSONA_SECTION }
/** Cordis plugin name. */
export const name = 'persona'