Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: correct fs/observed concurrency-safety wording

Browse Source 
The read tool's isConcurrencySafe rationale called the fs/observed recorder
"commutative" and said concurrent reads "converge to one observed version",
overstating the guarantee: the WeakMap record is last-writer-wins. Safety comes
from write/edit re-checking the version in their in-lock CAS (a stale
observation only forces a later edit to fail closed with FS_STALE_VERSION), as
the RFC already states. Align the read comment, the ToolDefinition JSDoc, both
READMEs, and the regenerated catalogs.
This commit is contained in:
Dudu-0223
2026-07-14 11:56:27 +08:00
parent eae8b8ce2e
commit 5ab8f2e328
7 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/config-catalog.md
View File

@@ -975,7 +975,7 @@ export interface Config {
export type ToolPresentationMode = 'native' | 'code' | 'both'
```
Source: [`packages/core/tools/src/index.ts:482`](../packages/core/tools/src/index.ts)
Source: [`packages/core/tools/src/index.ts:484`](../packages/core/tools/src/index.ts)
## `@deepseek-ai/dsh-user-approval`

2
docs/cordis-catalog/services.md
View File

@@ -277,7 +277,7 @@ async execute(exec: ToolExecutionInput): Promise<ToolExecutionResult>
Types: [ToolDefinition](../core-data-structures/tools.md) · [ToolExecutionInput](../core-data-structures/tools.md) · [ToolExecutionMode](../core-data-structures/tools.md) · [ToolExecutionResult](../core-data-structures/tools.md)
Source: [`packages/core/tools/src/index.ts:574`](../../packages/core/tools/src/index.ts)
Source: [`packages/core/tools/src/index.ts:576`](../../packages/core/tools/src/index.ts)
## `ctx.userInteraction` — `UserInteractionService`

6
docs/core-data-structures/tools.md
View File

@@ -40,8 +40,10 @@ interface ToolDefinition extends ToolSchema {
* step outputs are the returned content, `meta`, structured error, and
* `additionalContext` carried through the loop's ordered post-execute path.
* The narrow exception is a synchronous, side-effect-only recorder whose
* updates are commutative for concurrent calls by the same session (the
* `fs/observed` version recorder is the worked example).
* updates are commutative OR fail closed for concurrent calls by the same
* session (the `fs/observed` version recorder is the worked example: its
* WeakMap record is last-writer-wins, and a stale observation only makes a
* later write/edit fail closed at its in-lock version CAS).
*/
isConcurrencySafe?(args: unknown): boolean
/**