fix review findings: stale service prose + catalog cleanup
Codex review of the PR1 diff surfaced docs/cleanup drift: - LlmService class JSDoc still advertised "streaming / non-streaming call surfaces, both interceptable via waterfall events" — corrected to the single streaming surface; regenerated the cordis catalog so its mirror updates. - Removed GenerateResult from gen-cordis-catalog.ts LINK_MAP (the type is gone). - The adapter-change RFC's acceptance criterion named the retired verify-event-taxonomy gate; updated to verify-cordis-catalog. - Dropped the now-tautological "streaming and one-shot assembly agree" property test (the streaming/one-shot distinction lived in the removed flush API; usage/finish remain covered by assembler.spec.ts and the finish property).
This commit is contained in:
@@ -341,7 +341,7 @@ Source: [`packages/bash/bash/src/index.ts:58`](../../packages/bash/bash/src/inde
|
||||
|
||||
### `ctx.llm` — `LlmService`
|
||||
|
||||
The abstract `llm` service: an adapter registry plus streaming / non-streaming call surfaces, both interceptable via waterfall events.
|
||||
The abstract `llm` service: an adapter registry plus a streaming model-call surface, interceptable via the `llm/stream` waterfall.
|
||||
|
||||
```ts cordis-catalog
|
||||
registerAdapter(models: string[], adapter: LlmAdapter): () => void
|
||||
|
||||
@@ -29,7 +29,7 @@ If an LLM adapter browser or dynamic model-picker needs this signal later, reint
|
||||
|
||||
## Acceptance criteria
|
||||
|
||||
- `llm/adapter-change` and its emits are gone; `pnpm run verify-event-taxonomy` passes against the updated table.
|
||||
- `llm/adapter-change` and its emits are gone; `pnpm run verify-cordis-catalog` passes against the regenerated catalog.
|
||||
- HMR-safety tests still pass: disposing a contributing fiber still removes the adapter.
|
||||
- `tools/change` and `system-prompt/change` remain documented and tested.
|
||||
- `pnpm run test:coverage` stays 100% per-file.
|
||||
|
||||
Reference in New Issue
Block a user