Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix review findings: keep ask-user opt-in for acp app

Browse Source
This commit is contained in:
Yichen Jiang
2026-07-09 00:40:13 +08:00
parent 7a1ef4b231
commit 56091d5b5d
9 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/ui/acp-agent/tests/acp-agent.spec.ts
View File

@@ -31,7 +31,7 @@ describe('dsh-acp-agent composition', () => {
expect(ctx.get('sessionPersistence')).toBeDefined()
expect(ctx.get('agentLoop')).toBeDefined()
expect(ctx.get('userInteraction')).toBeDefined()
expect(ctx.get('tools')?.get('ask_user_question')).toBeDefined()
expect(ctx.get('tools')?.get('ask_user_question')).toBeUndefined()
// No pre-created agents — ACP session/new creates them on demand.
expect(ctx.get('agents')!.list()).toHaveLength(0)
await ctx.fiber.dispose()
@@ -72,7 +72,7 @@ describe('dsh-acp-agent composition', () => {
})
}
const assembly = await ctx.get('systemPrompt')!.assemble()
expect(assembly.tools.map(tool => tool.name)).toEqual(['zulu', 'alpha', 'ask_user_question'])
expect(assembly.tools.map(tool => tool.name)).toEqual(['zulu', 'alpha'])
await ctx.fiber.dispose()
})