Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(app-boot): drop the unreachable timer guard on the fail-loud release path

Browse Source 
The timeout promise's executor runs synchronously while the race is
constructed, so the timer is always assigned; the undefined check was a
dead branch the per-file coverage gate rejected.
This commit is contained in:
Turtle
2026-07-31 22:14:43 +08:00
parent 998f9c931d
commit 54e541d33f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/ui/app-boot/src/index.ts
View File

@@ -384,7 +384,9 @@ export function installFailLoud(
return return
} }
void (async () => { void (async () => {
let timer: ReturnType<typeof setTimeout> | undefined // Definitely assigned: the timeout promise's executor runs synchronously
// while the race is being constructed, before the first await.
let timer!: ReturnType<typeof setTimeout>
try { try {
await Promise.race([ await Promise.race([
(async () => release())(), (async () => release())(),
@@ -396,7 +398,7 @@ export function installFailLoud(
// The terminal release failed; the fatal exit below is the outcome that // The terminal release failed; the fatal exit below is the outcome that
// matters, and no reporter runs after it. // matters, and no reporter runs after it.
} }
if (timer !== undefined) clearTimeout(timer) clearTimeout(timer)
proc.exit(1) proc.exit(1)
})() })()
} }