perf(tui): incremental step timing and card render caches for long sessions
Resuming a long session (196k events, 2.2k steps, 1.8k tool cards) took ~12s to render and ~800ms to echo one keystroke: - Every step's timing footer called stepTimingAt, which replayed the whole event log per footer - O(steps x events) on the initial render. - pi-tui re-renders every component each frame and relies on per-component line caches, but ToolCardComponent/ContextCardComponent built throwaway Text/Markdown instances inside render(width), re-wrapping every settled card's output on every keystroke. Replace the per-footer replay with one shared StepTimingTracker per chat mount (single O(events) cursor over the append-only log), and cache card rows by width via CardLineCache, dropped by every state mutator and invalidate(). Measured (tmux 200x50, 196k-event session): resume prompt-ready ~12s -> ~7.6s; per-keystroke echo ~800ms median -> ~11ms.
This commit is contained in:
90
packages/ui/tui/tests/timing-tracker.spec.ts
Normal file
90
packages/ui/tui/tests/timing-tracker.spec.ts
Normal file
@@ -0,0 +1,90 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import type { SessionEvent } from '@deepseek-ai/dsh-session'
|
||||
import { StepTimingTracker } from '../src/chat/timing.ts'
|
||||
|
||||
/** One completed two-phase step plus a tool call, in event-log order. */
|
||||
function stepEvents(turn: number, step: number, base: number, seq: number): SessionEvent[] {
|
||||
return [
|
||||
{ type: 'step/start', seq: seq, time: base, data: { turn, step } },
|
||||
{ type: 'assistant/chunk', seq: seq + 1, time: base + 100, data: { turn, step, chunk: { type: 'block-start', index: 0, blockType: 'reasoning' } } },
|
||||
{ type: 'assistant/chunk', seq: seq + 2, time: base + 300, data: { turn, step, chunk: { type: 'text-delta', index: 1, text: 'hi' } } },
|
||||
{ type: 'tool/call', seq: seq + 3, time: base + 450, data: { turn, step, callId: 'call-1', name: 'bash', arguments: '{}' } },
|
||||
{ type: 'step/end', seq: seq + 4, time: base + 700, data: { turn, step } },
|
||||
] as SessionEvent[]
|
||||
}
|
||||
|
||||
describe('StepTimingTracker', () => {
|
||||
it('accumulates each phase from the step lifecycle', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
const events = stepEvents(1, 1, 1_000, 0)
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 2_000)).toEqual({
|
||||
ttft: 100, // step/start -> first chunk
|
||||
thinking: 200, // reasoning block-start -> text delta
|
||||
responding: 150, // text delta -> tool call
|
||||
tools: 250, // tool call -> step/end
|
||||
})
|
||||
})
|
||||
|
||||
it('returns empty totals for a step that never started', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
expect(tracker.totalsAt(stepEvents(1, 1, 1_000, 0), { turn: 9, step: 9 }, 2_000)).toEqual({
|
||||
ttft: 0, thinking: 0, responding: 0, tools: 0,
|
||||
})
|
||||
})
|
||||
|
||||
it('accumulates the open bucket to the query clock without mutating tracked state', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
const events = [
|
||||
{ type: 'step/start', seq: 0, time: 1_000, data: { turn: 1, step: 1 } },
|
||||
] as SessionEvent[]
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 1_250).ttft).toBe(250)
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 1_400).ttft).toBe(400)
|
||||
})
|
||||
|
||||
it('matches a fresh replay when queried incrementally across appends', () => {
|
||||
const incremental = new StepTimingTracker()
|
||||
const first = stepEvents(1, 1, 1_000, 0)
|
||||
incremental.totalsAt(first, { turn: 1, step: 1 }, 5_000)
|
||||
const events = [...first, ...stepEvents(1, 2, 3_000, first.length)]
|
||||
const fresh = new StepTimingTracker()
|
||||
for (const position of [{ turn: 1, step: 1 }, { turn: 1, step: 2 }]) {
|
||||
expect(incremental.totalsAt(events, position, 5_000)).toEqual(fresh.totalsAt(events, position, 5_000))
|
||||
}
|
||||
})
|
||||
|
||||
it('serves interleaved steps from one shared scan', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
const events = [
|
||||
{ type: 'step/start', seq: 0, time: 1_000, data: { turn: 1, step: 1 } },
|
||||
{ type: 'step/start', seq: 1, time: 1_100, data: { turn: 1, step: 2 } },
|
||||
{ type: 'assistant/chunk', seq: 2, time: 1_200, data: { turn: 1, step: 2, chunk: { type: 'text-delta', index: 0, text: 'x' } } },
|
||||
{ type: 'step/end', seq: 3, time: 1_500, data: { turn: 1, step: 2 } },
|
||||
{ type: 'step/end', seq: 4, time: 1_600, data: { turn: 1, step: 1 } },
|
||||
] as SessionEvent[]
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 9_000)).toEqual({ ttft: 600, thinking: 0, responding: 0, tools: 0 })
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 2 }, 9_000)).toEqual({ ttft: 100, thinking: 0, responding: 300, tools: 0 })
|
||||
})
|
||||
|
||||
it('keeps the first step/start when a duplicate arrives while the step is open', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
const events = [
|
||||
{ type: 'step/start', seq: 0, time: 1_000, data: { turn: 1, step: 1 } },
|
||||
{ type: 'step/start', seq: 1, time: 1_500, data: { turn: 1, step: 1 } },
|
||||
] as SessionEvent[]
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 2_000).ttft).toBe(1_000)
|
||||
})
|
||||
|
||||
it('ignores same-coordinate events after the step closed', () => {
|
||||
const tracker = new StepTimingTracker()
|
||||
const events = [
|
||||
...stepEvents(1, 1, 1_000, 0),
|
||||
// A stray duplicate start and a late chunk reuse the coordinates; the
|
||||
// closed step's totals stay pinned.
|
||||
{ type: 'step/start', seq: 5, time: 9_000, data: { turn: 1, step: 1 } },
|
||||
{ type: 'assistant/chunk', seq: 6, time: 9_100, data: { turn: 1, step: 1, chunk: { type: 'text-delta', index: 0, text: 'late' } } },
|
||||
] as SessionEvent[]
|
||||
expect(tracker.totalsAt(events, { turn: 1, step: 1 }, 10_000)).toEqual({
|
||||
ttft: 100, thinking: 200, responding: 150, tools: 250,
|
||||
})
|
||||
})
|
||||
})
|
||||
74
packages/ui/tui/tests/transcript-card-cache.spec.ts
Normal file
74
packages/ui/tui/tests/transcript-card-cache.spec.ts
Normal file
@@ -0,0 +1,74 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import type { SessionEvent } from '@deepseek-ai/dsh-session'
|
||||
import { createToolResultMessage, CallId } from '@deepseek-ai/dsh-llm'
|
||||
import { ContextCardComponent, ToolCardComponent } from '../src/components/transcript.ts'
|
||||
import { parseArguments } from '../src/components/content.ts'
|
||||
import { createPalette, markdownTheme } from '../src/components/theme.ts'
|
||||
|
||||
const palette = createPalette(false)
|
||||
const mdTheme = markdownTheme(palette)
|
||||
|
||||
function toolCard(): ToolCardComponent {
|
||||
return new ToolCardComponent('bash', parseArguments('{"command":"ls"}'), undefined, 10, 2_000, palette, mdTheme)
|
||||
}
|
||||
|
||||
function toolResult(text: string): Extract<SessionEvent, { type: 'tool/result' }>['data'] {
|
||||
const message = createToolResultMessage({
|
||||
callId: CallId('call-1'),
|
||||
content: [{ type: 'text', text }],
|
||||
isError: false,
|
||||
})
|
||||
return { turn: 1, step: 1, message }
|
||||
}
|
||||
|
||||
// pi-tui re-renders every component each frame; the cards must serve repeat
|
||||
// same-width renders from their line cache and drop it on every state change.
|
||||
describe('transcript card render caches', () => {
|
||||
it('tool card: repeat same-width renders return the cached rows', () => {
|
||||
const card = toolCard()
|
||||
const first = card.render(80)
|
||||
expect(card.render(80)).toBe(first)
|
||||
const narrower = card.render(60)
|
||||
expect(narrower).not.toBe(first)
|
||||
expect(card.render(60)).toBe(narrower)
|
||||
})
|
||||
|
||||
it('tool card: result, visibility, and invalidate() each drop the cache', () => {
|
||||
const card = toolCard()
|
||||
const pending = card.render(80)
|
||||
card.updateResult(toolResult('output line'))
|
||||
const settled = card.render(80)
|
||||
expect(settled).not.toBe(pending)
|
||||
expect(settled.join('\n')).toContain('●')
|
||||
|
||||
card.setVisibility('hidden')
|
||||
expect(card.render(80)).toEqual([])
|
||||
|
||||
card.setVisibility('collapsed')
|
||||
const restored = card.render(80)
|
||||
expect(restored).toEqual(settled)
|
||||
expect(restored).not.toBe(settled)
|
||||
|
||||
card.invalidate()
|
||||
expect(card.render(80)).not.toBe(restored)
|
||||
})
|
||||
|
||||
it('context card: caches by width and drops on setExpanded and invalidate()', () => {
|
||||
const card = new ContextCardComponent('workspace-context', 'line one\nline two', 10, palette)
|
||||
const first = card.render(80)
|
||||
expect(card.render(80)).toBe(first)
|
||||
|
||||
// Same width across the mutation, so a hit here would prove a kept cache.
|
||||
card.setExpanded(true)
|
||||
const expanded = card.render(80)
|
||||
expect(expanded).not.toBe(first)
|
||||
expect(card.render(80)).toBe(expanded)
|
||||
|
||||
card.invalidate()
|
||||
const reRendered = card.render(80)
|
||||
expect(reRendered).not.toBe(expanded)
|
||||
expect(reRendered).toEqual(expanded)
|
||||
|
||||
expect(card.render(60)).not.toBe(reRendered)
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user