From 46580e408329e027414273527bac39dbd39b1650 Mon Sep 17 00:00:00 2001 From: Tianyi Cui <53024+tianyicui@users.noreply.github.com> Date: Sun, 19 Jul 2026 12:20:11 +0800 Subject: [PATCH] test(subagent): pin POSIX disposal scenarios Pass an explicit Linux platform to the two remaining SIGTERM-specific ladder tests instead of inheriting the host platform. This keeps their synchronous-exit assertions focused on the POSIX middle and final rungs while the dedicated Windows case continues to verify the direct SIGKILL path. Without the pin, native Windows coverage deterministically expected SIGTERM but observed the intended SIGKILL-only behavior. --- .../subagent-subprocess/tests/subagent-subprocess.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/subagent/subagent-subprocess/tests/subagent-subprocess.spec.ts b/packages/subagent/subagent-subprocess/tests/subagent-subprocess.spec.ts index 7c17333c03..e81957baa0 100644 --- a/packages/subagent/subagent-subprocess/tests/subagent-subprocess.spec.ts +++ b/packages/subagent/subagent-subprocess/tests/subagent-subprocess.spec.ts @@ -200,7 +200,7 @@ describe('disposeChildProcess', () => { it('recognizes a child that exits synchronously on SIGTERM', async () => { const fake = new FakeChild({ diesOn: 'SIGTERM', synchronousExit: true }) - await disposeChildProcess(asChild(fake), { disposeEofGraceMs: 20, disposeGraceMs: 1000 }) + await disposeChildProcess(asChild(fake), { disposeEofGraceMs: 20, disposeGraceMs: 1000 }, 'linux') expect(fake.kills).toEqual(['SIGTERM']) expect(fake.signalCode).toBe('SIGTERM') expect(fake.listenerCount('exit')).toBe(0) @@ -217,7 +217,7 @@ describe('disposeChildProcess', () => { it('recognizes a child already gone when the final exit wait begins', async () => { const fake = new FakeChild({ synchronousExit: true }) - await disposeChildProcess(asChild(fake), { disposeEofGraceMs: 20, disposeGraceMs: 20 }) + await disposeChildProcess(asChild(fake), { disposeEofGraceMs: 20, disposeGraceMs: 20 }, 'linux') expect(fake.kills).toEqual(['SIGTERM', 'SIGKILL']) expect(fake.signalCode).toBe('SIGKILL') })