Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(host): create folders with the entered name untrimmed

Browse Source 
Same contract as the path editor: trim only rejects an all-whitespace
draft, and the Host receives the original spelling — the backend accepts
any non-blank single segment verbatim, so trimming here would create and
select a different sibling.
This commit is contained in:
creatixchu
2026-07-29 05:59:51 +08:00
parent 723bb9057c
commit 463893947b
2 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
packages/host/directory-picker-browse/src/client/DirectoryBrowser.tsx
View File

@@ -211,8 +211,11 @@ export function DirectoryBrowser({ open, listDirectory, createDirectory, onOpen,
const confirmCreate = (): void => { const confirmCreate = (): void => {
/* v8 ignore next -- reentry fence: the nested dialog only renders with a target and disables while creating. */ /* v8 ignore next -- reentry fence: the nested dialog only renders with a target and disables while creating. */
if (targetPath === null || folderDraft === null || creatingFolder) return if (targetPath === null || folderDraft === null || creatingFolder) return
const name = folderDraft.trim() // Trim only rejects an all-whitespace draft; the Host gets the original
if (name === '') return // spelling — the backend accepts any non-blank single segment verbatim,
// and trimming here would create (and select) a different sibling.
const name = folderDraft
if (name.trim() === '') return
setCreatingFolder(true) setCreatingFolder(true)
setCreateError(null) setCreateError(null)
const generation = openGeneration.current const generation = openGeneration.current

11
packages/host/directory-picker-browse/tests/directory-browser.spec.tsx
View File

@@ -542,6 +542,17 @@ describe('DirectoryBrowser', () => {
expect(screen.getByText('Documents')).toBeTruthy() expect(screen.getByText('Documents')).toBeTruthy()
}) })
it('passes the folder name to the Host untrimmed (trim only gates blank drafts)', async () => {
const b = mount()
await waitFor(() => { expect(screen.getByRole('listitem')).toBeTruthy() })
fireEvent.click(screen.getByRole('button', { name: 'browser.newFolder' }))
const input = screen.getByLabelText('browser.folderName')
fireEvent.change(input, { target: { value: 'project ' } })
fireEvent.keyDown(input, { key: 'Enter' })
// A trailing space may be the wanted spelling; trimming would create a sibling.
await waitFor(() => { expect(b.createDirectory).toHaveBeenCalledWith(HOME, 'project ') })
})
it('creates a folder through the nested dialog and lands with it selected', async () => { it('creates a folder through the nested dialog and lands with it selected', async () => {
const b = mount() const b = mount()
await waitFor(() => { expect(screen.getByRole('listitem')).toBeTruthy() }) await waitFor(() => { expect(screen.getByRole('listitem')).toBeTruthy() })