Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(web): draft a custom preset in a creator-mode session

Browse Source 
The settings section gains the conversational authoring entry beside
copying: a dashed add-card (the Models page's affordance) that stages the
self-referential cordis preset and starts a new session on it, closing the
settings panel through the shell's new section owner-prop `close` — the
one shell affordance a section receives, for flows that leave settings.

The seat learns the difference between picking and staging: `select()`'s
immediate apply meets the still-current running session and drops the
stage as unservable, so the entry uses `stage()` and leaves the apply to
the list-change applier that fires when the started session becomes
current. `load()` stops regressing the display when its reply lands after
an applied stage was consumed — staged pick first, then the composition
the current session already carries, then the deployment default.

The authoring lane connects a workspace and drives the gesture to a
composed host session; the section goldens gain the entry.
This commit is contained in:
Yichen Jiang
2026-08-09 00:19:18 +08:00
parent 564337997a
commit 43e93c6a67
16 changed files with 288 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
packages/client/ui-agent-preset/tests/apply.spec.ts
View File

@@ -139,6 +139,15 @@ function declareConversation(slots: SlotsService): () => void {
} as never, () => null)
}
/** A workspaces double recording new-session starts. */
function workspacesDouble() {
const starts: unknown[] = []
return {
starts,
startSession: (workspaceId?: unknown) => { starts.push(workspaceId ?? null) },
}
}
/** A sessions double whose list can be moved and whose changes are pushed. */
function sessionsDouble(state: {
current?: string
@@ -287,7 +296,8 @@ describe('ui-agent-preset apply', () => {
const conversation = declareConversation(slots)
ctx.provide('conversation', {} as never)
ctx.provide('sessions', sessionsDouble({ byId: {} }) as never)
const fiber = ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply })
ctx.provide('workspaces', workspacesDouble() as never)
const fiber = ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply })
await fiber.await()
const chip = slots.entries('conversation.hero.agentPreset')[0]!
@@ -308,7 +318,8 @@ describe('ui-agent-preset apply', () => {
const conversation = declareConversation(slots)
ctx.provide('conversation', {} as never)
ctx.provide('sessions', sessionsDouble({ byId: {} }) as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const chip = slots.entries('conversation.hero.agentPreset')[0]!
const seat = (chip.inject as unknown as () => AgentPresetSeatInjected)()
@@ -339,7 +350,8 @@ describe('ui-agent-preset apply', () => {
const conversation = declareConversation(slots)
ctx.provide('conversation', {} as never)
ctx.provide('sessions', sessionsDouble({ byId: {} }) as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const chip = slots.entries('conversation.hero.agentPreset')[0]!
const seat = (chip.inject as unknown as () => AgentPresetSeatInjected)()
@@ -373,7 +385,8 @@ describe('ui-agent-preset apply', () => {
} = { byId: {} }
const sessions = sessionsDouble(state)
ctx.provide('sessions', sessions as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const chip = (slots.entries('conversation.hero.agentPreset')[0]!
.inject as unknown as () => AgentPresetSeatInjected)()
@@ -400,7 +413,8 @@ describe('ui-agent-preset apply', () => {
byId: { s1: { id: 's1', blank: true } },
})
ctx.provide('sessions', sessions as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const chip = (slots.entries('conversation.hero.agentPreset')[0]!
.inject as unknown as () => AgentPresetSeatInjected)()
@@ -423,7 +437,8 @@ describe('ui-agent-preset apply', () => {
}
const sessions = sessionsDouble(state)
ctx.provide('sessions', sessions as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const chip = (slots.entries('conversation.hero.agentPreset')[0]!
.inject as unknown as () => AgentPresetSeatInjected)()
@@ -445,7 +460,8 @@ describe('ui-agent-preset apply', () => {
declareConversation(slots)
ctx.provide('conversation', {} as never)
ctx.provide('sessions', sessionsDouble({ byId: {} }) as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions'], apply }).await()
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const label = (slots.entries('conversation.session.header.actions')[0]!
.inject as unknown as () => AgentPresetLabelInjected)()
const row = (slots.entries('settings.general.item')[0]!
@@ -458,4 +474,73 @@ describe('ui-agent-preset apply', () => {
expect(label.hooks.agentPresets).toBe(row.hooks.agentPreset)
expect(label.hooks.agentPresets.getSnapshot().options).toEqual([{ id: 'standard', trust: 'system' }])
})
it('stages the creator preset and starts a session from the section', async () => {
const { ctx, slots } = await bench()
declareRoot(slots)
const conversation = declareConversation(slots)
ctx.provide('conversation', {} as never)
ctx.provide('sessions', sessionsDouble({ byId: {} }) as never)
const workspaces = workspacesDouble()
ctx.provide('workspaces', workspaces as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const section = (slots.entries('settings.section')[0]!.inject as unknown as () => AgentPresetSectionInjected)()
const seat = (slots.entries('conversation.hero.agentPreset')[0]!
.inject as unknown as () => AgentPresetSeatInjected)()
section.startCreatorDraft?.()
// The pick is staged on the chip's own controller — the session the
// workspace start produces is what the stage lands on — and exactly one
// new-session flow began.
expect(section.startCreatorDraft).toBeDefined()
expect(seat.hooks.agentPresetSeat.getSnapshot().current).toBe('cordis')
expect(workspaces.starts).toHaveLength(1)
conversation()
})
it('keeps the applied composition when the roster load lands late', async () => {
const { ctx, slots, calls } = await bench()
declareRoot(slots)
const conversation = declareConversation(slots)
ctx.provide('conversation', {} as never)
const state: {
current?: string
byId: Record<string, { id: string; blank: boolean; agentPreset?: string }>
} = { byId: {} }
const sessions = sessionsDouble(state)
ctx.provide('sessions', sessions as never)
ctx.provide('workspaces', workspacesDouble() as never)
await ctx.plugin({ inject: [...inject, 'conversation', 'sessions', 'workspaces'], apply }).await()
const section = (slots.entries('settings.section')[0]!.inject as unknown as () => AgentPresetSectionInjected)()
const seat = (slots.entries('conversation.hero.agentPreset')[0]!
.inject as unknown as () => AgentPresetSeatInjected)()
section.startCreatorDraft?.()
state.current = 's1'
state.byId['s1'] = { id: 's1', blank: true }
sessions.notify()
await vi.waitFor(() => { expect(calls).toContain('select:cordis') })
// The chip mounts with the flow's session, so its roster load can land
// AFTER the stage was consumed; the session's own composition is what
// the display must keep — not the deployment default.
state.byId['s1'] = { id: 's1', blank: true, agentPreset: 'cordis' }
await seat.load()
expect(seat.hooks.agentPresetSeat.getSnapshot().current).toBe('cordis')
conversation()
})
it('offers no creator draft while the conversation flow is absent', async () => {
const { ctx, slots } = await bench()
declareRoot(slots)
await ctx.plugin({ inject: [...inject], apply }).await()
// No conversation scope mounted: the face omits the affordance and the
// section hides its button rather than staging into nowhere.
const section = (slots.entries('settings.section')[0]!.inject as unknown as () => AgentPresetSectionInjected)()
expect(section.startCreatorDraft).toBeUndefined()
})
})

42
packages/client/ui-agent-preset/tests/section.spec.tsx
View File

@@ -38,10 +38,16 @@ const READY: AgentPresetSectionState = {
* @param state - the snapshot to render.
* @returns the spies, so a test can assert what a click reached.
*/
function renderSection(state: Partial<AgentPresetSectionState> = {}) {
function renderSection(
state: Partial<AgentPresetSectionState> = {},
options: { creator?: boolean } = {},
) {
const store = createSnapshotStore<AgentPresetSectionState>({ ...READY, ...state })
const actions = {
load: vi.fn(() => Promise.resolve()),
// The shell-owned section affordance (SettingsSectionOwnerProps.close).
close: vi.fn(),
...options.creator === false ? {} : { startCreatorDraft: vi.fn() },
view: vi.fn(() => Promise.resolve()),
closeView: vi.fn(),
beginCopy: vi.fn(),
@@ -196,6 +202,40 @@ describe('the preset list', () => {
expect(actions.view).toHaveBeenCalledWith('standard')
})
it('starts a creator-mode draft session and leaves settings', () => {
const actions = renderSection({
rows: [...READY.rows, { id: 'cordis', trust: 'system', isDefault: false, name: '创造模式' }],
})
fireEvent.click(screen.getByRole('button', { name: en.creatorDraft }))
expect(actions.startCreatorDraft).toHaveBeenCalledTimes(1)
// Leaving settings is part of the gesture: the flow lands in the new
// session, not behind the modal.
expect(actions.close).toHaveBeenCalledTimes(1)
})
it('hides the creator entry without the flow or the preset, disables it without a root', () => {
renderSection()
expect(screen.queryByRole('button', { name: en.creatorDraft })).toBeNull()
cleanup()
renderSection({
rows: [...READY.rows, { id: 'cordis', trust: 'system', isDefault: false, name: '创造模式' }],
}, { creator: false })
expect(screen.queryByRole('button', { name: en.creatorDraft })).toBeNull()
cleanup()
const actions = renderSection({
authorable: false,
rows: [...READY.rows, { id: 'cordis', trust: 'system', isDefault: false, name: '创造模式' }],
})
const disabled = screen.getByRole('button', { name: en.creatorDraft })
expect(disabled).toHaveProperty('disabled', true)
fireEvent.click(disabled)
expect(actions.startCreatorDraft).not.toHaveBeenCalled()
})
it('shows a page-level failure without hiding the list', () => {
renderSection({ error: 'settings are read-only' })