feat(core): scope-aware registries and session dispatch carriers
dsh-tools and dsh-system-prompt gain a per-scope registration layer over
dsh-scope: a registration through a scoped context files into that scope,
shadows a same-named global contribution for that scope (per-agent persona
and tool variants), and unwinds with the scope. tools.restrict() masks the
global surface per scope (snapshot-at-registration, loud unknown-name
validation, intersection composition; scoped grants bypass). One visibility
function feeds schemas/get/execute, so prompt, presentation, and dispatch
can never disagree; out-of-view executes as UNKNOWN_TOOL.
Prompt tool providers now receive the AssembleContext and return
{schemas, knownNames}: toolOrder validates against the pre-restriction name
universe (a typo fails every assembly loudly) while ordering operates on
the post-restriction schemas (a restricted-away tool is a normal absence).
dsh-session captures each session's dispatch carrier at enter() from the
entering context's scope tag, and the new sessions.flush(session) owns the
awaited session/flush dispatch. tools/pre|post-execute and
system-prompt/assemble dispatch with scope carriers keyed by their subject;
session/created|event|flush by the owning session's scope.
This commit is contained in:
112
packages/core/session/tests/scoped.spec.ts
Normal file
112
packages/core/session/tests/scoped.spec.ts
Normal file
@@ -0,0 +1,112 @@
|
||||
import { describe, expect, it } from 'vitest'
|
||||
import { Context } from 'cordis'
|
||||
import { createScope, scopeOf } from '@deepseek-ai/dsh-scope'
|
||||
import type { Scope, ScopeKey } from '@deepseek-ai/dsh-scope'
|
||||
import SessionStore from '@deepseek-ai/dsh-session'
|
||||
import type { Session } from '@deepseek-ai/dsh-session'
|
||||
|
||||
async function mount(): Promise<Context> {
|
||||
const ctx = new Context()
|
||||
await ctx.plugin(SessionStore)
|
||||
return ctx
|
||||
}
|
||||
|
||||
async function mintScope(ctx: Context, name: string): Promise<Scope> {
|
||||
let scope!: Scope
|
||||
// The scoped context resolves services through the MINTING plugin's
|
||||
// dependency chain — the minter must inject what scope holders will reach.
|
||||
await ctx.plugin(Object.assign((inner: Context) => { scope = createScope(inner, { name }) },
|
||||
{ inject: ['sessions'] }))
|
||||
return scope
|
||||
}
|
||||
|
||||
/** The key a test scope was minted with. */
|
||||
function keyOf(scope: Scope): ScopeKey {
|
||||
|
||||
return scopeOf(scope.ctx)!
|
||||
}
|
||||
|
||||
describe('session dispatch carriers', () => {
|
||||
it('a session entered through a scoped context dispatches its events in that scope', async () => {
|
||||
const ctx = await mount()
|
||||
const scope = await mintScope(ctx, 'owner')
|
||||
const otherScope = await mintScope(ctx, 'other')
|
||||
|
||||
const heard: string[] = []
|
||||
ctx.on('session/event', (_session, event) => void heard.push(`global:${event.type}`))
|
||||
scope.ctx.on('session/event', (_session, event) => void heard.push(`owner:${event.type}`))
|
||||
otherScope.ctx.on('session/event', (_session, event) => void heard.push(`other:${event.type}`))
|
||||
scope.ctx.on('session/created', session => void heard.push(`owner-created:${session.id}`))
|
||||
otherScope.ctx.on('session/created', session => void heard.push(`other-created:${session.id}`))
|
||||
|
||||
const session = scope.ctx.sessions.create()
|
||||
session.append('turn/start', { turn: 1, trigger: { kind: 'message', source: { kind: 'user' } } })
|
||||
|
||||
expect(heard).toEqual([
|
||||
`owner-created:${session.id}`,
|
||||
'global:turn/start',
|
||||
'owner:turn/start',
|
||||
])
|
||||
})
|
||||
|
||||
it('a bare session dispatches subject-less: scoped listeners never hear it', async () => {
|
||||
const ctx = await mount()
|
||||
const scope = await mintScope(ctx, 'owner')
|
||||
const heard: string[] = []
|
||||
ctx.on('session/event', (_s, event) => void heard.push(`global:${event.type}`))
|
||||
scope.ctx.on('session/event', (_s, event) => void heard.push(`owner:${event.type}`))
|
||||
|
||||
const bare = ctx.sessions.create()
|
||||
bare.append('turn/start', { turn: 1, trigger: { kind: 'message', source: { kind: 'user' } } })
|
||||
expect(heard).toEqual(['global:turn/start'])
|
||||
})
|
||||
})
|
||||
|
||||
describe('sessions.flush()', () => {
|
||||
it('dispatches session/flush with the owning carrier and awaits all listeners', async () => {
|
||||
const ctx = await mount()
|
||||
const scope = await mintScope(ctx, 'owner')
|
||||
const flushed: string[] = []
|
||||
ctx.on('session/flush', async (session: Session) => {
|
||||
await Promise.resolve()
|
||||
flushed.push(`global:${session.id}`)
|
||||
})
|
||||
scope.ctx.on('session/flush', (session: Session) => void flushed.push(`owner:${session.id}`))
|
||||
|
||||
const owned = scope.ctx.sessions.create()
|
||||
const bare = ctx.sessions.create()
|
||||
await ctx.sessions.flush(owned)
|
||||
await ctx.sessions.flush(bare)
|
||||
|
||||
// Parallel dispatch: listener completion order is unspecified (the global
|
||||
// listener awaits a microtask) — assert set membership per flush instead.
|
||||
expect(flushed.slice(0, 2).sort()).toEqual([`global:${owned.id}`, `owner:${owned.id}`])
|
||||
expect(flushed.slice(2)).toEqual([`global:${bare.id}`])
|
||||
})
|
||||
|
||||
it('propagates a rejecting flush listener (the caller owns the failure policy)', async () => {
|
||||
const ctx = await mount()
|
||||
ctx.on('session/flush', () => Promise.reject(new Error('disk full')))
|
||||
const session = ctx.sessions.create()
|
||||
await expect(ctx.sessions.flush(session)).rejects.toThrow('disk full')
|
||||
})
|
||||
|
||||
it('flushes a never-entered session with a subject-less carrier (defensive path)', async () => {
|
||||
const ctx = await mount()
|
||||
const scope = await mintScope(ctx, 'owner')
|
||||
const flushed: string[] = []
|
||||
ctx.on('session/flush', (session: Session) => void flushed.push(`global:${session.id}`))
|
||||
scope.ctx.on('session/flush', (session: Session) => void flushed.push(`owner:${session.id}`))
|
||||
|
||||
const detached = ctx.sessions.prepare()
|
||||
await ctx.sessions.flush(detached)
|
||||
expect(flushed).toEqual([`global:${detached.id}`])
|
||||
})
|
||||
|
||||
it('keyOf sanity: distinct scopes carry distinct keys', async () => {
|
||||
const ctx = await mount()
|
||||
const a = await mintScope(ctx, 'a')
|
||||
const b = await mintScope(ctx, 'b')
|
||||
expect(keyOf(a)).not.toBe(keyOf(b))
|
||||
})
|
||||
})
|
||||
Reference in New Issue
Block a user