Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(acp-snapshot): keep the malformed-record capture branch-free for per-file coverage

Browse Source 
Store the captured validation error as unknown in a wrapper object and
rethrow it directly: the instanceof-Error normalization added an
un-inducible false branch that failed harness.ts's 100% branch gate.
This commit is contained in:
Tianyi Cui
2026-07-26 23:45:13 +08:00
parent a8a1ada183
commit 3cabde323f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/support/acp-snapshot/src/harness.ts
View File

@@ -457,7 +457,7 @@ async function waitForPersistedTurnStart(
timeoutMs = DEFAULT_WAIT_TIMEOUT_MS, timeoutMs = DEFAULT_WAIT_TIMEOUT_MS,
minimumTurn?: number, minimumTurn?: number,
): Promise<void> { ): Promise<void> {
let invalidRecord: Error | undefined let invalidRecord: { error: unknown } | undefined
await vi.waitFor(async () => { await vi.waitFor(async () => {
const log = (await harvestSessionLogs(root)).find(candidate => candidate.id === sessionId) const log = (await harvestSessionLogs(root)).find(candidate => candidate.id === sessionId)
let openTurn: number | undefined let openTurn: number | undefined
@@ -467,7 +467,7 @@ async function waitForPersistedTurnStart(
// A malformed persisted record is a scenario bug, not a not-yet state: // A malformed persisted record is a scenario bug, not a not-yet state:
// vi.waitFor retries every callback throw, so capture the validation // vi.waitFor retries every callback throw, so capture the validation
// failure, resolve the wait, and rethrow immediately below. // failure, resolve the wait, and rethrow immediately below.
invalidRecord = error instanceof Error ? error : new Error(String(error)) invalidRecord = { error }
return return
} }
if (openTurn === undefined || (minimumTurn !== undefined && openTurn < minimumTurn)) { if (openTurn === undefined || (minimumTurn !== undefined && openTurn < minimumTurn)) {
@@ -475,7 +475,7 @@ async function waitForPersistedTurnStart(
throw new Error(`snapshot-harness: session "${sessionId}" did not persist ${detail} within ${timeoutMs}ms`) throw new Error(`snapshot-harness: session "${sessionId}" did not persist ${detail} within ${timeoutMs}ms`)
} }
}, { interval: WAIT_POLL_INTERVAL_MS, timeout: timeoutMs }) }, { interval: WAIT_POLL_INTERVAL_MS, timeout: timeoutMs })
if (invalidRecord !== undefined) throw invalidRecord if (invalidRecord !== undefined) throw invalidRecord.error
} }
/** /**