Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(tool-bash): note the parseExitStatus residual applies to the signal marker too

Browse Source 
Review nit: the KNOWN RESIDUAL comment named only the [exit code: N] case, but
the same end-of-string spoof applies to [killed by signal: SIG]. Reword to cover
both markers.
This commit is contained in:
Tianyi Cui
2026-06-18 19:45:05 +08:00
parent 9f6b96c555
commit 21855d42b7
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/tool-bash/src/index.ts
View File

@@ -218,11 +218,12 @@ function presentBashResult(args: unknown, result: ToolResult): ToolResultPresent
* with no trailing newline — a clean exit 0 — no longer reads as a failure). * with no trailing newline — a clean exit 0 — no longer reads as a failure).
* *
* KNOWN RESIDUAL (inherent to the replay-only-sees-text design): a clean exit 0 * KNOWN RESIDUAL (inherent to the replay-only-sees-text design): a clean exit 0
* whose body's FINAL line is itself exactly `\n[exit code: N]` (the program * whose body's FINAL line is itself exactly the marker text — `[exit code: N]`
* printed that line and nothing after) is still indistinguishable from a real * or `[killed by signal: SIG]`, printed by the program with nothing after — is
* marker and would show a wrong pill. This is display-only (execution and the * still indistinguishable from a real marker and would show a wrong pill. This is
* model-facing text are unaffected) and narrow; the complete fix is to persist a * display-only (execution and the model-facing text are unaffected) and narrow;
* structured exit on the result event, which the RFC names as the escape hatch. * the complete fix is to persist a structured exit on the result event, which the
* RFC names as the escape hatch.
*/ */
function parseExitStatus(text: string): { exitCode: number } | { signal: string } { function parseExitStatus(text: string): { exitCode: number } | { signal: string } {
const signal = /\n\[killed by signal: ([^\]\n]+)\]$/.exec(text) const signal = /\n\[killed by signal: ([^\]\n]+)\]$/.exec(text)