fix(agent-loop): second review pass — late-steering discard, dead-branch, catalog leaks

Browse Source

Address a second fresh-eye review of the review fixes:
- MAJOR: late steering that lands after runTurn returns terminally
  stopped (e.g. during the post-turn flush) was drained by runLoop and
  dropped without a discard, leaving a dangling outstanding id the
  negative-only invariant can't catch. Emit agent/inbox/discard for it,
  symmetric with the in-turn terminal-stop drop.
- remove the dead cancel() idle-settle branch: whenIdle's fast path
  already resolves for a lone quiet item, so no waiter is ever left for
  it to settle. Document why.
- gen-cordis-api classShape now drops private/protected/#private members
  and strips getter/setter bodies, so Session no longer leaks private
  fields and getter bodies into the model catalog.
- document that AgentMessage intentionally omits meta (durable-only).

Adds a regression test for the late-steering discard.

...

This commit is contained in:

Turtle

2026-07-23 22:33:12 +08:00

parent 98ee4ce429

commit 1f9a3e1bee

14 changed files with 122 additions and 69 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2

examples/acp-agent/tests/snapshots/cordis-inspect-jsdoc/session.jsonl

File diff suppressed because one or more lines are too long

2

examples/acp-agent/tests/snapshots/cordis-inspect-jsdoc/stdout.expected.jsonl

File diff suppressed because one or more lines are too long