test(tui): cover diffContentLines empty-side arm

The coverage lane flagged transcript.ts line 63 (diffContentLines' empty-text
return) uncovered: the same-file diff test only fed newline-terminated sides.
Add a third hunk removing a line with an empty added side (a full deletion), so
the empty arm runs and the footer proves the empty side draws no `+ ` row
(+2 -1 · 1 file). Raise the test's line budget so every hunk row stays visible.
This commit is contained in:
Chinesezjc
2026-07-30 22:24:29 +08:00
parent de36fde01c
commit 1ea5f0b124

View File

@@ -4320,16 +4320,20 @@ describe('tool cards and surface replay', () => {
}, },
scatteredDiff: { scatteredDiff: {
name: 'scatteredDiff', description: '', parameters: {}, output: UNUSED_TOOL_OUTPUT, execute: async () => [], name: 'scatteredDiff', description: '', parameters: {}, output: UNUSED_TOOL_OUTPUT, execute: async () => [],
// Two hunks in ONE file, each side ending in the terminator newline real // Three hunks in ONE file. The first two sides end in the terminator
// write/edit content carries. The footer must read `+2 -0 · 1 file`: the // newline real write/edit content carries; the third removes a line and
// trailing newline terminates its line rather than adding a phantom empty // leaves an EMPTY added side (a full deletion), so `diffContentLines('')`
// one, and the two hunks count as the single distinct path they touch. // returns zero lines. The footer must read `+2 -1 · 1 file`: each trailing
// newline terminates its line rather than adding a phantom empty one, the
// empty side contributes no `+ ` row, and the three hunks count as the
// single distinct path they touch.
presentCall: () => ({ presentCall: () => ({
card: 'diff', card: 'diff',
title: 'Edit src/scatter.ts', title: 'Edit src/scatter.ts',
diffs: [ diffs: [
{ path: 'src/scatter.ts', oldText: null, newText: 'first\n' }, { path: 'src/scatter.ts', oldText: null, newText: 'first\n' },
{ path: 'src/scatter.ts', oldText: null, newText: 'second\n' }, { path: 'src/scatter.ts', oldText: null, newText: 'second\n' },
{ path: 'src/scatter.ts', oldText: 'gone\n', newText: '' },
], ],
}), }),
}, },
@@ -4638,7 +4642,10 @@ describe('tool cards and surface replay', () => {
}) })
it('counts a same-file diff once and terminates its trailing newline', async () => { it('counts a same-file diff once and terminates its trailing newline', async () => {
const result = await setup({ tools }) // A budget past the card's row count so every hunk row stays visible (the
// collapse arithmetic is covered elsewhere); this test is about the
// terminator rule and the distinct-path footer count.
const result = await setup({ tools, config: { maxToolOutputLines: 20 } })
appendUser(result.session, 'scatter edits in one file') appendUser(result.session, 'scatter edits in one file')
appendAssistant(result.session, [ appendAssistant(result.session, [
{ type: 'text', text: 'Editing' }, { type: 'text', text: 'Editing' },
@@ -4649,14 +4656,17 @@ describe('tool cards and surface replay', () => {
}) })
await tick() await tick()
const output = result.terminal.output const output = result.terminal.output
// Two hunks, one path: distinct-path count, same as the Web DiffBlock. // Three hunks, one path: distinct-path count, same as the Web DiffBlock.
expect(output).toContain('· 1 file') expect(output).toContain('· 1 file')
expect(output).not.toContain('· 2 files') expect(output).not.toContain('· 3 files')
// The `first\n`/`second\n` sides each contribute exactly one added line — // The `first\n`/`second\n` sides each contribute exactly one added line —
// the trailing newline terminates rather than adding a phantom empty `+ `. // the trailing newline terminates rather than adding a phantom empty `+ `.
expect(output).toContain('+ first') expect(output).toContain('+ first')
expect(output).toContain('+ second') expect(output).toContain('+ second')
expect(output).toContain('+2 -0') // The third hunk removes `gone` and leaves an empty added side, which
// contributes no `+ ` row (diffContentLines('') is zero lines).
expect(output).toContain('- gone')
expect(output).toContain('+2 -1')
await dispose(result) await dispose(result)
}) })