Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(sandbox): address review: leak FIXME, legal ACL fixture, stronger offset test, prose

Browse Source
This commit is contained in:
Huanqi Cao
2026-08-10 19:34:01 +08:00
parent 59a2e4d825
commit 0a17575040
7 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/sandbox/sandbox-windows-acl/src/index.ts
View File

@@ -249,8 +249,12 @@ export class AclSandbox {
} catch (error) {
// Best-effort close on the failure path (last error already captured in `error`).
api.closeHandle(currentToken)
// Fail-closed cleanup: never leave a revocable (temp) grant or SID
// allocation behind a failed init. Standing workspace ACEs are NOT
// FIXME(windows-acl): a failure after createRestrictedToken leaks the restricted
// token handle and the parsed write SID — this.api stays undefined, so dispose()
// early-returns and cannot clean them up. Close the token and free the write SID
// here (the hardening-followup rework already does both).
// Fail-closed cleanup: revoke the revocable (temp) grants and free the init SID
// allocations a failed init left behind. Standing workspace ACEs are NOT
// revoked — they are the intended end state (the reuse cache), not an
// error artifact.
const cleanupFailures: unknown[] = []
@@ -361,7 +365,7 @@ export class AclSandbox {
}
const token = this.token
/* v8 ignore next -- init assigns this.api only after this.token, so an initialized instance always
has its token; the guard mirrors the write-SID guard's defensive shape. */
has its token; the guard mirrors the write-SID guard. */
if (token !== undefined) {
try {
if (api.closeHandle(token) === 0) throwLastError(api, 'CloseHandle', 'restricted token')