Merge remote-tracking branch 'origin/master' into worktree/default-workspace-write-ui-20260731

apps/web/tests/goal-bar.e2e.ts

@@ -0,0 +1,71 @@
+// Keyless assembled-browser coverage for the goal bar over the shipped Web
+// bundles and FixtureApiClient wire. The command creates a real projected
+// goal in the fixture session; the golden pins the active strip, while the
+// clear gesture proves the acknowledged tombstone leaves neither stale chrome
+// nor a duplicate-mutation error.
+import { fileURLToPath } from 'node:url'
+import { join } from 'node:path'
+import type { Browser, Page } from 'playwright'
+import { chromium } from 'playwright'
+import { afterAll, beforeAll, describe, expect, it, onTestFailed } from 'vitest'
+import {
+  assertFixtureInventory, captureStableAria, compareOrRefreshGolden,
+  launchWebScaffold, watchConsole, webSnapshotMode, type WebScaffold,
+} from './scaffold.ts'
+import { newEnglishPage, saveFailureShot } from './support.ts'
+
+const SNAPSHOT_DIR = fileURLToPath(new URL('./snapshots/goal-bar', import.meta.url))
+const ACTIVE_EXPECTED = join(SNAPSHOT_DIR, 'active.expected.md')
+const OVERLAY = fileURLToPath(new URL('./goal-bar.overlay.yml', import.meta.url))
+const MODE = webSnapshotMode()
+
+describe('web e2e: goal bar clear convergence', () => {
+  let scaffold: WebScaffold
+  let browser: Browser
+  let page: Page
+  let tripwire: ReturnType<typeof watchConsole>
+
+  beforeAll(async () => {
+    scaffold = await launchWebScaffold({ extraOverlayPath: OVERLAY, welcomeNoticePending: true })
+    browser = await chromium.launch()
+    page = await newEnglishPage(browser)
+    tripwire = watchConsole(page)
+    await page.goto(`${scaffold.baseUrl}?fixture`, { waitUntil: 'load' })
+    await page.waitForSelector('[class*="frame"]', { timeout: 30_000 })
+  }, 120_000)
+
+  afterAll(async () => {
+    await browser?.close()
+    await scaffold?.close()
+  })
+
+  it('renders one active goal and clears it without exposing a stale error', async () => {
+    onTestFailed(() => saveFailureShot(page, 'web-e2e-goal-bar-clear'))
+    // Startup reuses the fixture workspace's blank session, keeping this
+    // command independent of alpha's running replay and pending question.
+    const input = page.getByPlaceholder('Describe what you want to build')
+    await input.waitFor({ timeout: 10_000 })
+    await input.fill('/goal guard rapid clear clicks')
+    await input.press('Enter')
+
+    const bar = page.locator('[data-goal-bar]')
+    await bar.waitFor({ timeout: 10_000 })
+    const snapshot = await captureStableAria(page, '[data-goal-bar]', scaffold.workspaceCwd)
+    await compareOrRefreshGolden(ACTIVE_EXPECTED, snapshot, MODE)
+
+    const clear = bar.getByRole('button', { name: 'Clear goal' })
+    await clear.evaluate((button) => {
+      const control = button as HTMLButtonElement
+      control.click()
+      control.click()
+    })
+    await expect.poll(() => page.locator('[data-goal-bar]').count(), { timeout: 10_000 }).toBe(0)
+    expect(await page.getByText(/no current goal/iu).count()).toBe(0)
+    expect(tripwire.pageErrors).toEqual([])
+    expect(tripwire.warnings).toEqual([])
+  }, 60_000)
+
+  it.skipIf(MODE === 'record')('keeps the fixture inventory closed', async () => {
+    await assertFixtureInventory(SNAPSHOT_DIR, ['active.expected.md'])
+  })
+})

apps/web/tests/goal-bar.overlay.yml

@@ -0,0 +1,5 @@
+# The client-side FixtureApiClient intentionally rejects settings writes, so
+# this goal-only scenario omits the durable welcome step that would otherwise
+# cover the page. Onboarding owns separate assembled-browser coverage.
+- id: ui-settings-general
+  disabled: true

apps/web/tests/snapshots/goal-bar/active.expected.md

@@ -0,0 +1,8 @@
+- img
+- text: Ongoing Goal guard rapid clear clicks
+- button "Pause goal":
+  - img
+- button "Edit goal":
+  - img
+- button "Clear goal":
+  - img

apps/web/tsconfig.json

@@ -50,6 +50,7 @@
     "tests/permission-policy-context.e2e.ts",
     "tests/access-confirmation.e2e.ts",
     "tests/shipped-composition.e2e.ts",
+    "tests/goal-bar.e2e.ts",
     "tests/startup-auto-selection.e2e.ts"
   ],
   "references": [