Coder/deepseek-harness
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: classify session fork errors

Browse Source
This commit is contained in:
Hypatia May
2026-06-30 13:04:40 +08:00
parent da94bfd37c
commit 088860b80b
5 changed files with 31 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/session-fork/session-fork/README.md
View File

@@ -21,7 +21,9 @@ Forking inside a turn is rejected with `SessionForkError` code `OPEN_TURN`. The
| Code | Meaning |
|---|---|
| `SESSION_NOT_FOUND` | A source id is not live in `ctx.sessions`, or a passed `Session` object is not the live store object for its id. |
| `SESSION_NOT_FOUND` | A source id is not live in `ctx.sessions`, or a passed `Session` object's id is not live in the store. |
| `SESSION_NOT_LIVE` | A passed `Session` object has a live id in the store, but it is not that live store instance. |
| `SESSION_ALREADY_EXISTS` | The requested child `sessionId` is already live in `ctx.sessions`. |
| `OPEN_TURN` | The source log is non-empty and does not end at `turn/end`. |
## Persistence

8
packages/session-fork/session-fork/src/index.ts
View File

@@ -46,6 +46,8 @@ export interface ForkSessionOptions {
export type SessionForkErrorCode =
| 'SESSION_NOT_FOUND'
| 'SESSION_NOT_LIVE'
| 'SESSION_ALREADY_EXISTS'
| 'OPEN_TURN'
/** Typed error for service-level fork rejections. */
@@ -94,6 +96,9 @@ export class SessionForkService extends Service {
*/
fork(options: ForkSessionOptions): Session {
const snapshot = this.snapshot(options.source)
if (options.sessionId !== undefined && this.ctx.sessions.get(options.sessionId) !== undefined) {
throw new SessionForkError(`session "${options.sessionId}" already exists`, 'SESSION_ALREADY_EXISTS')
}
return this.ctx.sessions.create(options.sessionId, {
seed: snapshot.seed,
meta: snapshot.meta,
@@ -108,9 +113,10 @@ export class SessionForkService extends Service {
}
const live = this.ctx.sessions.get(source.id)
if (live !== source) {
if (live === undefined) {
throw new SessionForkError(`session "${source.id}" not found`, 'SESSION_NOT_FOUND')
}
if (live !== source) throw new SessionForkError(`session "${source.id}" is not the live store instance`, 'SESSION_NOT_LIVE')
return source
}

19
packages/session-fork/session-fork/tests/session-fork.spec.ts
View File

@@ -127,6 +127,15 @@ describe('SessionForkService', () => {
.toThrow(new SessionForkError('session "detached" not found', 'SESSION_NOT_FOUND'))
})
it('rejects a stale Session object whose id is live on a different instance', async () => {
const { ctx, fork } = await setup()
ctx.sessions.create(SessionId('same-id'))
const stale = new Session(SessionId('same-id'))
expect(() => fork.snapshot(stale))
.toThrow(new SessionForkError('session "same-id" is not the live store instance', 'SESSION_NOT_LIVE'))
})
it('rejects non-empty logs whose last event is not turn/end', async () => {
const { ctx, fork } = await setup()
const cases: [string, (session: Session) => void][] = [
@@ -184,6 +193,16 @@ describe('SessionForkService', () => {
expect(firstUserMessage(source.events).data.content).toEqual([{ type: 'text', text: 'hello' }])
})
it('rejects a child session id that is already live with a typed fork error', async () => {
const { ctx, fork } = await setup()
const source = ctx.sessions.create(SessionId('parent'))
appendClosedTurn(source)
ctx.sessions.create(SessionId('child'))
expect(() => fork.fork({ source, sessionId: SessionId('child') }))
.toThrow(new SessionForkError('session "child" already exists', 'SESSION_ALREADY_EXISTS'))
})
it('persists a forked child seed through the existing session write path', async () => {
const root = await tempRoot()
const ctx = new Context()